]> bbs.cooldavid.org Git - net-next-2.6.git/commit
Staging: batman-adv: only modify hna-table on active module
authorLinus Lüssing <linus.luessing@web.de>
Fri, 7 May 2010 19:47:06 +0000 (21:47 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 11 May 2010 20:42:37 +0000 (13:42 -0700)
commitadaaa0c6ab89e82684389b80002bce893179cf2c
tree02cca4e453bab75aeb09126c67cd733e182cf642
parentde37cd49b5a54facef174cf34496919857436e8f
Staging: batman-adv: only modify hna-table on active module

If we haven't set the module to MODULE_ACTIVE state before (in general,
no interface has yet been added to batman-adv) then the hna table is not
initialised yet. If the kernel changes the mac address of the bat0
interface at this moment then an hna_local_add() called by interface_set_mac_addr()
then resulted in a null pointer derefernce. With this patch we are now
explicitly checking before if the state is MODULE_ACTIVE right now so
that we can assume having an initialised hna table.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/batman-adv/soft-interface.c