]> bbs.cooldavid.org Git - net-next-2.6.git/commit
rt2x00: Remove set_tim callback from PCI drivers
authorHelmut Schaa <helmut.schaa@googlemail.com>
Sun, 11 Jul 2010 10:29:26 +0000 (12:29 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 12 Jul 2010 20:05:35 +0000 (16:05 -0400)
commitab0ed4aba80f430fafd842cee8d74f6b40493483
treef73282dad04699935fa1fdfa8d240380549bc927
parente783619ea8f1fb9fccec4931b0cf956de0ed1019
rt2x00: Remove set_tim callback from PCI drivers

Using the set_tim callback without managing the DTIM count and the
broad- and multicast buffering in hw, fw or the driver results in wrong
DTIM count values being sent out in beacons. Since all PCI drivers
fetch new beacons periodically and hence get an updated TIM we can just
remove the set_tim callback from these.

The rt2x00 USB drivers don't update the beacon periodically and thus
rely on the set_tim callback to get a correct TIM for beacon
transmission. USB devices still suffer from the DTIM count being wrong
under some circumstances but removing the set_tim callback from these
would cause more harm then good.

Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2400pci.c
drivers/net/wireless/rt2x00/rt2500pci.c
drivers/net/wireless/rt2x00/rt2800pci.c
drivers/net/wireless/rt2x00/rt61pci.c