]> bbs.cooldavid.org Git - net-next-2.6.git/commit
[S390] appldata_base: Misc cpuinit annotations and bugfix
authorSatyam Sharma <satyam@infradead.org>
Fri, 12 Oct 2007 14:11:31 +0000 (16:11 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Fri, 12 Oct 2007 14:13:05 +0000 (16:13 +0200)
commit11b8bf0107e688434b9e0570fd05e7c715534f3b
treea20866c1fbc638fa9026c4ea1919ed13f3f6d685
parent2af48080e100d66db8f086af70a70713a953a83d
[S390] appldata_base: Misc cpuinit annotations and bugfix

appldata_offline_cpu() is only called from __cpuinit-marked hotplug
notifier callback and from the __exit-marked module_exit function,
therefore candidate for __cpuexit.

BTW the __exit module_exit function appldata_exit() of this driver fails to
unregister_hotcpu_notifier() the notifier_block that was registered by
appldata_init() during module startup.  This will lead to oops if hotplug
notification comes after module has been unloaded.  Let's fix this by
unregistering the notifier appropriately (before appldata_offline_cpu()'ing
the CPUs).

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/appldata/appldata_base.c