]> bbs.cooldavid.org Git - net-next-2.6.git/commit - kernel/sched.c
sched: Remove branch hints within context_switch()
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Thu, 16 Sep 2010 12:42:25 +0000 (14:42 +0200)
committerIngo Molnar <mingo@elte.hu>
Thu, 16 Sep 2010 14:38:34 +0000 (16:38 +0200)
commit31915ab4cbf507aadab40847cf9989da5e88b090
tree48f7f64cbfd82ee88cece1384e6eb949ef2cbed0
parent7740191cd909b75d75685fb08a5d1f54b8a9d28b
sched: Remove branch hints within context_switch()

With 710390d9 "sched: Optimize branch hint in context_switch()"
the branch hint logic within context_switch() got inversed.

In fact the hints "if (likely(!mm))" and "if (likely(!prev->mm))"
mean that it is likely that the previous and next task are kernel
threads.

That assumption is certainly counter intuitive, but Tim has shown
that at least with his workload this is true. Nevertheless the
truth is: it depends on the current workload. So just remove the
annotations which also improves readability.

Reported-by: Tim Blechmann <tim@klingt.org>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <20100916124225.GA2209@osiris.boeblingen.de.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c