]> bbs.cooldavid.org Git - net-next-2.6.git/commit - drivers/s390/net/ctcm_mpc.c
ctcm: fix minor findings from code analysis tool
authorJoel A. Fowler <fowlerja@us.ibm.com>
Tue, 24 Mar 2009 03:27:49 +0000 (03:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Mar 2009 22:24:31 +0000 (15:24 -0700)
commite2fc8cb4fedf57a63c05cd1e0f6e4f0e0238614a
tree6a1c128870d78419921db7b4b6b6522b5d398a9a
parentfb8585fc3f9b39153e0bdaf03f00a02dde9c03c6
ctcm: fix minor findings from code analysis tool

From: Ursula Braun <ursula.braun@de.ibm.com>

This patch fixes problems in the ctcm driver identified by
static code analysis:
o remove an unnecessary always true condition in ctcm_unpack_skb
o remove duplicate assignment in ctc_mpc_alloc_channel
o remove an unnecessary always true condition in ctcmpc_send_sweep_resp
o remove duplicate initialization in ctcmpc_unpack_skb
o shorten if condition in mpc_action_go_inop
o remove INOP event if mpc group is undefined in mpc_action_doxid7

Signed-off-by: Joel A. Fowler <fowlerja@us.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/ctcm_main.c
drivers/s390/net/ctcm_mpc.c