]> bbs.cooldavid.org Git - net-next-2.6.git/commit - drivers/net/ucc_geth.c
ucc_geth: NAPI-related bug fixes
authorMichael Reiss <michael.f.reiss@freescale.com>
Fri, 13 Apr 2007 06:26:11 +0000 (01:26 -0500)
committerJeff Garzik <jeff@garzik.org>
Sat, 28 Apr 2007 15:01:04 +0000 (11:01 -0400)
commit702ff12ce7e9643084232a8d50b0b1eec26026ae
treed00d43218efdc3f6e5356c638438f2f0a2bc3774
parent728de4c927a3544b6d3da331b634035d4c75ca17
ucc_geth: NAPI-related bug fixes

Based partly on the gianfar driver, this patch fixes several
bugs which were causing NAPI to be completely unusable.
* An IRQ is still needed in NAPI, to kick off NAPI task,
  and for Tx processing.  Request the IRQ.
* If rx_work_limit = 0 we are not complete.
* While running Rx NAPI processing we must mask Rx events,
  including Rx busy.
* ucc_geth_rx function does not need a lock.
  Could lead to deadlock in NAPI case.
* There's no need to loop reading ucce multiple times in the ISR,
  so while adding the call to schedule NAPI which was not there,
  simplify the event processing into if-else format.
* Rx Busy now kicks off NAPI processing, while still
  being counted as an error.

Signed-off-by: Michael Reiss <michael.f.reiss@freescale.com>
Signed-off-by: Michael Barkowski <michael.barkowski@freescale.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/ucc_geth.c
drivers/net/ucc_geth.h