]> bbs.cooldavid.org Git - net-next-2.6.git/commit - drivers/md/md.h
md: fix another deadlock with removing sysfs attributes.
authorNeilBrown <neilb@suse.de>
Sun, 8 Aug 2010 11:18:03 +0000 (21:18 +1000)
committerNeilBrown <neilb@suse.de>
Sun, 8 Aug 2010 11:21:27 +0000 (21:21 +1000)
commitbb4f1e9d0e2ef93de8e36ca0f5f26625fcd70b7d
tree7c7edc0d5fa2b5702358f11396d52d07183708c0
parent147e0b6a639ac581ca3bf627bedc3f4a6d3eca66
md: fix another deadlock with removing sysfs attributes.

Move the deletion of sysfs attributes from reconfig_mutex to
open_mutex didn't really help as a process can try to take
open_mutex while holding reconfig_mutex, so the same deadlock can
happen, just requiring one more process to be involved in the chain.

I looks like I cannot easily use locking to wait for the sysfs
deletion to complete, so don't.

The only things that we cannot do while the deletions are still
pending is other things which can change the sysfs namespace: run,
takeover, stop.  Each of these can fail with -EBUSY.
So set a flag while doing a sysfs deletion, and fail run, takeover,
stop if that flag is set.

This is suitable for 2.6.35.x

Cc: stable@kernel.org
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/md.c
drivers/md/md.h