]> bbs.cooldavid.org Git - net-next-2.6.git/commit - drivers/ata/libata-core.c
[PATCH] libata: fix ata_qc_issue failure path
authorTejun Heo <htejun@gmail.com>
Fri, 31 Mar 2006 11:36:47 +0000 (20:36 +0900)
committerJeff Garzik <jeff@garzik.org>
Fri, 31 Mar 2006 15:14:42 +0000 (10:14 -0500)
commite4a70e76add280db6068426716a9b2a74099144f
treeb978d7da736590fe0603e7a88a7a9b20cc2a36b1
parent79ea24e72e59b5f0951483cc4f357afe9bf7ff89
[PATCH] libata: fix ata_qc_issue failure path

On sg_err failure path, ata_qc_issue() doesn't mark the qc active
before returning.  This triggers WARN_ON() in __ata_qc_complete() when
the qc gets completed.  This patch moves ap->active_tag and
QCFLAG_ACTIVE setting to the top of the function.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/libata-core.c