ASoC: Check list debugfs files for PAGE_SIZE overflow

[net-next-2.6.git] / sound / soc / soc-core.c

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 6001b7f0a13861325dd84795a5c8ddb8468814a5..6cee97e23da67c453013de5ddf760186744b9a71 100644 (file)
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -274,15 +274,22 @@ static ssize_t codec_list_read_file(struct file *file, char __user *user_buf,
                                    size_t count, loff_t *ppos)
 {
        char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
-       ssize_t ret = 0;
+       ssize_t len, ret = 0;
        struct snd_soc_codec *codec;
 
        if (!buf)
                return -ENOMEM;
 
-       list_for_each_entry(codec, &codec_list, list)
-               ret += snprintf(buf + ret, PAGE_SIZE - ret, "%s\n",
-                               codec->name);
+       list_for_each_entry(codec, &codec_list, list) {
+               len = snprintf(buf + ret, PAGE_SIZE - ret, "%s\n",
+                              codec->name);
+               if (len >= 0)
+                       ret += len;
+               if (ret > PAGE_SIZE) {
+                       ret = PAGE_SIZE;
+                       break;
+               }
+       }
 
        if (ret >= 0)
                ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
@@ -301,17 +308,23 @@ static ssize_t dai_list_read_file(struct file *file, char __user *user_buf,
                                  size_t count, loff_t *ppos)
 {
        char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
-       ssize_t ret = 0;
+       ssize_t len, ret = 0;
        struct snd_soc_dai *dai;
 
        if (!buf)
                return -ENOMEM;
 
-       list_for_each_entry(dai, &dai_list, list)
-               ret += snprintf(buf + ret, PAGE_SIZE - ret, "%s\n", dai->name);
+       list_for_each_entry(dai, &dai_list, list) {
+               len = snprintf(buf + ret, PAGE_SIZE - ret, "%s\n", dai->name);
+               if (len >= 0)
+                       ret += len;
+               if (ret > PAGE_SIZE) {
+                       ret = PAGE_SIZE;
+                       break;
+               }
+       }
 
-       if (ret >= 0)
-               ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
+       ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
 
        kfree(buf);
 
@@ -328,18 +341,24 @@ static ssize_t platform_list_read_file(struct file *file,
                                       size_t count, loff_t *ppos)
 {
        char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
-       ssize_t ret = 0;
+       ssize_t len, ret = 0;
        struct snd_soc_platform *platform;
 
        if (!buf)
                return -ENOMEM;
 
-       list_for_each_entry(platform, &platform_list, list)
-               ret += snprintf(buf + ret, PAGE_SIZE - ret, "%s\n",
-                               platform->name);
+       list_for_each_entry(platform, &platform_list, list) {
+               len = snprintf(buf + ret, PAGE_SIZE - ret, "%s\n",
+                              platform->name);
+               if (len >= 0)
+                       ret += len;
+               if (ret > PAGE_SIZE) {
+                       ret = PAGE_SIZE;
+                       break;
+               }
+       }
 
-       if (ret >= 0)
-               ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
+       ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
 
        kfree(buf);
 
@@ -1451,7 +1470,6 @@ static int soc_probe_dai_link(struct snd_soc_card *card, int num)
        snd_soc_dapm_sync(codec);
 
        /* register the rtd device */
-       rtd->dev.init_name = rtd->dai_link->stream_name;
        rtd->dev.release = rtd_release;
        rtd->dev.init_name = dai_link->name;
        ret = device_register(&rtd->dev);
@@ -1498,6 +1516,16 @@ static int soc_register_ac97_dai_link(struct snd_soc_pcm_runtime *rtd)
         * for the generic AC97 subsystem.
         */
        if (rtd->codec_dai->driver->ac97_control && !rtd->codec->ac97_registered) {
+               /*
+                * It is possible that the AC97 device is already registered to
+                * the device subsystem. This happens when the device is created
+                * via snd_ac97_mixer(). Currently only SoC codec that does so
+                * is the generic AC97 glue but others migh emerge.
+                *
+                * In those cases we don't try to register the device again.
+                */
+               if (!rtd->codec->ac97_created)
+                       return 0;
 
                ret = soc_ac97_dev_register(rtd->codec);
                if (ret < 0) {
@@ -1567,7 +1595,8 @@ static void snd_soc_instantiate_card(struct snd_soc_card *card)
        for (i = 0; i < card->num_links; i++) {
                ret = soc_probe_dai_link(card, i);
                if (ret < 0) {
-                       printk(KERN_ERR "asoc: failed to instanciate card %s\n", card->name);
+                       pr_err("asoc: failed to instantiate card %s: %d\n",
+                              card->name, ret);
                        goto probe_dai_err;
                }
        }
@@ -1812,6 +1841,13 @@ int snd_soc_new_ac97_codec(struct snd_soc_codec *codec,
 
        codec->ac97->bus->ops = ops;
        codec->ac97->num = num;
+
+       /*
+        * Mark the AC97 device to be created by us. This way we ensure that the
+        * device will be registered with the device subsystem later on.
+        */
+       codec->ac97_created = 1;
+
        mutex_unlock(&codec->mutex);
        return 0;
 }
@@ -1832,6 +1868,7 @@ void snd_soc_free_ac97_codec(struct snd_soc_codec *codec)
        kfree(codec->ac97->bus);
        kfree(codec->ac97);
        codec->ac97 = NULL;
+       codec->ac97_created = 0;
        mutex_unlock(&codec->mutex);
 }
 EXPORT_SYMBOL_GPL(snd_soc_free_ac97_codec);
@@ -1982,8 +2019,8 @@ int snd_soc_add_controls(struct snd_soc_codec *codec,
                const struct snd_kcontrol_new *control = &controls[i];
                err = snd_ctl_add(card, snd_soc_cnew(control, codec, NULL));
                if (err < 0) {
-                       dev_err(codec->dev, "%s: Failed to add %s\n",
-                               codec->name, control->name);
+                       dev_err(codec->dev, "%s: Failed to add %s: %d\n",
+                               codec->name, control->name, err);
                        return err;
                }
        }
@@ -3288,6 +3325,7 @@ static int __init snd_soc_init(void)
 
        return platform_driver_register(&soc_driver);
 }
+module_init(snd_soc_init);
 
 static void __exit snd_soc_exit(void)
 {
@@ -3296,8 +3334,6 @@ static void __exit snd_soc_exit(void)
 #endif
        platform_driver_unregister(&soc_driver);
 }
-
-module_init(snd_soc_init);
 module_exit(snd_soc_exit);
 
 /* Module information */