]> bbs.cooldavid.org Git - net-next-2.6.git/blobdiff - security/tomoyo/file.c
TOMOYO: Use common structure for list element.
[net-next-2.6.git] / security / tomoyo / file.c
index cef685415df1c587f86d19c4f83e9bb1664d8f3e..09436d11f298ff7d770110cfcf22429ea20d359a 100644 (file)
@@ -51,6 +51,42 @@ static const char *tomoyo_path_number_keyword
        [TOMOYO_TYPE_CHGRP]      = "chgrp",
 };
 
+static const u8 tomoyo_p2mac[TOMOYO_MAX_PATH_OPERATION] = {
+       [TOMOYO_TYPE_READ_WRITE] = TOMOYO_MAC_FILE_OPEN,
+       [TOMOYO_TYPE_EXECUTE]    = TOMOYO_MAC_FILE_EXECUTE,
+       [TOMOYO_TYPE_READ]       = TOMOYO_MAC_FILE_OPEN,
+       [TOMOYO_TYPE_WRITE]      = TOMOYO_MAC_FILE_OPEN,
+       [TOMOYO_TYPE_UNLINK]     = TOMOYO_MAC_FILE_UNLINK,
+       [TOMOYO_TYPE_RMDIR]      = TOMOYO_MAC_FILE_RMDIR,
+       [TOMOYO_TYPE_TRUNCATE]   = TOMOYO_MAC_FILE_TRUNCATE,
+       [TOMOYO_TYPE_SYMLINK]    = TOMOYO_MAC_FILE_SYMLINK,
+       [TOMOYO_TYPE_REWRITE]    = TOMOYO_MAC_FILE_REWRITE,
+       [TOMOYO_TYPE_CHROOT]     = TOMOYO_MAC_FILE_CHROOT,
+       [TOMOYO_TYPE_UMOUNT]     = TOMOYO_MAC_FILE_UMOUNT,
+};
+
+static const u8 tomoyo_pnnn2mac[TOMOYO_MAX_PATH_NUMBER3_OPERATION] = {
+       [TOMOYO_TYPE_MKBLOCK] = TOMOYO_MAC_FILE_MKBLOCK,
+       [TOMOYO_TYPE_MKCHAR]  = TOMOYO_MAC_FILE_MKCHAR,
+};
+
+static const u8 tomoyo_pp2mac[TOMOYO_MAX_PATH2_OPERATION] = {
+       [TOMOYO_TYPE_LINK]       = TOMOYO_MAC_FILE_LINK,
+       [TOMOYO_TYPE_RENAME]     = TOMOYO_MAC_FILE_RENAME,
+       [TOMOYO_TYPE_PIVOT_ROOT] = TOMOYO_MAC_FILE_PIVOT_ROOT,
+};
+
+static const u8 tomoyo_pn2mac[TOMOYO_MAX_PATH_NUMBER_OPERATION] = {
+       [TOMOYO_TYPE_CREATE] = TOMOYO_MAC_FILE_CREATE,
+       [TOMOYO_TYPE_MKDIR]  = TOMOYO_MAC_FILE_MKDIR,
+       [TOMOYO_TYPE_MKFIFO] = TOMOYO_MAC_FILE_MKFIFO,
+       [TOMOYO_TYPE_MKSOCK] = TOMOYO_MAC_FILE_MKSOCK,
+       [TOMOYO_TYPE_IOCTL]  = TOMOYO_MAC_FILE_IOCTL,
+       [TOMOYO_TYPE_CHMOD]  = TOMOYO_MAC_FILE_CHMOD,
+       [TOMOYO_TYPE_CHOWN]  = TOMOYO_MAC_FILE_CHOWN,
+       [TOMOYO_TYPE_CHGRP]  = TOMOYO_MAC_FILE_CHGRP,
+};
+
 void tomoyo_put_name_union(struct tomoyo_name_union *ptr)
 {
        if (!ptr)
@@ -65,23 +101,10 @@ bool tomoyo_compare_name_union(const struct tomoyo_path_info *name,
                               const struct tomoyo_name_union *ptr)
 {
        if (ptr->is_group)
-               return tomoyo_path_matches_group(name, ptr->group, 1);
+               return tomoyo_path_matches_group(name, ptr->group);
        return tomoyo_path_matches_pattern(name, ptr->filename);
 }
 
-static bool tomoyo_compare_name_union_pattern(const struct tomoyo_path_info
-                                             *name,
-                                             const struct tomoyo_name_union
-                                             *ptr, const bool may_use_pattern)
-{
-       if (ptr->is_group)
-               return tomoyo_path_matches_group(name, ptr->group,
-                                                may_use_pattern);
-       if (may_use_pattern || !ptr->filename->is_patterned)
-               return tomoyo_path_matches_pattern(name, ptr->filename);
-       return false;
-}
-
 void tomoyo_put_number_union(struct tomoyo_number_union *ptr)
 {
        if (ptr && ptr->is_group)
@@ -247,17 +270,18 @@ static int tomoyo_update_globally_readable_entry(const char *filename,
        struct tomoyo_globally_readable_file_entry e = { };
        int error = is_delete ? -ENOENT : -ENOMEM;
 
-       if (!tomoyo_is_correct_path(filename, 1, 0, -1))
+       if (!tomoyo_is_correct_word(filename))
                return -EINVAL;
        e.filename = tomoyo_get_name(filename);
        if (!e.filename)
                return -ENOMEM;
        if (mutex_lock_interruptible(&tomoyo_policy_lock))
                goto out;
-       list_for_each_entry_rcu(ptr, &tomoyo_globally_readable_list, list) {
+       list_for_each_entry_rcu(ptr, &tomoyo_globally_readable_list,
+                               head.list) {
                if (ptr->filename != e.filename)
                        continue;
-               ptr->is_deleted = is_delete;
+               ptr->head.is_deleted = is_delete;
                error = 0;
                break;
        }
@@ -265,7 +289,7 @@ static int tomoyo_update_globally_readable_entry(const char *filename,
                struct tomoyo_globally_readable_file_entry *entry =
                        tomoyo_commit_ok(&e, sizeof(e));
                if (entry) {
-                       list_add_tail_rcu(&entry->list,
+                       list_add_tail_rcu(&entry->head.list,
                                          &tomoyo_globally_readable_list);
                        error = 0;
                }
@@ -291,8 +315,9 @@ static bool tomoyo_is_globally_readable_file(const struct tomoyo_path_info *
        struct tomoyo_globally_readable_file_entry *ptr;
        bool found = false;
 
-       list_for_each_entry_rcu(ptr, &tomoyo_globally_readable_list, list) {
-               if (!ptr->is_deleted &&
+       list_for_each_entry_rcu(ptr, &tomoyo_globally_readable_list,
+                               head.list) {
+               if (!ptr->head.is_deleted &&
                    tomoyo_path_matches_pattern(filename, ptr->filename)) {
                        found = true;
                        break;
@@ -335,8 +360,8 @@ bool tomoyo_read_globally_readable_policy(struct tomoyo_io_buffer *head)
                struct tomoyo_globally_readable_file_entry *ptr;
                ptr = list_entry(pos,
                                 struct tomoyo_globally_readable_file_entry,
-                                list);
-               if (ptr->is_deleted)
+                                head.list);
+               if (ptr->head.is_deleted)
                        continue;
                done = tomoyo_io_printf(head, TOMOYO_KEYWORD_ALLOW_READ "%s\n",
                                        ptr->filename->name);
@@ -391,19 +416,20 @@ static int tomoyo_update_file_pattern_entry(const char *pattern,
                                            const bool is_delete)
 {
        struct tomoyo_pattern_entry *ptr;
-       struct tomoyo_pattern_entry e = { .pattern = tomoyo_get_name(pattern) };
+       struct tomoyo_pattern_entry e = { };
        int error = is_delete ? -ENOENT : -ENOMEM;
 
+       if (!tomoyo_is_correct_word(pattern))
+               return -EINVAL;
+       e.pattern = tomoyo_get_name(pattern);
        if (!e.pattern)
                return error;
-       if (!e.pattern->is_patterned)
-               goto out;
        if (mutex_lock_interruptible(&tomoyo_policy_lock))
                goto out;
-       list_for_each_entry_rcu(ptr, &tomoyo_pattern_list, list) {
+       list_for_each_entry_rcu(ptr, &tomoyo_pattern_list, head.list) {
                if (e.pattern != ptr->pattern)
                        continue;
-               ptr->is_deleted = is_delete;
+               ptr->head.is_deleted = is_delete;
                error = 0;
                break;
        }
@@ -411,7 +437,8 @@ static int tomoyo_update_file_pattern_entry(const char *pattern,
                struct tomoyo_pattern_entry *entry =
                        tomoyo_commit_ok(&e, sizeof(e));
                if (entry) {
-                       list_add_tail_rcu(&entry->list, &tomoyo_pattern_list);
+                       list_add_tail_rcu(&entry->head.list,
+                                         &tomoyo_pattern_list);
                        error = 0;
                }
        }
@@ -435,8 +462,8 @@ const char *tomoyo_file_pattern(const struct tomoyo_path_info *filename)
        struct tomoyo_pattern_entry *ptr;
        const struct tomoyo_path_info *pattern = NULL;
 
-       list_for_each_entry_rcu(ptr, &tomoyo_pattern_list, list) {
-               if (ptr->is_deleted)
+       list_for_each_entry_rcu(ptr, &tomoyo_pattern_list, head.list) {
+               if (ptr->head.is_deleted)
                        continue;
                if (!tomoyo_path_matches_pattern(filename, ptr->pattern))
                        continue;
@@ -484,8 +511,8 @@ bool tomoyo_read_file_pattern(struct tomoyo_io_buffer *head)
 
        list_for_each_cookie(pos, head->read_var2, &tomoyo_pattern_list) {
                struct tomoyo_pattern_entry *ptr;
-               ptr = list_entry(pos, struct tomoyo_pattern_entry, list);
-               if (ptr->is_deleted)
+               ptr = list_entry(pos, struct tomoyo_pattern_entry, head.list);
+               if (ptr->head.is_deleted)
                        continue;
                done = tomoyo_io_printf(head, TOMOYO_KEYWORD_FILE_PATTERN
                                        "%s\n", ptr->pattern->name);
@@ -543,17 +570,17 @@ static int tomoyo_update_no_rewrite_entry(const char *pattern,
        struct tomoyo_no_rewrite_entry e = { };
        int error = is_delete ? -ENOENT : -ENOMEM;
 
-       if (!tomoyo_is_correct_path(pattern, 0, 0, 0))
+       if (!tomoyo_is_correct_word(pattern))
                return -EINVAL;
        e.pattern = tomoyo_get_name(pattern);
        if (!e.pattern)
                return error;
        if (mutex_lock_interruptible(&tomoyo_policy_lock))
                goto out;
-       list_for_each_entry_rcu(ptr, &tomoyo_no_rewrite_list, list) {
+       list_for_each_entry_rcu(ptr, &tomoyo_no_rewrite_list, head.list) {
                if (ptr->pattern != e.pattern)
                        continue;
-               ptr->is_deleted = is_delete;
+               ptr->head.is_deleted = is_delete;
                error = 0;
                break;
        }
@@ -561,7 +588,7 @@ static int tomoyo_update_no_rewrite_entry(const char *pattern,
                struct tomoyo_no_rewrite_entry *entry =
                        tomoyo_commit_ok(&e, sizeof(e));
                if (entry) {
-                       list_add_tail_rcu(&entry->list,
+                       list_add_tail_rcu(&entry->head.list,
                                          &tomoyo_no_rewrite_list);
                        error = 0;
                }
@@ -587,8 +614,8 @@ static bool tomoyo_is_no_rewrite_file(const struct tomoyo_path_info *filename)
        struct tomoyo_no_rewrite_entry *ptr;
        bool found = false;
 
-       list_for_each_entry_rcu(ptr, &tomoyo_no_rewrite_list, list) {
-               if (ptr->is_deleted)
+       list_for_each_entry_rcu(ptr, &tomoyo_no_rewrite_list, head.list) {
+               if (ptr->head.is_deleted)
                        continue;
                if (!tomoyo_path_matches_pattern(filename, ptr->pattern))
                        continue;
@@ -629,8 +656,9 @@ bool tomoyo_read_no_rewrite_policy(struct tomoyo_io_buffer *head)
 
        list_for_each_cookie(pos, head->read_var2, &tomoyo_no_rewrite_list) {
                struct tomoyo_no_rewrite_entry *ptr;
-               ptr = list_entry(pos, struct tomoyo_no_rewrite_entry, list);
-               if (ptr->is_deleted)
+               ptr = list_entry(pos, struct tomoyo_no_rewrite_entry,
+                                head.list);
+               if (ptr->head.is_deleted)
                        continue;
                done = tomoyo_io_printf(head, TOMOYO_KEYWORD_DENY_REWRITE
                                        "%s\n", ptr->pattern->name);
@@ -640,57 +668,12 @@ bool tomoyo_read_no_rewrite_policy(struct tomoyo_io_buffer *head)
        return done;
 }
 
-/**
- * tomoyo_update_file_acl - Update file's read/write/execute ACL.
- *
- * @perm:      Permission (between 1 to 7).
- * @filename:  Filename.
- * @domain:    Pointer to "struct tomoyo_domain_info".
- * @is_delete: True if it is a delete request.
- *
- * Returns 0 on success, negative value otherwise.
- *
- * This is legacy support interface for older policy syntax.
- * Current policy syntax uses "allow_read/write" instead of "6",
- * "allow_read" instead of "4", "allow_write" instead of "2",
- * "allow_execute" instead of "1".
- *
- * Caller holds tomoyo_read_lock().
- */
-static int tomoyo_update_file_acl(u8 perm, const char *filename,
-                                 struct tomoyo_domain_info * const domain,
-                                 const bool is_delete)
-{
-       if (perm > 7 || !perm) {
-               printk(KERN_DEBUG "%s: Invalid permission '%d %s'\n",
-                      __func__, perm, filename);
-               return -EINVAL;
-       }
-       if (filename[0] != '@' && tomoyo_strendswith(filename, "/"))
-               /*
-                * Only 'allow_mkdir' and 'allow_rmdir' are valid for
-                * directory permissions.
-                */
-               return 0;
-       if (perm & 4)
-               tomoyo_update_path_acl(TOMOYO_TYPE_READ, filename, domain,
-                                      is_delete);
-       if (perm & 2)
-               tomoyo_update_path_acl(TOMOYO_TYPE_WRITE, filename, domain,
-                                      is_delete);
-       if (perm & 1)
-               tomoyo_update_path_acl(TOMOYO_TYPE_EXECUTE, filename, domain,
-                                      is_delete);
-       return 0;
-}
-
 /**
  * tomoyo_path_acl - Check permission for single path operation.
  *
  * @r:               Pointer to "struct tomoyo_request_info".
  * @filename:        Filename to check.
  * @perm:            Permission.
- * @may_use_pattern: True if patterned ACL is permitted.
  *
  * Returns 0 on success, -EPERM otherwise.
  *
@@ -698,7 +681,7 @@ static int tomoyo_update_file_acl(u8 perm, const char *filename,
  */
 static int tomoyo_path_acl(const struct tomoyo_request_info *r,
                           const struct tomoyo_path_info *filename,
-                          const u32 perm, const bool may_use_pattern)
+                          const u32 perm)
 {
        struct tomoyo_domain_info *domain = r->domain;
        struct tomoyo_acl_info *ptr;
@@ -710,8 +693,7 @@ static int tomoyo_path_acl(const struct tomoyo_request_info *r,
                        continue;
                acl = container_of(ptr, struct tomoyo_path_acl, head);
                if (!(acl->perm & perm) ||
-                   !tomoyo_compare_name_union_pattern(filename, &acl->name,
-                                                       may_use_pattern))
+                   !tomoyo_compare_name_union(filename, &acl->name))
                        continue;
                error = 0;
                break;
@@ -756,7 +738,7 @@ static int tomoyo_file_perm(struct tomoyo_request_info *r,
        } else
                BUG();
        do {
-               error = tomoyo_path_acl(r, filename, perm, mode != 1);
+               error = tomoyo_path_acl(r, filename, perm);
                if (error && mode == 4 && !r->domain->ignore_global_allow_read
                    && tomoyo_is_globally_readable_file(filename))
                        error = 0;
@@ -764,7 +746,6 @@ static int tomoyo_file_perm(struct tomoyo_request_info *r,
                        break;
                tomoyo_warn_log(r, "%s %s", msg, filename->name);
                error = tomoyo_supervisor(r, "allow_%s %s\n", msg,
-                                         mode == 1 ? filename->name :
                                          tomoyo_file_pattern(filename));
                /*
                  * Do not retry for execute request, for alias may have
@@ -776,6 +757,40 @@ static int tomoyo_file_perm(struct tomoyo_request_info *r,
        return error;
 }
 
+static bool tomoyo_same_path_acl(const struct tomoyo_acl_info *a,
+                                const struct tomoyo_acl_info *b)
+{
+       const struct tomoyo_path_acl *p1 = container_of(a, typeof(*p1), head);
+       const struct tomoyo_path_acl *p2 = container_of(b, typeof(*p2), head);
+       return tomoyo_is_same_acl_head(&p1->head, &p2->head) &&
+               tomoyo_is_same_name_union(&p1->name, &p2->name);
+}
+
+static bool tomoyo_merge_path_acl(struct tomoyo_acl_info *a,
+                                 struct tomoyo_acl_info *b,
+                                 const bool is_delete)
+{
+       u16 * const a_perm = &container_of(a, struct tomoyo_path_acl, head)
+               ->perm;
+       u16 perm = *a_perm;
+       const u16 b_perm = container_of(b, struct tomoyo_path_acl, head)->perm;
+       if (is_delete) {
+               perm &= ~b_perm;
+               if ((perm & TOMOYO_RW_MASK) != TOMOYO_RW_MASK)
+                       perm &= ~(1 << TOMOYO_TYPE_READ_WRITE);
+               else if (!(perm & (1 << TOMOYO_TYPE_READ_WRITE)))
+                       perm &= ~TOMOYO_RW_MASK;
+       } else {
+               perm |= b_perm;
+               if ((perm & TOMOYO_RW_MASK) == TOMOYO_RW_MASK)
+                       perm |= (1 << TOMOYO_TYPE_READ_WRITE);
+               else if (perm & (1 << TOMOYO_TYPE_READ_WRITE))
+                       perm |= TOMOYO_RW_MASK;
+       }
+       *a_perm = perm;
+       return !perm;
+}
+
 /**
  * tomoyo_update_path_acl - Update "struct tomoyo_path_acl" list.
  *
@@ -789,63 +804,56 @@ static int tomoyo_file_perm(struct tomoyo_request_info *r,
  * Caller holds tomoyo_read_lock().
  */
 static int tomoyo_update_path_acl(const u8 type, const char *filename,
-                                 struct tomoyo_domain_info *const domain,
+                                 struct tomoyo_domain_info * const domain,
                                  const bool is_delete)
 {
-       static const u16 tomoyo_rw_mask =
-               (1 << TOMOYO_TYPE_READ) | (1 << TOMOYO_TYPE_WRITE);
-       const u16 perm = 1 << type;
-       struct tomoyo_acl_info *ptr;
        struct tomoyo_path_acl e = {
                .head.type = TOMOYO_TYPE_PATH_ACL,
-               .perm = perm
+               .perm = 1 << type
        };
-       int error = is_delete ? -ENOENT : -ENOMEM;
-
-       if (type == TOMOYO_TYPE_READ_WRITE)
-               e.perm |= tomoyo_rw_mask;
-       if (!domain)
-               return -EINVAL;
+       int error;
+       if (e.perm == (1 << TOMOYO_TYPE_READ_WRITE))
+               e.perm |= TOMOYO_RW_MASK;
        if (!tomoyo_parse_name_union(filename, &e.name))
                return -EINVAL;
-       if (mutex_lock_interruptible(&tomoyo_policy_lock))
-               goto out;
-       list_for_each_entry_rcu(ptr, &domain->acl_info_list, list) {
-               struct tomoyo_path_acl *acl =
-                       container_of(ptr, struct tomoyo_path_acl, head);
-               if (!tomoyo_is_same_path_acl(acl, &e))
-                       continue;
-               if (is_delete) {
-                       acl->perm &= ~perm;
-                       if ((acl->perm & tomoyo_rw_mask) != tomoyo_rw_mask)
-                               acl->perm &= ~(1 << TOMOYO_TYPE_READ_WRITE);
-                       else if (!(acl->perm & (1 << TOMOYO_TYPE_READ_WRITE)))
-                               acl->perm &= ~tomoyo_rw_mask;
-               } else {
-                       acl->perm |= perm;
-                       if ((acl->perm & tomoyo_rw_mask) == tomoyo_rw_mask)
-                               acl->perm |= 1 << TOMOYO_TYPE_READ_WRITE;
-                       else if (acl->perm & (1 << TOMOYO_TYPE_READ_WRITE))
-                               acl->perm |= tomoyo_rw_mask;
-               }
-               error = 0;
-               break;
-       }
-       if (!is_delete && error) {
-               struct tomoyo_path_acl *entry =
-                       tomoyo_commit_ok(&e, sizeof(e));
-               if (entry) {
-                       list_add_tail_rcu(&entry->head.list,
-                                         &domain->acl_info_list);
-                       error = 0;
-               }
-       }
-       mutex_unlock(&tomoyo_policy_lock);
- out:
+       error = tomoyo_update_domain(&e.head, sizeof(e), is_delete, domain,
+                                    tomoyo_same_path_acl,
+                                    tomoyo_merge_path_acl);
        tomoyo_put_name_union(&e.name);
        return error;
 }
 
+static bool tomoyo_same_path_number3_acl(const struct tomoyo_acl_info *a,
+                                        const struct tomoyo_acl_info *b)
+{
+       const struct tomoyo_path_number3_acl *p1 = container_of(a, typeof(*p1),
+                                                               head);
+       const struct tomoyo_path_number3_acl *p2 = container_of(b, typeof(*p2),
+                                                               head);
+       return tomoyo_is_same_acl_head(&p1->head, &p2->head)
+               && tomoyo_is_same_name_union(&p1->name, &p2->name)
+               && tomoyo_is_same_number_union(&p1->mode, &p2->mode)
+               && tomoyo_is_same_number_union(&p1->major, &p2->major)
+               && tomoyo_is_same_number_union(&p1->minor, &p2->minor);
+}
+
+static bool tomoyo_merge_path_number3_acl(struct tomoyo_acl_info *a,
+                                         struct tomoyo_acl_info *b,
+                                         const bool is_delete)
+{
+       u8 *const a_perm = &container_of(a, struct tomoyo_path_number3_acl,
+                                        head)->perm;
+       u8 perm = *a_perm;
+       const u8 b_perm = container_of(b, struct tomoyo_path_number3_acl, head)
+               ->perm;
+       if (is_delete)
+               perm &= ~b_perm;
+       else
+               perm |= b_perm;
+       *a_perm = perm;
+       return !perm;
+}
+
 /**
  * tomoyo_update_path_number3_acl - Update "struct tomoyo_path_number3_acl" list.
  *
@@ -858,20 +866,17 @@ static int tomoyo_update_path_acl(const u8 type, const char *filename,
  * @is_delete: True if it is a delete request.
  *
  * Returns 0 on success, negative value otherwise.
+ *
+ * Caller holds tomoyo_read_lock().
  */
-static inline int tomoyo_update_path_number3_acl(const u8 type,
-                                                const char *filename,
-                                                char *mode,
-                                                char *major, char *minor,
-                                                struct tomoyo_domain_info *
-                                                const domain,
-                                                const bool is_delete)
+static int tomoyo_update_path_number3_acl(const u8 type, const char *filename,
+                                         char *mode, char *major, char *minor,
+                                         struct tomoyo_domain_info * const
+                                         domain, const bool is_delete)
 {
-       const u8 perm = 1 << type;
-       struct tomoyo_acl_info *ptr;
        struct tomoyo_path_number3_acl e = {
                .head.type = TOMOYO_TYPE_PATH_NUMBER3_ACL,
-               .perm = perm
+               .perm = 1 << type
        };
        int error = is_delete ? -ENOENT : -ENOMEM;
        if (!tomoyo_parse_name_union(filename, &e.name) ||
@@ -879,30 +884,9 @@ static inline int tomoyo_update_path_number3_acl(const u8 type,
            !tomoyo_parse_number_union(major, &e.major) ||
            !tomoyo_parse_number_union(minor, &e.minor))
                goto out;
-       if (mutex_lock_interruptible(&tomoyo_policy_lock))
-               goto out;
-       list_for_each_entry_rcu(ptr, &domain->acl_info_list, list) {
-               struct tomoyo_path_number3_acl *acl =
-                       container_of(ptr, struct tomoyo_path_number3_acl, head);
-               if (!tomoyo_is_same_path_number3_acl(acl, &e))
-                       continue;
-               if (is_delete)
-                       acl->perm &= ~perm;
-               else
-                       acl->perm |= perm;
-               error = 0;
-               break;
-       }
-       if (!is_delete && error) {
-               struct tomoyo_path_number3_acl *entry =
-                       tomoyo_commit_ok(&e, sizeof(e));
-               if (entry) {
-                       list_add_tail_rcu(&entry->head.list,
-                                         &domain->acl_info_list);
-                       error = 0;
-               }
-       }
-       mutex_unlock(&tomoyo_policy_lock);
+       error = tomoyo_update_domain(&e.head, sizeof(e), is_delete, domain,
+                                    tomoyo_same_path_number3_acl,
+                                    tomoyo_merge_path_number3_acl);
  out:
        tomoyo_put_name_union(&e.name);
        tomoyo_put_number_union(&e.mode);
@@ -911,6 +895,32 @@ static inline int tomoyo_update_path_number3_acl(const u8 type,
        return error;
 }
 
+static bool tomoyo_same_path2_acl(const struct tomoyo_acl_info *a,
+                                 const struct tomoyo_acl_info *b)
+{
+       const struct tomoyo_path2_acl *p1 = container_of(a, typeof(*p1), head);
+       const struct tomoyo_path2_acl *p2 = container_of(b, typeof(*p2), head);
+       return tomoyo_is_same_acl_head(&p1->head, &p2->head)
+               && tomoyo_is_same_name_union(&p1->name1, &p2->name1)
+               && tomoyo_is_same_name_union(&p1->name2, &p2->name2);
+}
+
+static bool tomoyo_merge_path2_acl(struct tomoyo_acl_info *a,
+                                  struct tomoyo_acl_info *b,
+                                  const bool is_delete)
+{
+       u8 * const a_perm = &container_of(a, struct tomoyo_path2_acl, head)
+               ->perm;
+       u8 perm = *a_perm;
+       const u8 b_perm = container_of(b, struct tomoyo_path2_acl, head)->perm;
+       if (is_delete)
+               perm &= ~b_perm;
+       else
+               perm |= b_perm;
+       *a_perm = perm;
+       return !perm;
+}
+
 /**
  * tomoyo_update_path2_acl - Update "struct tomoyo_path2_acl" list.
  *
@@ -926,46 +936,20 @@ static inline int tomoyo_update_path_number3_acl(const u8 type,
  */
 static int tomoyo_update_path2_acl(const u8 type, const char *filename1,
                                   const char *filename2,
-                                  struct tomoyo_domain_info *const domain,
+                                  struct tomoyo_domain_info * const domain,
                                   const bool is_delete)
 {
-       const u8 perm = 1 << type;
        struct tomoyo_path2_acl e = {
                .head.type = TOMOYO_TYPE_PATH2_ACL,
-               .perm = perm
+               .perm = 1 << type
        };
-       struct tomoyo_acl_info *ptr;
        int error = is_delete ? -ENOENT : -ENOMEM;
-
-       if (!domain)
-               return -EINVAL;
        if (!tomoyo_parse_name_union(filename1, &e.name1) ||
            !tomoyo_parse_name_union(filename2, &e.name2))
                goto out;
-       if (mutex_lock_interruptible(&tomoyo_policy_lock))
-               goto out;
-       list_for_each_entry_rcu(ptr, &domain->acl_info_list, list) {
-               struct tomoyo_path2_acl *acl =
-                       container_of(ptr, struct tomoyo_path2_acl, head);
-               if (!tomoyo_is_same_path2_acl(acl, &e))
-                       continue;
-               if (is_delete)
-                       acl->perm &= ~perm;
-               else
-                       acl->perm |= perm;
-               error = 0;
-               break;
-       }
-       if (!is_delete && error) {
-               struct tomoyo_path2_acl *entry =
-                       tomoyo_commit_ok(&e, sizeof(e));
-               if (entry) {
-                       list_add_tail_rcu(&entry->head.list,
-                                         &domain->acl_info_list);
-                       error = 0;
-               }
-       }
-       mutex_unlock(&tomoyo_policy_lock);
+       error = tomoyo_update_domain(&e.head, sizeof(e), is_delete, domain,
+                                    tomoyo_same_path2_acl,
+                                    tomoyo_merge_path2_acl);
  out:
        tomoyo_put_name_union(&e.name1);
        tomoyo_put_name_union(&e.name2);
@@ -1072,8 +1056,12 @@ static int tomoyo_path_permission(struct tomoyo_request_info *r, u8 operation,
        int error;
 
  next:
+       r->type = tomoyo_p2mac[operation];
+       r->mode = tomoyo_get_mode(r->profile, r->type);
+       if (r->mode == TOMOYO_CONFIG_DISABLED)
+               return 0;
        do {
-               error = tomoyo_path_acl(r, filename, 1 << operation, 1);
+               error = tomoyo_path_acl(r, filename, 1 << operation);
                if (!error)
                        break;
                msg = tomoyo_path2keyword(operation);
@@ -1132,6 +1120,35 @@ static int tomoyo_path_number_acl(struct tomoyo_request_info *r, const u8 type,
        return error;
 }
 
+static bool tomoyo_same_path_number_acl(const struct tomoyo_acl_info *a,
+                                       const struct tomoyo_acl_info *b)
+{
+       const struct tomoyo_path_number_acl *p1 = container_of(a, typeof(*p1),
+                                                              head);
+       const struct tomoyo_path_number_acl *p2 = container_of(b, typeof(*p2),
+                                                              head);
+       return tomoyo_is_same_acl_head(&p1->head, &p2->head)
+               && tomoyo_is_same_name_union(&p1->name, &p2->name)
+               && tomoyo_is_same_number_union(&p1->number, &p2->number);
+}
+
+static bool tomoyo_merge_path_number_acl(struct tomoyo_acl_info *a,
+                                        struct tomoyo_acl_info *b,
+                                        const bool is_delete)
+{
+       u8 * const a_perm = &container_of(a, struct tomoyo_path_number_acl,
+                                         head)->perm;
+       u8 perm = *a_perm;
+       const u8 b_perm = container_of(b, struct tomoyo_path_number_acl, head)
+               ->perm;
+       if (is_delete)
+               perm &= ~b_perm;
+       else
+               perm |= b_perm;
+       *a_perm = perm;
+       return !perm;
+}
+
 /**
  * tomoyo_update_path_number_acl - Update ioctl/chmod/chown/chgrp ACL.
  *
@@ -1143,50 +1160,24 @@ static int tomoyo_path_number_acl(struct tomoyo_request_info *r, const u8 type,
  *
  * Returns 0 on success, negative value otherwise.
  */
-static inline int tomoyo_update_path_number_acl(const u8 type,
-                                               const char *filename,
-                                               char *number,
-                                               struct tomoyo_domain_info *
-                                               const domain,
-                                               const bool is_delete)
+static int tomoyo_update_path_number_acl(const u8 type, const char *filename,
+                                        char *number,
+                                        struct tomoyo_domain_info * const
+                                        domain,
+                                        const bool is_delete)
 {
-       const u8 perm = 1 << type;
-       struct tomoyo_acl_info *ptr;
        struct tomoyo_path_number_acl e = {
                .head.type = TOMOYO_TYPE_PATH_NUMBER_ACL,
-               .perm = perm
+               .perm = 1 << type
        };
        int error = is_delete ? -ENOENT : -ENOMEM;
-       if (!domain)
-               return -EINVAL;
        if (!tomoyo_parse_name_union(filename, &e.name))
                return -EINVAL;
        if (!tomoyo_parse_number_union(number, &e.number))
                goto out;
-       if (mutex_lock_interruptible(&tomoyo_policy_lock))
-               goto out;
-       list_for_each_entry_rcu(ptr, &domain->acl_info_list, list) {
-               struct tomoyo_path_number_acl *acl =
-                       container_of(ptr, struct tomoyo_path_number_acl, head);
-               if (!tomoyo_is_same_path_number_acl(acl, &e))
-                       continue;
-               if (is_delete)
-                       acl->perm &= ~perm;
-               else
-                       acl->perm |= perm;
-               error = 0;
-               break;
-       }
-       if (!is_delete && error) {
-               struct tomoyo_path_number_acl *entry =
-                       tomoyo_commit_ok(&e, sizeof(e));
-               if (entry) {
-                       list_add_tail_rcu(&entry->head.list,
-                                         &domain->acl_info_list);
-                       error = 0;
-               }
-       }
-       mutex_unlock(&tomoyo_policy_lock);
+       error = tomoyo_update_domain(&e.head, sizeof(e), is_delete, domain,
+                                    tomoyo_same_path_number_acl,
+                                    tomoyo_merge_path_number_acl);
  out:
        tomoyo_put_name_union(&e.name);
        tomoyo_put_number_union(&e.number);
@@ -1264,8 +1255,8 @@ int tomoyo_path_number_perm(const u8 type, struct path *path,
        struct tomoyo_path_info buf;
        int idx;
 
-       if (tomoyo_init_request_info(&r, NULL) == TOMOYO_CONFIG_DISABLED ||
-           !path->mnt || !path->dentry)
+       if (tomoyo_init_request_info(&r, NULL, tomoyo_pn2mac[type])
+           == TOMOYO_CONFIG_DISABLED || !path->mnt || !path->dentry)
                return 0;
        idx = tomoyo_read_lock();
        if (!tomoyo_get_realpath(&buf, path))
@@ -1284,21 +1275,19 @@ int tomoyo_path_number_perm(const u8 type, struct path *path,
 /**
  * tomoyo_check_exec_perm - Check permission for "execute".
  *
- * @domain:   Pointer to "struct tomoyo_domain_info".
+ * @r:        Pointer to "struct tomoyo_request_info".
  * @filename: Check permission for "execute".
  *
  * Returns 0 on success, negativevalue otherwise.
  *
  * Caller holds tomoyo_read_lock().
  */
-int tomoyo_check_exec_perm(struct tomoyo_domain_info *domain,
+int tomoyo_check_exec_perm(struct tomoyo_request_info *r,
                           const struct tomoyo_path_info *filename)
 {
-       struct tomoyo_request_info r;
-
-       if (tomoyo_init_request_info(&r, NULL) == TOMOYO_CONFIG_DISABLED)
+       if (r->mode == TOMOYO_CONFIG_DISABLED)
                return 0;
-       return tomoyo_file_perm(&r, filename, 1);
+       return tomoyo_file_perm(r, filename, 1);
 }
 
 /**
@@ -1319,17 +1308,11 @@ int tomoyo_check_open_permission(struct tomoyo_domain_info *domain,
        struct tomoyo_request_info r;
        int idx;
 
-       if (tomoyo_init_request_info(&r, domain) == TOMOYO_CONFIG_DISABLED ||
-           !path->mnt)
-               return 0;
-       if (acc_mode == 0)
-               return 0;
-       if (path->dentry->d_inode && S_ISDIR(path->dentry->d_inode->i_mode))
-               /*
-                * I don't check directories here because mkdir() and rmdir()
-                * don't call me.
-                */
+       if (!path->mnt ||
+           (path->dentry->d_inode && S_ISDIR(path->dentry->d_inode->i_mode)))
                return 0;
+       buf.name = NULL;
+       r.mode = TOMOYO_CONFIG_DISABLED;
        idx = tomoyo_read_lock();
        if (!tomoyo_get_realpath(&buf, path))
                goto out;
@@ -1339,15 +1322,26 @@ int tomoyo_check_open_permission(struct tomoyo_domain_info *domain,
         * we need to check "allow_rewrite" permission when the filename is not
         * opened for append mode or the filename is truncated at open time.
         */
-       if ((acc_mode & MAY_WRITE) &&
-           ((flag & O_TRUNC) || !(flag & O_APPEND)) &&
-           (tomoyo_is_no_rewrite_file(&buf))) {
-               error = tomoyo_path_permission(&r, TOMOYO_TYPE_REWRITE, &buf);
+       if ((acc_mode & MAY_WRITE) && !(flag & O_APPEND)
+           && tomoyo_init_request_info(&r, domain, TOMOYO_MAC_FILE_REWRITE)
+           != TOMOYO_CONFIG_DISABLED) {
+               if (!tomoyo_get_realpath(&buf, path)) {
+                       error = -ENOMEM;
+                       goto out;
+               }
+               if (tomoyo_is_no_rewrite_file(&buf))
+                       error = tomoyo_path_permission(&r, TOMOYO_TYPE_REWRITE,
+                                                      &buf);
        }
-       if (!error)
+       if (!error && acc_mode &&
+           tomoyo_init_request_info(&r, domain, TOMOYO_MAC_FILE_OPEN)
+           != TOMOYO_CONFIG_DISABLED) {
+               if (!buf.name && !tomoyo_get_realpath(&buf, path)) {
+                       error = -ENOMEM;
+                       goto out;
+               }
                error = tomoyo_file_perm(&r, &buf, acc_mode);
-       if (!error && (flag & O_TRUNC))
-               error = tomoyo_path_permission(&r, TOMOYO_TYPE_TRUNCATE, &buf);
+       }
  out:
        kfree(buf.name);
        tomoyo_read_unlock(idx);
@@ -1371,9 +1365,12 @@ int tomoyo_path_perm(const u8 operation, struct path *path)
        struct tomoyo_request_info r;
        int idx;
 
-       if (tomoyo_init_request_info(&r, NULL) == TOMOYO_CONFIG_DISABLED ||
-           !path->mnt)
+       if (!path->mnt)
+               return 0;
+       if (tomoyo_init_request_info(&r, NULL, tomoyo_p2mac[operation])
+           == TOMOYO_CONFIG_DISABLED)
                return 0;
+       buf.name = NULL;
        idx = tomoyo_read_lock();
        if (!tomoyo_get_realpath(&buf, path))
                goto out;
@@ -1386,6 +1383,7 @@ int tomoyo_path_perm(const u8 operation, struct path *path)
                break;
        case TOMOYO_TYPE_RMDIR:
        case TOMOYO_TYPE_CHROOT:
+       case TOMOYO_TYPE_UMOUNT:
                tomoyo_add_slash(&buf);
                break;
        }
@@ -1457,8 +1455,9 @@ int tomoyo_path_number3_perm(const u8 operation, struct path *path,
        struct tomoyo_path_info buf;
        int idx;
 
-       if (tomoyo_init_request_info(&r, NULL) == TOMOYO_CONFIG_DISABLED ||
-           !path->mnt)
+       if (!path->mnt ||
+           tomoyo_init_request_info(&r, NULL, tomoyo_pnnn2mac[operation])
+           == TOMOYO_CONFIG_DISABLED)
                return 0;
        idx = tomoyo_read_lock();
        error = -ENOMEM;
@@ -1492,8 +1491,9 @@ int tomoyo_path2_perm(const u8 operation, struct path *path1,
        struct tomoyo_request_info r;
        int idx;
 
-       if (tomoyo_init_request_info(&r, NULL) == TOMOYO_CONFIG_DISABLED ||
-           !path1->mnt || !path2->mnt)
+       if (!path1->mnt || !path2->mnt ||
+           tomoyo_init_request_info(&r, NULL, tomoyo_pp2mac[operation])
+           == TOMOYO_CONFIG_DISABLED)
                return 0;
        buf1.name = NULL;
        buf2.name = NULL;
@@ -1501,13 +1501,19 @@ int tomoyo_path2_perm(const u8 operation, struct path *path1,
        if (!tomoyo_get_realpath(&buf1, path1) ||
            !tomoyo_get_realpath(&buf2, path2))
                goto out;
-       {
-               struct dentry *dentry = path1->dentry;
-               if (dentry->d_inode && S_ISDIR(dentry->d_inode->i_mode)) {
-                       tomoyo_add_slash(&buf1);
-                       tomoyo_add_slash(&buf2);
-               }
-       }
+       switch (operation) {
+               struct dentry *dentry;
+       case TOMOYO_TYPE_RENAME:
+        case TOMOYO_TYPE_LINK:
+               dentry = path1->dentry;
+               if (!dentry->d_inode || !S_ISDIR(dentry->d_inode->i_mode))
+                        break;
+                /* fall through */
+        case TOMOYO_TYPE_PIVOT_ROOT:
+                tomoyo_add_slash(&buf1);
+                tomoyo_add_slash(&buf2);
+               break;
+        }
        do {
                error = tomoyo_path2_acl(&r, operation, &buf1, &buf2);
                if (!error)
@@ -1545,13 +1551,8 @@ int tomoyo_write_file_policy(char *data, struct tomoyo_domain_info *domain,
        u8 type;
        if (!tomoyo_tokenize(data, w, sizeof(w)) || !w[1][0])
                return -EINVAL;
-       if (strncmp(w[0], "allow_", 6)) {
-               unsigned int perm;
-               if (sscanf(w[0], "%u", &perm) == 1)
-                       return tomoyo_update_file_acl((u8) perm, w[1], domain,
-                                                     is_delete);
+       if (strncmp(w[0], "allow_", 6))
                goto out;
-       }
        w[0] += 6;
        for (type = 0; type < TOMOYO_MAX_PATH_OPERATION; type++) {
                if (strcmp(w[0], tomoyo_path_keyword[type]))