]> bbs.cooldavid.org Git - net-next-2.6.git/blobdiff - net/xfrm/xfrm_user.c
[XFRM] netlink: Use nlmsg_new() and type-safe size calculation helpers
[net-next-2.6.git] / net / xfrm / xfrm_user.c
index c9bb7210eb69bcaefbb41c44717d83cdfaf515d3..783332987491ae730fc766c7a245ac5df6b8025f 100644 (file)
 #endif
 #include <linux/audit.h>
 
+static inline int alg_len(struct xfrm_algo *alg)
+{
+       return sizeof(*alg) + ((alg->alg_key_len + 7) / 8);
+}
+
 static int verify_one_alg(struct rtattr **xfrma, enum xfrm_attr_type_t type)
 {
        struct rtattr *rt = xfrma[type - 1];
@@ -232,7 +237,6 @@ static int attach_one_algo(struct xfrm_algo **algpp, u8 *props,
        struct rtattr *rta = u_arg;
        struct xfrm_algo *p, *ualg;
        struct xfrm_algo_desc *algo;
-       int len;
 
        if (!rta)
                return 0;
@@ -244,8 +248,7 @@ static int attach_one_algo(struct xfrm_algo **algpp, u8 *props,
                return -ENOSYS;
        *props = algo->desc.sadb_alg_id;
 
-       len = sizeof(*ualg) + (ualg->alg_key_len + 7U) / 8;
-       p = kmemdup(ualg, len, GFP_KERNEL);
+       p = kmemdup(ualg, alg_len(ualg), GFP_KERNEL);
        if (!p)
                return -ENOMEM;
 
@@ -576,6 +579,27 @@ struct xfrm_dump_info {
        int this_idx;
 };
 
+static int copy_sec_ctx(struct xfrm_sec_ctx *s, struct sk_buff *skb)
+{
+       int ctx_size = sizeof(struct xfrm_sec_ctx) + s->ctx_len;
+       struct xfrm_user_sec_ctx *uctx;
+       struct nlattr *attr;
+
+       attr = nla_reserve(skb, XFRMA_SEC_CTX, ctx_size);
+       if (attr == NULL)
+               return -EMSGSIZE;
+
+       uctx = nla_data(attr);
+       uctx->exttype = XFRMA_SEC_CTX;
+       uctx->len = ctx_size;
+       uctx->ctx_doi = s->ctx_doi;
+       uctx->ctx_alg = s->ctx_alg;
+       uctx->ctx_len = s->ctx_len;
+       memcpy(uctx + 1, s->ctx_str, s->ctx_len);
+
+       return 0;
+}
+
 static int dump_one_state(struct xfrm_state *x, int count, void *ptr)
 {
        struct xfrm_dump_info *sp = ptr;
@@ -596,43 +620,30 @@ static int dump_one_state(struct xfrm_state *x, int count, void *ptr)
        copy_to_user_state(x, p);
 
        if (x->aalg)
-               RTA_PUT(skb, XFRMA_ALG_AUTH,
-                       sizeof(*(x->aalg))+(x->aalg->alg_key_len+7)/8, x->aalg);
+               NLA_PUT(skb, XFRMA_ALG_AUTH, alg_len(x->aalg), x->aalg);
        if (x->ealg)
-               RTA_PUT(skb, XFRMA_ALG_CRYPT,
-                       sizeof(*(x->ealg))+(x->ealg->alg_key_len+7)/8, x->ealg);
+               NLA_PUT(skb, XFRMA_ALG_CRYPT, alg_len(x->ealg), x->ealg);
        if (x->calg)
-               RTA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
+               NLA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
 
        if (x->encap)
-               RTA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
+               NLA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
 
-       if (x->security) {
-               int ctx_size = sizeof(struct xfrm_sec_ctx) +
-                               x->security->ctx_len;
-               struct rtattr *rt = __RTA_PUT(skb, XFRMA_SEC_CTX, ctx_size);
-               struct xfrm_user_sec_ctx *uctx = RTA_DATA(rt);
-
-               uctx->exttype = XFRMA_SEC_CTX;
-               uctx->len = ctx_size;
-               uctx->ctx_doi = x->security->ctx_doi;
-               uctx->ctx_alg = x->security->ctx_alg;
-               uctx->ctx_len = x->security->ctx_len;
-               memcpy(uctx + 1, x->security->ctx_str, x->security->ctx_len);
-       }
+       if (x->security && copy_sec_ctx(x->security, skb) < 0)
+               goto nla_put_failure;
 
        if (x->coaddr)
-               RTA_PUT(skb, XFRMA_COADDR, sizeof(*x->coaddr), x->coaddr);
+               NLA_PUT(skb, XFRMA_COADDR, sizeof(*x->coaddr), x->coaddr);
 
        if (x->lastused)
-               RTA_PUT(skb, XFRMA_LASTUSED, sizeof(x->lastused), &x->lastused);
+               NLA_PUT_U64(skb, XFRMA_LASTUSED, x->lastused);
 
        nlmsg_end(skb, nlh);
 out:
        sp->this_idx++;
        return 0;
 
-rtattr_failure:
+nla_put_failure:
        nlmsg_cancel(skb, nlh);
        return -EMSGSIZE;
 }
@@ -659,7 +670,7 @@ static struct sk_buff *xfrm_state_netlink(struct sk_buff *in_skb,
        struct xfrm_dump_info info;
        struct sk_buff *skb;
 
-       skb = alloc_skb(NLMSG_GOODSIZE, GFP_ATOMIC);
+       skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_ATOMIC);
        if (!skb)
                return ERR_PTR(-ENOMEM);
 
@@ -677,6 +688,13 @@ static struct sk_buff *xfrm_state_netlink(struct sk_buff *in_skb,
        return skb;
 }
 
+static inline size_t xfrm_spdinfo_msgsize(void)
+{
+       return NLMSG_ALIGN(4)
+              + nla_total_size(sizeof(struct xfrmu_spdinfo))
+              + nla_total_size(sizeof(struct xfrmu_spdhinfo));
+}
+
 static int build_spdinfo(struct sk_buff *skb, u32 pid, u32 seq, u32 flags)
 {
        struct xfrmk_spdinfo si;
@@ -718,12 +736,8 @@ static int xfrm_get_spdinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
        u32 *flags = nlmsg_data(nlh);
        u32 spid = NETLINK_CB(skb).pid;
        u32 seq = nlh->nlmsg_seq;
-       int len = NLMSG_LENGTH(sizeof(u32));
 
-       len += RTA_SPACE(sizeof(struct xfrmu_spdinfo));
-       len += RTA_SPACE(sizeof(struct xfrmu_spdhinfo));
-
-       r_skb = alloc_skb(len, GFP_ATOMIC);
+       r_skb = nlmsg_new(xfrm_spdinfo_msgsize(), GFP_ATOMIC);
        if (r_skb == NULL)
                return -ENOMEM;
 
@@ -733,6 +747,13 @@ static int xfrm_get_spdinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
        return nlmsg_unicast(xfrm_nl, r_skb, spid);
 }
 
+static inline size_t xfrm_sadinfo_msgsize(void)
+{
+       return NLMSG_ALIGN(4)
+              + nla_total_size(sizeof(struct xfrmu_sadhinfo))
+              + nla_total_size(4); /* XFRMA_SAD_CNT */
+}
+
 static int build_sadinfo(struct sk_buff *skb, u32 pid, u32 seq, u32 flags)
 {
        struct xfrmk_sadinfo si;
@@ -768,13 +789,8 @@ static int xfrm_get_sadinfo(struct sk_buff *skb, struct nlmsghdr *nlh,
        u32 *flags = nlmsg_data(nlh);
        u32 spid = NETLINK_CB(skb).pid;
        u32 seq = nlh->nlmsg_seq;
-       int len = NLMSG_LENGTH(sizeof(u32));
-
-       len += RTA_SPACE(sizeof(struct xfrmu_sadhinfo));
-       len += RTA_SPACE(sizeof(u32));
-
-       r_skb = alloc_skb(len, GFP_ATOMIC);
 
+       r_skb = nlmsg_new(xfrm_sadinfo_msgsize(), GFP_ATOMIC);
        if (r_skb == NULL)
                return -ENOMEM;
 
@@ -800,8 +816,7 @@ static int xfrm_get_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
        if (IS_ERR(resp_skb)) {
                err = PTR_ERR(resp_skb);
        } else {
-               err = netlink_unicast(xfrm_nl, resp_skb,
-                                     NETLINK_CB(skb).pid, MSG_DONTWAIT);
+               err = nlmsg_unicast(xfrm_nl, resp_skb, NETLINK_CB(skb).pid);
        }
        xfrm_state_put(x);
 out_noput:
@@ -882,8 +897,7 @@ static int xfrm_alloc_userspi(struct sk_buff *skb, struct nlmsghdr *nlh,
                goto out;
        }
 
-       err = netlink_unicast(xfrm_nl, resp_skb,
-                             NETLINK_CB(skb).pid, MSG_DONTWAIT);
+       err = nlmsg_unicast(xfrm_nl, resp_skb, NETLINK_CB(skb).pid);
 
 out:
        xfrm_state_put(x);
@@ -1195,32 +1209,9 @@ static int copy_to_user_tmpl(struct xfrm_policy *xp, struct sk_buff *skb)
                up->ealgos = kp->ealgos;
                up->calgos = kp->calgos;
        }
-       RTA_PUT(skb, XFRMA_TMPL,
-               (sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr),
-               vec);
-
-       return 0;
 
-rtattr_failure:
-       return -1;
-}
-
-static int copy_sec_ctx(struct xfrm_sec_ctx *s, struct sk_buff *skb)
-{
-       int ctx_size = sizeof(struct xfrm_sec_ctx) + s->ctx_len;
-       struct rtattr *rt = __RTA_PUT(skb, XFRMA_SEC_CTX, ctx_size);
-       struct xfrm_user_sec_ctx *uctx = RTA_DATA(rt);
-
-       uctx->exttype = XFRMA_SEC_CTX;
-       uctx->len = ctx_size;
-       uctx->ctx_doi = s->ctx_doi;
-       uctx->ctx_alg = s->ctx_alg;
-       uctx->ctx_len = s->ctx_len;
-       memcpy(uctx + 1, s->ctx_str, s->ctx_len);
-       return 0;
-
- rtattr_failure:
-       return -1;
+       return nla_put(skb, XFRMA_TMPL,
+                      sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr, vec);
 }
 
 static inline int copy_to_user_state_sec_ctx(struct xfrm_state *x, struct sk_buff *skb)
@@ -1238,21 +1229,23 @@ static inline int copy_to_user_sec_ctx(struct xfrm_policy *xp, struct sk_buff *s
        }
        return 0;
 }
+static inline size_t userpolicy_type_attrsize(void)
+{
+#ifdef CONFIG_XFRM_SUB_POLICY
+       return nla_total_size(sizeof(struct xfrm_userpolicy_type));
+#else
+       return 0;
+#endif
+}
 
 #ifdef CONFIG_XFRM_SUB_POLICY
 static int copy_to_user_policy_type(u8 type, struct sk_buff *skb)
 {
-       struct xfrm_userpolicy_type upt;
-
-       memset(&upt, 0, sizeof(upt));
-       upt.type = type;
-
-       RTA_PUT(skb, XFRMA_POLICY_TYPE, sizeof(upt), &upt);
-
-       return 0;
+       struct xfrm_userpolicy_type upt = {
+               .type = type,
+       };
 
-rtattr_failure:
-       return -1;
+       return nla_put(skb, XFRMA_POLICY_TYPE, sizeof(upt), &upt);
 }
 
 #else
@@ -1323,7 +1316,7 @@ static struct sk_buff *xfrm_policy_netlink(struct sk_buff *in_skb,
        struct xfrm_dump_info info;
        struct sk_buff *skb;
 
-       skb = alloc_skb(NLMSG_GOODSIZE, GFP_KERNEL);
+       skb = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);
        if (!skb)
                return ERR_PTR(-ENOMEM);
 
@@ -1393,9 +1386,8 @@ static int xfrm_get_policy(struct sk_buff *skb, struct nlmsghdr *nlh,
                if (IS_ERR(resp_skb)) {
                        err = PTR_ERR(resp_skb);
                } else {
-                       err = netlink_unicast(xfrm_nl, resp_skb,
-                                             NETLINK_CB(skb).pid,
-                                             MSG_DONTWAIT);
+                       err = nlmsg_unicast(xfrm_nl, resp_skb,
+                                           NETLINK_CB(skb).pid);
                }
        } else {
                xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
@@ -1438,12 +1430,19 @@ static int xfrm_flush_sa(struct sk_buff *skb, struct nlmsghdr *nlh,
        return 0;
 }
 
+static inline size_t xfrm_aevent_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_aevent_id))
+              + nla_total_size(sizeof(struct xfrm_replay_state))
+              + nla_total_size(sizeof(struct xfrm_lifetime_cur))
+              + nla_total_size(4) /* XFRM_AE_RTHR */
+              + nla_total_size(4); /* XFRM_AE_ETHR */
+}
 
 static int build_aevent(struct sk_buff *skb, struct xfrm_state *x, struct km_event *c)
 {
        struct xfrm_aevent_id *id;
        struct nlmsghdr *nlh;
-       struct xfrm_lifetime_cur ltime;
 
        nlh = nlmsg_put(skb, c->pid, c->seq, XFRM_MSG_NEWAE, sizeof(*id), 0);
        if (nlh == NULL)
@@ -1458,27 +1457,19 @@ static int build_aevent(struct sk_buff *skb, struct xfrm_state *x, struct km_eve
        id->reqid = x->props.reqid;
        id->flags = c->data.aevent;
 
-       RTA_PUT(skb, XFRMA_REPLAY_VAL, sizeof(x->replay), &x->replay);
-
-       ltime.bytes = x->curlft.bytes;
-       ltime.packets = x->curlft.packets;
-       ltime.add_time = x->curlft.add_time;
-       ltime.use_time = x->curlft.use_time;
+       NLA_PUT(skb, XFRMA_REPLAY_VAL, sizeof(x->replay), &x->replay);
+       NLA_PUT(skb, XFRMA_LTIME_VAL, sizeof(x->curlft), &x->curlft);
 
-       RTA_PUT(skb, XFRMA_LTIME_VAL, sizeof(struct xfrm_lifetime_cur), &ltime);
+       if (id->flags & XFRM_AE_RTHR)
+               NLA_PUT_U32(skb, XFRMA_REPLAY_THRESH, x->replay_maxdiff);
 
-       if (id->flags&XFRM_AE_RTHR) {
-               RTA_PUT(skb,XFRMA_REPLAY_THRESH,sizeof(u32),&x->replay_maxdiff);
-       }
-
-       if (id->flags&XFRM_AE_ETHR) {
-               u32 etimer = x->replay_maxage*10/HZ;
-               RTA_PUT(skb,XFRMA_ETIMER_THRESH,sizeof(u32),&etimer);
-       }
+       if (id->flags & XFRM_AE_ETHR)
+               NLA_PUT_U32(skb, XFRMA_ETIMER_THRESH,
+                           x->replay_maxage * 10 / HZ);
 
        return nlmsg_end(skb, nlh);
 
-rtattr_failure:
+nla_put_failure:
        nlmsg_cancel(skb, nlh);
        return -EMSGSIZE;
 }
@@ -1491,19 +1482,9 @@ static int xfrm_get_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
        int err;
        struct km_event c;
        struct xfrm_aevent_id *p = nlmsg_data(nlh);
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_aevent_id));
        struct xfrm_usersa_id *id = &p->sa_id;
 
-       len += RTA_SPACE(sizeof(struct xfrm_replay_state));
-       len += RTA_SPACE(sizeof(struct xfrm_lifetime_cur));
-
-       if (p->flags&XFRM_AE_RTHR)
-               len+=RTA_SPACE(sizeof(u32));
-
-       if (p->flags&XFRM_AE_ETHR)
-               len+=RTA_SPACE(sizeof(u32));
-
-       r_skb = alloc_skb(len, GFP_ATOMIC);
+       r_skb = nlmsg_new(xfrm_aevent_msgsize(), GFP_ATOMIC);
        if (r_skb == NULL)
                return -ENOMEM;
 
@@ -1525,8 +1506,7 @@ static int xfrm_get_ae(struct sk_buff *skb, struct nlmsghdr *nlh,
 
        if (build_aevent(r_skb, x, &c) < 0)
                BUG();
-       err = netlink_unicast(xfrm_nl, r_skb,
-                             NETLINK_CB(skb).pid, MSG_DONTWAIT);
+       err = nlmsg_unicast(xfrm_nl, r_skb, NETLINK_CB(skb).pid);
        spin_unlock_bh(&x->lock);
        xfrm_state_put(x);
        return err;
@@ -1844,11 +1824,14 @@ static int copy_to_user_migrate(struct xfrm_migrate *m, struct sk_buff *skb)
        memcpy(&um.new_daddr, &m->new_daddr, sizeof(um.new_daddr));
        memcpy(&um.new_saddr, &m->new_saddr, sizeof(um.new_saddr));
 
-       RTA_PUT(skb, XFRMA_MIGRATE, sizeof(um), &um);
-       return 0;
+       return nla_put(skb, XFRMA_MIGRATE, sizeof(um), &um);
+}
 
-rtattr_failure:
-       return -1;
+static inline size_t xfrm_migrate_msgsize(int num_migrate)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_userpolicy_id))
+              + nla_total_size(sizeof(struct xfrm_user_migrate) * num_migrate)
+              + userpolicy_type_attrsize();
 }
 
 static int build_migrate(struct sk_buff *skb, struct xfrm_migrate *m,
@@ -1888,14 +1871,8 @@ static int xfrm_send_migrate(struct xfrm_selector *sel, u8 dir, u8 type,
                             struct xfrm_migrate *m, int num_migrate)
 {
        struct sk_buff *skb;
-       size_t len;
 
-       len = RTA_SPACE(sizeof(struct xfrm_user_migrate) * num_migrate);
-       len += NLMSG_SPACE(sizeof(struct xfrm_userpolicy_id));
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_migrate_msgsize(num_migrate), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
@@ -1903,9 +1880,7 @@ static int xfrm_send_migrate(struct xfrm_selector *sel, u8 dir, u8 type,
        if (build_migrate(skb, m, num_migrate, sel, dir, type) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_MIGRATE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_MIGRATE,
-                                GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_MIGRATE, GFP_ATOMIC);
 }
 #else
 static int xfrm_send_migrate(struct xfrm_selector *sel, u8 dir, u8 type,
@@ -2033,6 +2008,11 @@ static void xfrm_netlink_rcv(struct sock *sk, int len)
        } while (qlen);
 }
 
+static inline size_t xfrm_expire_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_expire));
+}
+
 static int build_expire(struct sk_buff *skb, struct xfrm_state *x, struct km_event *c)
 {
        struct xfrm_user_expire *ue;
@@ -2052,35 +2032,29 @@ static int build_expire(struct sk_buff *skb, struct xfrm_state *x, struct km_eve
 static int xfrm_exp_state_notify(struct xfrm_state *x, struct km_event *c)
 {
        struct sk_buff *skb;
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_user_expire));
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_expire_msgsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_expire(skb, x, c) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_EXPIRE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
 }
 
 static int xfrm_aevent_state_notify(struct xfrm_state *x, struct km_event *c)
 {
        struct sk_buff *skb;
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_aevent_id));
 
-       len += RTA_SPACE(sizeof(struct xfrm_replay_state));
-       len += RTA_SPACE(sizeof(struct xfrm_lifetime_cur));
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_aevent_msgsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_aevent(skb, x, c) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_AEVENTS;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_AEVENTS, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_AEVENTS, GFP_ATOMIC);
 }
 
 static int xfrm_notify_sa_flush(struct km_event *c)
@@ -2088,9 +2062,9 @@ static int xfrm_notify_sa_flush(struct km_event *c)
        struct xfrm_usersa_flush *p;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       int len = NLMSG_LENGTH(sizeof(struct xfrm_usersa_flush));
+       int len = NLMSG_ALIGN(sizeof(struct xfrm_usersa_flush));
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(len, GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
@@ -2105,21 +2079,20 @@ static int xfrm_notify_sa_flush(struct km_event *c)
 
        nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_SA;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
 }
 
-static inline int xfrm_sa_len(struct xfrm_state *x)
+static inline size_t xfrm_sa_len(struct xfrm_state *x)
 {
-       int l = 0;
+       size_t l = 0;
        if (x->aalg)
-               l += RTA_SPACE(sizeof(*x->aalg) + (x->aalg->alg_key_len+7)/8);
+               l += nla_total_size(alg_len(x->aalg));
        if (x->ealg)
-               l += RTA_SPACE(sizeof(*x->ealg) + (x->ealg->alg_key_len+7)/8);
+               l += nla_total_size(alg_len(x->ealg));
        if (x->calg)
-               l += RTA_SPACE(sizeof(*x->calg));
+               l += nla_total_size(sizeof(*x->calg));
        if (x->encap)
-               l += RTA_SPACE(sizeof(*x->encap));
+               l += nla_total_size(sizeof(*x->encap));
 
        return l;
 }
@@ -2135,51 +2108,53 @@ static int xfrm_notify_sa(struct xfrm_state *x, struct km_event *c)
 
        headlen = sizeof(*p);
        if (c->event == XFRM_MSG_DELSA) {
-               len += RTA_SPACE(headlen);
+               len += nla_total_size(headlen);
                headlen = sizeof(*id);
        }
-       len += NLMSG_SPACE(headlen);
+       len += NLMSG_ALIGN(headlen);
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(len, GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        nlh = nlmsg_put(skb, c->pid, c->seq, c->event, headlen, 0);
        if (nlh == NULL)
-               goto nlmsg_failure;
+               goto nla_put_failure;
 
        p = nlmsg_data(nlh);
        if (c->event == XFRM_MSG_DELSA) {
+               struct nlattr *attr;
+
                id = nlmsg_data(nlh);
                memcpy(&id->daddr, &x->id.daddr, sizeof(id->daddr));
                id->spi = x->id.spi;
                id->family = x->props.family;
                id->proto = x->id.proto;
 
-               p = RTA_DATA(__RTA_PUT(skb, XFRMA_SA, sizeof(*p)));
+               attr = nla_reserve(skb, XFRMA_SA, sizeof(*p));
+               if (attr == NULL)
+                       goto nla_put_failure;
+
+               p = nla_data(attr);
        }
 
        copy_to_user_state(x, p);
 
        if (x->aalg)
-               RTA_PUT(skb, XFRMA_ALG_AUTH,
-                       sizeof(*(x->aalg))+(x->aalg->alg_key_len+7)/8, x->aalg);
+               NLA_PUT(skb, XFRMA_ALG_AUTH, alg_len(x->aalg), x->aalg);
        if (x->ealg)
-               RTA_PUT(skb, XFRMA_ALG_CRYPT,
-                       sizeof(*(x->ealg))+(x->ealg->alg_key_len+7)/8, x->ealg);
+               NLA_PUT(skb, XFRMA_ALG_CRYPT, alg_len(x->ealg), x->ealg);
        if (x->calg)
-               RTA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
+               NLA_PUT(skb, XFRMA_ALG_COMP, sizeof(*(x->calg)), x->calg);
 
        if (x->encap)
-               RTA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
+               NLA_PUT(skb, XFRMA_ENCAP, sizeof(*x->encap), x->encap);
 
        nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_SA;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_SA, GFP_ATOMIC);
 
-nlmsg_failure:
-rtattr_failure:
+nla_put_failure:
        kfree_skb(skb);
        return -1;
 }
@@ -2207,6 +2182,15 @@ static int xfrm_send_state_notify(struct xfrm_state *x, struct km_event *c)
 
 }
 
+static inline size_t xfrm_acquire_msgsize(struct xfrm_state *x,
+                                         struct xfrm_policy *xp)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_acquire))
+              + nla_total_size(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr)
+              + nla_total_size(xfrm_user_sec_ctx_size(x->security))
+              + userpolicy_type_attrsize();
+}
+
 static int build_acquire(struct sk_buff *skb, struct xfrm_state *x,
                         struct xfrm_tmpl *xt, struct xfrm_policy *xp,
                         int dir)
@@ -2247,23 +2231,15 @@ static int xfrm_send_acquire(struct xfrm_state *x, struct xfrm_tmpl *xt,
                             struct xfrm_policy *xp, int dir)
 {
        struct sk_buff *skb;
-       size_t len;
 
-       len = RTA_SPACE(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
-       len += NLMSG_SPACE(sizeof(struct xfrm_user_acquire));
-       len += RTA_SPACE(xfrm_user_sec_ctx_size(x->security));
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_acquire_msgsize(x, xp), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_acquire(skb, x, xt, xp, dir) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_ACQUIRE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_ACQUIRE, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_ACQUIRE, GFP_ATOMIC);
 }
 
 /* User gives us xfrm_user_policy_info followed by an array of 0
@@ -2325,6 +2301,14 @@ static struct xfrm_policy *xfrm_compile_policy(struct sock *sk, int opt,
        return xp;
 }
 
+static inline size_t xfrm_polexpire_msgsize(struct xfrm_policy *xp)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_polexpire))
+              + nla_total_size(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr)
+              + nla_total_size(xfrm_user_sec_ctx_size(xp->security))
+              + userpolicy_type_attrsize();
+}
+
 static int build_polexpire(struct sk_buff *skb, struct xfrm_policy *xp,
                           int dir, struct km_event *c)
 {
@@ -2356,23 +2340,15 @@ nlmsg_failure:
 static int xfrm_exp_policy_notify(struct xfrm_policy *xp, int dir, struct km_event *c)
 {
        struct sk_buff *skb;
-       size_t len;
 
-       len = RTA_SPACE(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
-       len += NLMSG_SPACE(sizeof(struct xfrm_user_polexpire));
-       len += RTA_SPACE(xfrm_user_sec_ctx_size(xp->security));
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_polexpire_msgsize(xp), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_polexpire(skb, xp, dir, c) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_EXPIRE;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_EXPIRE, GFP_ATOMIC);
 }
 
 static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *c)
@@ -2381,20 +2357,18 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *
        struct xfrm_userpolicy_id *id;
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       int len = RTA_SPACE(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
+       int len = nla_total_size(sizeof(struct xfrm_user_tmpl) * xp->xfrm_nr);
        int headlen;
 
        headlen = sizeof(*p);
        if (c->event == XFRM_MSG_DELPOLICY) {
-               len += RTA_SPACE(headlen);
+               len += nla_total_size(headlen);
                headlen = sizeof(*id);
        }
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       len += NLMSG_SPACE(headlen);
+       len += userpolicy_type_attrsize();
+       len += NLMSG_ALIGN(headlen);
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(len, GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
@@ -2404,6 +2378,8 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *
 
        p = nlmsg_data(nlh);
        if (c->event == XFRM_MSG_DELPOLICY) {
+               struct nlattr *attr;
+
                id = nlmsg_data(nlh);
                memset(id, 0, sizeof(*id));
                id->dir = dir;
@@ -2412,7 +2388,11 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *
                else
                        memcpy(&id->sel, &xp->selector, sizeof(id->sel));
 
-               p = RTA_DATA(__RTA_PUT(skb, XFRMA_POLICY, sizeof(*p)));
+               attr = nla_reserve(skb, XFRMA_POLICY, sizeof(*p));
+               if (attr == NULL)
+                       goto nlmsg_failure;
+
+               p = nla_data(attr);
        }
 
        copy_to_user_policy(xp, p, dir);
@@ -2423,11 +2403,9 @@ static int xfrm_notify_policy(struct xfrm_policy *xp, int dir, struct km_event *
 
        nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_POLICY;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
 
 nlmsg_failure:
-rtattr_failure:
        kfree_skb(skb);
        return -1;
 }
@@ -2436,13 +2414,8 @@ static int xfrm_notify_policy_flush(struct km_event *c)
 {
        struct nlmsghdr *nlh;
        struct sk_buff *skb;
-       int len = 0;
-#ifdef CONFIG_XFRM_SUB_POLICY
-       len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
-#endif
-       len += NLMSG_LENGTH(0);
 
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(userpolicy_type_attrsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
@@ -2454,8 +2427,7 @@ static int xfrm_notify_policy_flush(struct km_event *c)
 
        nlmsg_end(skb, nlh);
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_POLICY;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_POLICY, GFP_ATOMIC);
 
 nlmsg_failure:
        kfree_skb(skb);
@@ -2482,6 +2454,11 @@ static int xfrm_send_policy_notify(struct xfrm_policy *xp, int dir, struct km_ev
 
 }
 
+static inline size_t xfrm_report_msgsize(void)
+{
+       return NLMSG_ALIGN(sizeof(struct xfrm_user_report));
+}
+
 static int build_report(struct sk_buff *skb, u8 proto,
                        struct xfrm_selector *sel, xfrm_address_t *addr)
 {
@@ -2497,11 +2474,11 @@ static int build_report(struct sk_buff *skb, u8 proto,
        memcpy(&ur->sel, sel, sizeof(ur->sel));
 
        if (addr)
-               RTA_PUT(skb, XFRMA_COADDR, sizeof(*addr), addr);
+               NLA_PUT(skb, XFRMA_COADDR, sizeof(*addr), addr);
 
        return nlmsg_end(skb, nlh);
 
-rtattr_failure:
+nla_put_failure:
        nlmsg_cancel(skb, nlh);
        return -EMSGSIZE;
 }
@@ -2510,18 +2487,15 @@ static int xfrm_send_report(u8 proto, struct xfrm_selector *sel,
                            xfrm_address_t *addr)
 {
        struct sk_buff *skb;
-       size_t len;
 
-       len = NLMSG_ALIGN(NLMSG_LENGTH(sizeof(struct xfrm_user_report)));
-       skb = alloc_skb(len, GFP_ATOMIC);
+       skb = nlmsg_new(xfrm_report_msgsize(), GFP_ATOMIC);
        if (skb == NULL)
                return -ENOMEM;
 
        if (build_report(skb, proto, sel, addr) < 0)
                BUG();
 
-       NETLINK_CB(skb).dst_group = XFRMNLGRP_REPORT;
-       return netlink_broadcast(xfrm_nl, skb, 0, XFRMNLGRP_REPORT, GFP_ATOMIC);
+       return nlmsg_multicast(xfrm_nl, skb, 0, XFRMNLGRP_REPORT, GFP_ATOMIC);
 }
 
 static struct xfrm_mgr netlink_mgr = {