]> bbs.cooldavid.org Git - net-next-2.6.git/blobdiff - drivers/net/qlcnic/qlcnic_main.c
qlcnic: remove private LRO flag
[net-next-2.6.git] / drivers / net / qlcnic / qlcnic_main.c
index 5fd2abd1eb6710a6ea3f08d54edf553ef643a775..e3c1b80e00b18ef8b9d7d775c0b8a97eb6d61357 100644 (file)
@@ -28,6 +28,7 @@
 
 #include "qlcnic.h"
 
+#include <linux/swab.h>
 #include <linux/dma-mapping.h>
 #include <linux/if_vlan.h>
 #include <net/ip.h>
@@ -45,11 +46,7 @@ char qlcnic_driver_name[] = "qlcnic";
 static const char qlcnic_driver_string[] = "QLogic 1/10 GbE "
        "Converged/Intelligent Ethernet Driver v" QLCNIC_LINUX_VERSIONID;
 
-static int port_mode = QLCNIC_PORT_MODE_AUTO_NEG;
-
-/* Default to restricted 1G auto-neg mode */
-static int wol_port_mode = 5;
-
+static struct workqueue_struct *qlcnic_wq;
 static int qlcnic_mac_learn;
 module_param(qlcnic_mac_learn, int, 0644);
 MODULE_PARM_DESC(qlcnic_mac_learn, "Mac Filter (0=disabled, 1=enabled)");
@@ -107,7 +104,7 @@ static irqreturn_t qlcnic_msi_intr(int irq, void *data);
 static irqreturn_t qlcnic_msix_intr(int irq, void *data);
 
 static struct net_device_stats *qlcnic_get_stats(struct net_device *netdev);
-static void qlcnic_config_indev_addr(struct net_device *dev, unsigned long);
+static void qlcnic_restore_indev_addr(struct net_device *dev, unsigned long);
 static int qlcnic_start_firmware(struct qlcnic_adapter *);
 
 static void qlcnic_alloc_lb_filters_mem(struct qlcnic_adapter *adapter);
@@ -172,7 +169,7 @@ qlcnic_alloc_sds_rings(struct qlcnic_recv_context *recv_ctx, int count)
 
        recv_ctx->sds_rings = kzalloc(size, GFP_KERNEL);
 
-       return (recv_ctx->sds_rings == NULL);
+       return recv_ctx->sds_rings == NULL;
 }
 
 static void
@@ -263,40 +260,6 @@ static void qlcnic_clear_stats(struct qlcnic_adapter *adapter)
        memset(&adapter->stats, 0, sizeof(adapter->stats));
 }
 
-static void qlcnic_set_port_mode(struct qlcnic_adapter *adapter)
-{
-       u32 val, data;
-
-       val = adapter->ahw.board_type;
-       if ((val == QLCNIC_BRDTYPE_P3_HMEZ) ||
-               (val == QLCNIC_BRDTYPE_P3_XG_LOM)) {
-               if (port_mode == QLCNIC_PORT_MODE_802_3_AP) {
-                       data = QLCNIC_PORT_MODE_802_3_AP;
-                       QLCWR32(adapter, QLCNIC_PORT_MODE_ADDR, data);
-               } else if (port_mode == QLCNIC_PORT_MODE_XG) {
-                       data = QLCNIC_PORT_MODE_XG;
-                       QLCWR32(adapter, QLCNIC_PORT_MODE_ADDR, data);
-               } else if (port_mode == QLCNIC_PORT_MODE_AUTO_NEG_1G) {
-                       data = QLCNIC_PORT_MODE_AUTO_NEG_1G;
-                       QLCWR32(adapter, QLCNIC_PORT_MODE_ADDR, data);
-               } else if (port_mode == QLCNIC_PORT_MODE_AUTO_NEG_XG) {
-                       data = QLCNIC_PORT_MODE_AUTO_NEG_XG;
-                       QLCWR32(adapter, QLCNIC_PORT_MODE_ADDR, data);
-               } else {
-                       data = QLCNIC_PORT_MODE_AUTO_NEG;
-                       QLCWR32(adapter, QLCNIC_PORT_MODE_ADDR, data);
-               }
-
-               if ((wol_port_mode != QLCNIC_PORT_MODE_802_3_AP) &&
-                       (wol_port_mode != QLCNIC_PORT_MODE_XG) &&
-                       (wol_port_mode != QLCNIC_PORT_MODE_AUTO_NEG_1G) &&
-                       (wol_port_mode != QLCNIC_PORT_MODE_AUTO_NEG_XG)) {
-                       wol_port_mode = QLCNIC_PORT_MODE_AUTO_NEG;
-               }
-               QLCWR32(adapter, QLCNIC_WOL_PORT_MODE, wol_port_mode);
-       }
-}
-
 static void qlcnic_set_msix_bit(struct pci_dev *pdev, int enable)
 {
        u32 control;
@@ -371,6 +334,13 @@ static int qlcnic_set_mac(struct net_device *netdev, void *p)
        return 0;
 }
 
+static void qlcnic_vlan_rx_register(struct net_device *netdev,
+               struct vlan_group *grp)
+{
+       struct qlcnic_adapter *adapter = netdev_priv(netdev);
+       adapter->vlgrp = grp;
+}
+
 static const struct net_device_ops qlcnic_netdev_ops = {
        .ndo_open          = qlcnic_open,
        .ndo_stop          = qlcnic_close,
@@ -381,6 +351,7 @@ static const struct net_device_ops qlcnic_netdev_ops = {
        .ndo_set_mac_address    = qlcnic_set_mac,
        .ndo_change_mtu    = qlcnic_change_mtu,
        .ndo_tx_timeout    = qlcnic_tx_timeout,
+       .ndo_vlan_rx_register = qlcnic_vlan_rx_register,
 #ifdef CONFIG_NET_POLL_CONTROLLER
        .ndo_poll_controller = qlcnic_poll_controller,
 #endif
@@ -512,9 +483,9 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter)
                pfn = pci_info[i].id;
                if (pfn > QLCNIC_MAX_PCI_FUNC)
                        return QL_STATUS_INVALID_PARAM;
-               adapter->npars[pfn].active = pci_info[i].active;
-               adapter->npars[pfn].type = pci_info[i].type;
-               adapter->npars[pfn].phy_port = pci_info[i].default_port;
+               adapter->npars[pfn].active = (u8)pci_info[i].active;
+               adapter->npars[pfn].type = (u8)pci_info[i].type;
+               adapter->npars[pfn].phy_port = (u8)pci_info[i].default_port;
                adapter->npars[pfn].min_bw = pci_info[i].tx_min_bw;
                adapter->npars[pfn].max_bw = pci_info[i].tx_max_bw;
        }
@@ -686,8 +657,6 @@ qlcnic_check_options(struct qlcnic_adapter *adapter)
        dev_info(&pdev->dev, "firmware v%d.%d.%d\n",
                        fw_major, fw_minor, fw_build);
 
-       adapter->flags &= ~QLCNIC_LRO_ENABLED;
-
        if (adapter->ahw.port_type == QLCNIC_XGBE) {
                adapter->num_rxd = DEFAULT_RCV_DESCRIPTORS_10G;
                adapter->num_jumbo_rxd = MAX_JUMBO_RCV_DESCRIPTORS_10G;
@@ -714,7 +683,7 @@ qlcnic_initialize_nic(struct qlcnic_adapter *adapter)
        if (err)
                return err;
 
-       adapter->physical_port = nic_info.phys_port;
+       adapter->physical_port = (u8)nic_info.phys_port;
        adapter->switch_mode = nic_info.switch_mode;
        adapter->max_tx_ques = nic_info.max_tx_ques;
        adapter->max_rx_ques = nic_info.max_rx_ques;
@@ -1023,7 +992,6 @@ qlcnic_start_firmware(struct qlcnic_adapter *adapter)
        err = qlcnic_pinit_from_rom(adapter);
        if (err)
                goto err_out;
-       qlcnic_set_port_mode(adapter);
 
        err = qlcnic_load_firmware(adapter);
        if (err)
@@ -1446,7 +1414,7 @@ qlcnic_setup_netdev(struct qlcnic_adapter *adapter,
        SET_ETHTOOL_OPS(netdev, &qlcnic_ethtool_ops);
 
        netdev->features |= (NETIF_F_SG | NETIF_F_IP_CSUM |
-               NETIF_F_IPV6_CSUM | NETIF_F_GRO);
+               NETIF_F_IPV6_CSUM | NETIF_F_GRO | NETIF_F_HW_VLAN_RX);
        netdev->vlan_features |= (NETIF_F_SG | NETIF_F_IP_CSUM |
                NETIF_F_IPV6_CSUM);
 
@@ -1751,7 +1719,7 @@ qlcnic_resume(struct pci_dev *pdev)
                if (err)
                        goto done;
 
-               qlcnic_config_indev_addr(netdev, NETDEV_UP);
+               qlcnic_restore_indev_addr(netdev, NETDEV_UP);
        }
 done:
        netif_device_attach(netdev);
@@ -1826,11 +1794,12 @@ static void qlcnic_free_lb_filters_mem(struct qlcnic_adapter *adapter)
 }
 
 static void qlcnic_change_filter(struct qlcnic_adapter *adapter,
-               u64 uaddr, u16 vlan_id, struct qlcnic_host_tx_ring *tx_ring)
+               u64 uaddr, __le16 vlan_id, struct qlcnic_host_tx_ring *tx_ring)
 {
        struct cmd_desc_type0 *hwdesc;
        struct qlcnic_nic_req *req;
        struct qlcnic_mac_req *mac_req;
+       struct qlcnic_vlan_req *vlan_req;
        u32 producer;
        u64 word;
 
@@ -1848,7 +1817,8 @@ static void qlcnic_change_filter(struct qlcnic_adapter *adapter,
        mac_req->op = vlan_id ? QLCNIC_MAC_VLAN_ADD : QLCNIC_MAC_ADD;
        memcpy(mac_req->mac_addr, &uaddr, ETH_ALEN);
 
-       req->words[1] = cpu_to_le64(vlan_id);
+       vlan_req = (struct qlcnic_vlan_req *)&req->words[1];
+       vlan_req->vlan_id = vlan_id;
 
        tx_ring->producer = get_next_index(producer, tx_ring->num_desc);
 }
@@ -1867,7 +1837,7 @@ qlcnic_send_filter(struct qlcnic_adapter *adapter,
        struct hlist_node *tmp_hnode, *n;
        struct hlist_head *head;
        u64 src_addr = 0;
-       u16 vlan_id = 0;
+       __le16 vlan_id = 0;
        u8 hindex;
 
        if (!compare_ether_addr(phdr->h_source, adapter->mac_addr))
@@ -1920,7 +1890,8 @@ qlcnic_tso_check(struct net_device *netdev,
        struct vlan_ethhdr *vh;
        struct qlcnic_adapter *adapter = netdev_priv(netdev);
        u32 producer = tx_ring->producer;
-       int vlan_oob = first_desc->flags_opcode & cpu_to_le16(FLAGS_VLAN_OOB);
+       __le16 vlan_oob = first_desc->flags_opcode &
+                               cpu_to_le16(FLAGS_VLAN_OOB);
 
        if (*(skb->data) & BIT_0) {
                flags |= BIT_0;
@@ -1991,7 +1962,8 @@ qlcnic_tso_check(struct net_device *netdev,
                vh = (struct vlan_ethhdr *)((char *)hwdesc + 2);
                skb_copy_from_linear_data(skb, vh, 12);
                vh->h_vlan_proto = htons(ETH_P_8021Q);
-               vh->h_vlan_TCI = htons(first_desc->vlan_TCI);
+               vh->h_vlan_TCI = (__be16)swab16((u16)first_desc->vlan_TCI);
+
                skb_copy_from_linear_data_offset(skb, 12,
                                (char *)vh + 16, copy_len - 16);
 
@@ -2738,7 +2710,8 @@ qlcnic_fwinit_work(struct work_struct *work)
                goto err_ret;
 
        dev_state = QLCRD32(adapter, QLCNIC_CRB_DEV_STATE);
-       if (dev_state ==  QLCNIC_DEV_QUISCENT) {
+       if (dev_state == QLCNIC_DEV_QUISCENT ||
+           dev_state == QLCNIC_DEV_NEED_QUISCENT) {
                qlcnic_api_unlock(adapter);
                qlcnic_schedule_work(adapter, qlcnic_fwinit_work,
                                                FW_POLL_DELAY * 2);
@@ -2760,18 +2733,6 @@ qlcnic_fwinit_work(struct work_struct *work)
 skip_ack_check:
                dev_state = QLCRD32(adapter, QLCNIC_CRB_DEV_STATE);
 
-               if (dev_state == QLCNIC_DEV_NEED_QUISCENT) {
-                       QLCWR32(adapter, QLCNIC_CRB_DEV_STATE,
-                                               QLCNIC_DEV_QUISCENT);
-                       qlcnic_schedule_work(adapter, qlcnic_fwinit_work,
-                                               FW_POLL_DELAY * 2);
-                       QLCDB(adapter, DRV, "Quiscing the driver\n");
-                       qlcnic_idc_debug_info(adapter, 0);
-
-                       qlcnic_api_unlock(adapter);
-                       return;
-               }
-
                if (dev_state == QLCNIC_DEV_NEED_RESET) {
                        QLCWR32(adapter, QLCNIC_CRB_DEV_STATE,
                                                QLCNIC_DEV_INITIALIZING);
@@ -2828,7 +2789,12 @@ qlcnic_detach_work(struct work_struct *work)
 
        netif_device_detach(netdev);
 
-       qlcnic_down(adapter, netdev);
+       /* Dont grab rtnl lock during Quiscent mode */
+       if (adapter->dev_state == QLCNIC_DEV_NEED_QUISCENT) {
+               if (netif_running(netdev))
+                       __qlcnic_down(adapter, netdev);
+       } else
+               qlcnic_down(adapter, netdev);
 
        status = QLCRD32(adapter, QLCNIC_PEG_HALT_STATUS1);
 
@@ -2870,6 +2836,61 @@ qlcnic_set_npar_non_operational(struct qlcnic_adapter *adapter)
        qlcnic_api_unlock(adapter);
 }
 
+/* Caller should held RESETTING bit.
+ * This should be call in sync with qlcnic_request_quiscent_mode.
+ */
+void qlcnic_clear_quiscent_mode(struct qlcnic_adapter *adapter)
+{
+       qlcnic_clr_drv_state(adapter);
+       qlcnic_api_lock(adapter);
+       QLCWR32(adapter, QLCNIC_CRB_DEV_STATE, QLCNIC_DEV_READY);
+       qlcnic_api_unlock(adapter);
+}
+
+/* Caller should held RESETTING bit.
+ */
+int qlcnic_request_quiscent_mode(struct qlcnic_adapter *adapter)
+{
+       u8 timeo = adapter->dev_init_timeo / 2;
+       u32 state;
+
+       if (qlcnic_api_lock(adapter))
+               return -EIO;
+
+       state = QLCRD32(adapter, QLCNIC_CRB_DEV_STATE);
+       if (state != QLCNIC_DEV_READY)
+               return -EIO;
+
+       QLCWR32(adapter, QLCNIC_CRB_DEV_STATE, QLCNIC_DEV_NEED_QUISCENT);
+       qlcnic_api_unlock(adapter);
+       QLCDB(adapter, DRV, "NEED QUISCENT state set\n");
+       qlcnic_idc_debug_info(adapter, 0);
+
+       qlcnic_set_drv_state(adapter, QLCNIC_DEV_NEED_QUISCENT);
+
+       do {
+               msleep(2000);
+               state = QLCRD32(adapter, QLCNIC_CRB_DEV_STATE);
+               if (state == QLCNIC_DEV_QUISCENT)
+                       return 0;
+               if (!qlcnic_check_drv_state(adapter)) {
+                       if (qlcnic_api_lock(adapter))
+                               return -EIO;
+                       QLCWR32(adapter, QLCNIC_CRB_DEV_STATE,
+                                                       QLCNIC_DEV_QUISCENT);
+                       qlcnic_api_unlock(adapter);
+                       QLCDB(adapter, DRV, "QUISCENT mode set\n");
+                       return 0;
+               }
+       } while (--timeo);
+
+       dev_err(&adapter->pdev->dev, "Failed to quiesce device, DRV_STATE=%08x"
+               " DRV_ACTIVE=%08x\n", QLCRD32(adapter, QLCNIC_CRB_DRV_STATE),
+               QLCRD32(adapter, QLCNIC_CRB_DRV_ACTIVE));
+       qlcnic_clear_quiscent_mode(adapter);
+       return -EIO;
+}
+
 /*Transit to RESET state from READY state only */
 static void
 qlcnic_dev_request_reset(struct qlcnic_adapter *adapter)
@@ -2913,7 +2934,8 @@ qlcnic_schedule_work(struct qlcnic_adapter *adapter,
                return;
 
        INIT_DELAYED_WORK(&adapter->fw_work, func);
-       schedule_delayed_work(&adapter->fw_work, round_jiffies_relative(delay));
+       queue_delayed_work(qlcnic_wq, &adapter->fw_work,
+                                       round_jiffies_relative(delay));
 }
 
 static void
@@ -2950,7 +2972,7 @@ attach:
                if (qlcnic_up(adapter, netdev))
                        goto done;
 
-               qlcnic_config_indev_addr(netdev, NETDEV_UP);
+               qlcnic_restore_indev_addr(netdev, NETDEV_UP);
        }
 
 done:
@@ -2976,11 +2998,11 @@ qlcnic_check_health(struct qlcnic_adapter *adapter)
                qlcnic_dev_request_reset(adapter);
 
        state = QLCRD32(adapter, QLCNIC_CRB_DEV_STATE);
-       if (state == QLCNIC_DEV_NEED_RESET ||
-           state == QLCNIC_DEV_NEED_QUISCENT) {
+       if (state == QLCNIC_DEV_NEED_RESET) {
                qlcnic_set_npar_non_operational(adapter);
                adapter->need_fw_reset = 1;
-       }
+       } else if (state == QLCNIC_DEV_NEED_QUISCENT)
+               goto detach;
 
        heartbeat = QLCRD32(adapter, QLCNIC_PEG_ALIVE_COUNTER);
        if (heartbeat != adapter->heartbeat) {
@@ -3112,7 +3134,7 @@ static int qlcnic_attach_func(struct pci_dev *pdev)
                if (err)
                        goto done;
 
-               qlcnic_config_indev_addr(netdev, NETDEV_UP);
+               qlcnic_restore_indev_addr(netdev, NETDEV_UP);
        }
  done:
        netif_device_attach(netdev);
@@ -3749,7 +3771,7 @@ qlcnic_sysfs_read_npar_config(struct file *file, struct kobject *kobj,
                        return ret;
 
                np_cfg[i].pci_func = i;
-               np_cfg[i].op_mode = nic_info.op_mode;
+               np_cfg[i].op_mode = (u8)nic_info.op_mode;
                np_cfg[i].port_num = nic_info.phys_port;
                np_cfg[i].fw_capab = nic_info.capabilities;
                np_cfg[i].min_bw = nic_info.min_tx_bw ;
@@ -4027,10 +4049,10 @@ qlcnic_remove_diag_entries(struct qlcnic_adapter *adapter)
 #define is_qlcnic_netdev(dev) (dev->netdev_ops == &qlcnic_netdev_ops)
 
 static void
-qlcnic_config_indev_addr(struct net_device *dev, unsigned long event)
+qlcnic_config_indev_addr(struct qlcnic_adapter *adapter,
+                       struct net_device *dev, unsigned long event)
 {
        struct in_device *indev;
-       struct qlcnic_adapter *adapter = netdev_priv(dev);
 
        indev = in_dev_get(dev);
        if (!indev)
@@ -4054,6 +4076,27 @@ qlcnic_config_indev_addr(struct net_device *dev, unsigned long event)
        in_dev_put(indev);
 }
 
+static void
+qlcnic_restore_indev_addr(struct net_device *netdev, unsigned long event)
+{
+       struct qlcnic_adapter *adapter = netdev_priv(netdev);
+       struct net_device *dev;
+       u16 vid;
+
+       qlcnic_config_indev_addr(adapter, netdev, event);
+
+       if (!adapter->vlgrp)
+               return;
+
+       for (vid = 0; vid < VLAN_GROUP_ARRAY_LEN; vid++) {
+               dev = vlan_group_get_device(adapter->vlgrp, vid);
+               if (!dev)
+                       continue;
+
+               qlcnic_config_indev_addr(adapter, dev, event);
+       }
+}
+
 static int qlcnic_netdev_event(struct notifier_block *this,
                                 unsigned long event, void *ptr)
 {
@@ -4080,7 +4123,7 @@ recheck:
        if (!test_bit(__QLCNIC_DEV_UP, &adapter->state))
                goto done;
 
-       qlcnic_config_indev_addr(dev, event);
+       qlcnic_config_indev_addr(adapter, dev, event);
 done:
        return NOTIFY_DONE;
 }
@@ -4097,7 +4140,7 @@ qlcnic_inetaddr_event(struct notifier_block *this,
        dev = ifa->ifa_dev ? ifa->ifa_dev->dev : NULL;
 
 recheck:
-       if (dev == NULL || !netif_running(dev))
+       if (dev == NULL)
                goto done;
 
        if (dev->priv_flags & IFF_802_1Q_VLAN) {
@@ -4140,7 +4183,7 @@ static struct notifier_block qlcnic_inetaddr_cb = {
 };
 #else
 static void
-qlcnic_config_indev_addr(struct net_device *dev, unsigned long event)
+qlcnic_restore_indev_addr(struct net_device *dev, unsigned long event)
 { }
 #endif
 static struct pci_error_handlers qlcnic_err_handler = {
@@ -4169,6 +4212,12 @@ static int __init qlcnic_init_module(void)
 
        printk(KERN_INFO "%s\n", qlcnic_driver_string);
 
+       qlcnic_wq = create_singlethread_workqueue("qlcnic");
+       if (qlcnic_wq == NULL) {
+               printk(KERN_ERR "qlcnic: cannot create workqueue\n");
+               return -ENOMEM;
+       }
+
 #ifdef CONFIG_INET
        register_netdevice_notifier(&qlcnic_netdev_cb);
        register_inetaddr_notifier(&qlcnic_inetaddr_cb);
@@ -4180,6 +4229,7 @@ static int __init qlcnic_init_module(void)
                unregister_inetaddr_notifier(&qlcnic_inetaddr_cb);
                unregister_netdevice_notifier(&qlcnic_netdev_cb);
 #endif
+               destroy_workqueue(qlcnic_wq);
        }
 
        return ret;
@@ -4196,6 +4246,7 @@ static void __exit qlcnic_exit_module(void)
        unregister_inetaddr_notifier(&qlcnic_inetaddr_cb);
        unregister_netdevice_notifier(&qlcnic_netdev_cb);
 #endif
+       destroy_workqueue(qlcnic_wq);
 }
 
 module_exit(qlcnic_exit_module);