]> bbs.cooldavid.org Git - net-next-2.6.git/blame - drivers/gpu/drm/i915/intel_lvds.c
Merge branch 'fix/hda' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6
[net-next-2.6.git] / drivers / gpu / drm / i915 / intel_lvds.c
CommitLineData
79e53945
JB
1/*
2 * Copyright © 2006-2007 Intel Corporation
3 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
4 *
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
11 *
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
14 * Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
23 *
24 * Authors:
25 * Eric Anholt <eric@anholt.net>
26 * Dave Airlie <airlied@linux.ie>
27 * Jesse Barnes <jesse.barnes@intel.com>
28 */
29
c1c7af60 30#include <acpi/button.h>
565dcd46 31#include <linux/dmi.h>
79e53945 32#include <linux/i2c.h>
5a0e3ad6 33#include <linux/slab.h>
79e53945
JB
34#include "drmP.h"
35#include "drm.h"
36#include "drm_crtc.h"
37#include "drm_edid.h"
38#include "intel_drv.h"
39#include "i915_drm.h"
40#include "i915_drv.h"
e99da35f 41#include <linux/acpi.h>
79e53945 42
3fbe18d6
ZY
43/* Private structure for the integrated LVDS support */
44struct intel_lvds_priv {
45 int fitting_mode;
46 u32 pfit_control;
47 u32 pfit_pgm_ratios;
48};
49
79e53945
JB
50/**
51 * Sets the backlight level.
52 *
53 * \param level backlight level, from 0 to intel_lvds_get_max_backlight().
54 */
55static void intel_lvds_set_backlight(struct drm_device *dev, int level)
56{
57 struct drm_i915_private *dev_priv = dev->dev_private;
541998a1 58 u32 blc_pwm_ctl, reg;
79e53945 59
c619eed4 60 if (HAS_PCH_SPLIT(dev))
541998a1
ZW
61 reg = BLC_PWM_CPU_CTL;
62 else
63 reg = BLC_PWM_CTL;
79e53945 64
541998a1
ZW
65 blc_pwm_ctl = I915_READ(reg) & ~BACKLIGHT_DUTY_CYCLE_MASK;
66 I915_WRITE(reg, (blc_pwm_ctl |
79e53945
JB
67 (level << BACKLIGHT_DUTY_CYCLE_SHIFT)));
68}
69
70/**
71 * Returns the maximum level of the backlight duty cycle field.
72 */
73static u32 intel_lvds_get_max_backlight(struct drm_device *dev)
74{
75 struct drm_i915_private *dev_priv = dev->dev_private;
541998a1
ZW
76 u32 reg;
77
c619eed4 78 if (HAS_PCH_SPLIT(dev))
541998a1
ZW
79 reg = BLC_PWM_PCH_CTL2;
80 else
81 reg = BLC_PWM_CTL;
79e53945 82
541998a1 83 return ((I915_READ(reg) & BACKLIGHT_MODULATION_FREQ_MASK) >>
79e53945
JB
84 BACKLIGHT_MODULATION_FREQ_SHIFT) * 2;
85}
86
87/**
88 * Sets the power state for the panel.
89 */
90static void intel_lvds_set_power(struct drm_device *dev, bool on)
91{
92 struct drm_i915_private *dev_priv = dev->dev_private;
469d1296 93 u32 pp_status, ctl_reg, status_reg, lvds_reg;
541998a1 94
c619eed4 95 if (HAS_PCH_SPLIT(dev)) {
541998a1
ZW
96 ctl_reg = PCH_PP_CONTROL;
97 status_reg = PCH_PP_STATUS;
469d1296 98 lvds_reg = PCH_LVDS;
541998a1
ZW
99 } else {
100 ctl_reg = PP_CONTROL;
101 status_reg = PP_STATUS;
469d1296 102 lvds_reg = LVDS;
541998a1 103 }
79e53945
JB
104
105 if (on) {
469d1296
JB
106 I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
107 POSTING_READ(lvds_reg);
108
541998a1 109 I915_WRITE(ctl_reg, I915_READ(ctl_reg) |
79e53945
JB
110 POWER_TARGET_ON);
111 do {
541998a1 112 pp_status = I915_READ(status_reg);
79e53945
JB
113 } while ((pp_status & PP_ON) == 0);
114
115 intel_lvds_set_backlight(dev, dev_priv->backlight_duty_cycle);
116 } else {
117 intel_lvds_set_backlight(dev, 0);
118
541998a1 119 I915_WRITE(ctl_reg, I915_READ(ctl_reg) &
79e53945
JB
120 ~POWER_TARGET_ON);
121 do {
541998a1 122 pp_status = I915_READ(status_reg);
79e53945 123 } while (pp_status & PP_ON);
469d1296
JB
124
125 I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
126 POSTING_READ(lvds_reg);
79e53945
JB
127 }
128}
129
130static void intel_lvds_dpms(struct drm_encoder *encoder, int mode)
131{
132 struct drm_device *dev = encoder->dev;
133
134 if (mode == DRM_MODE_DPMS_ON)
135 intel_lvds_set_power(dev, true);
136 else
137 intel_lvds_set_power(dev, false);
138
139 /* XXX: We never power down the LVDS pairs. */
140}
141
79e53945
JB
142static int intel_lvds_mode_valid(struct drm_connector *connector,
143 struct drm_display_mode *mode)
144{
145 struct drm_device *dev = connector->dev;
146 struct drm_i915_private *dev_priv = dev->dev_private;
147 struct drm_display_mode *fixed_mode = dev_priv->panel_fixed_mode;
148
149 if (fixed_mode) {
150 if (mode->hdisplay > fixed_mode->hdisplay)
151 return MODE_PANEL;
152 if (mode->vdisplay > fixed_mode->vdisplay)
153 return MODE_PANEL;
154 }
155
156 return MODE_OK;
157}
158
159static bool intel_lvds_mode_fixup(struct drm_encoder *encoder,
160 struct drm_display_mode *mode,
161 struct drm_display_mode *adjusted_mode)
162{
3fbe18d6
ZY
163 /*
164 * float point operation is not supported . So the PANEL_RATIO_FACTOR
165 * is defined, which can avoid the float point computation when
166 * calculating the panel ratio.
167 */
168#define PANEL_RATIO_FACTOR 8192
79e53945
JB
169 struct drm_device *dev = encoder->dev;
170 struct drm_i915_private *dev_priv = dev->dev_private;
171 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
172 struct drm_encoder *tmp_encoder;
21d40d37
EA
173 struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
174 struct intel_lvds_priv *lvds_priv = intel_encoder->dev_priv;
3fbe18d6
ZY
175 u32 pfit_control = 0, pfit_pgm_ratios = 0;
176 int left_border = 0, right_border = 0, top_border = 0;
177 int bottom_border = 0;
178 bool border = 0;
179 int panel_ratio, desired_ratio, vert_scale, horiz_scale;
180 int horiz_ratio, vert_ratio;
aa0261f2
ZY
181 u32 hsync_width, vsync_width;
182 u32 hblank_width, vblank_width;
183 u32 hsync_pos, vsync_pos;
79e53945
JB
184
185 /* Should never happen!! */
186 if (!IS_I965G(dev) && intel_crtc->pipe == 0) {
1ae8c0a5 187 DRM_ERROR("Can't support LVDS on pipe A\n");
79e53945
JB
188 return false;
189 }
190
191 /* Should never happen!! */
192 list_for_each_entry(tmp_encoder, &dev->mode_config.encoder_list, head) {
193 if (tmp_encoder != encoder && tmp_encoder->crtc == encoder->crtc) {
1ae8c0a5 194 DRM_ERROR("Can't enable LVDS and another "
79e53945
JB
195 "encoder on the same pipe\n");
196 return false;
197 }
198 }
3fbe18d6
ZY
199 /* If we don't have a panel mode, there is nothing we can do */
200 if (dev_priv->panel_fixed_mode == NULL)
201 return true;
79e53945
JB
202 /*
203 * If we have timings from the BIOS for the panel, put them in
204 * to the adjusted mode. The CRTC will be set up for this mode,
205 * with the panel scaling set up to source from the H/VDisplay
206 * of the original mode.
207 */
208 if (dev_priv->panel_fixed_mode != NULL) {
209 adjusted_mode->hdisplay = dev_priv->panel_fixed_mode->hdisplay;
210 adjusted_mode->hsync_start =
211 dev_priv->panel_fixed_mode->hsync_start;
212 adjusted_mode->hsync_end =
213 dev_priv->panel_fixed_mode->hsync_end;
214 adjusted_mode->htotal = dev_priv->panel_fixed_mode->htotal;
215 adjusted_mode->vdisplay = dev_priv->panel_fixed_mode->vdisplay;
216 adjusted_mode->vsync_start =
217 dev_priv->panel_fixed_mode->vsync_start;
218 adjusted_mode->vsync_end =
219 dev_priv->panel_fixed_mode->vsync_end;
220 adjusted_mode->vtotal = dev_priv->panel_fixed_mode->vtotal;
221 adjusted_mode->clock = dev_priv->panel_fixed_mode->clock;
222 drm_mode_set_crtcinfo(adjusted_mode, CRTC_INTERLACE_HALVE_V);
223 }
224
3fbe18d6
ZY
225 /* Make sure pre-965s set dither correctly */
226 if (!IS_I965G(dev)) {
227 if (dev_priv->panel_wants_dither || dev_priv->lvds_dither)
228 pfit_control |= PANEL_8TO6_DITHER_ENABLE;
229 }
230
231 /* Native modes don't need fitting */
232 if (adjusted_mode->hdisplay == mode->hdisplay &&
233 adjusted_mode->vdisplay == mode->vdisplay) {
234 pfit_pgm_ratios = 0;
235 border = 0;
236 goto out;
237 }
238
8dd81a38 239 /* full screen scale for now */
c619eed4 240 if (HAS_PCH_SPLIT(dev))
8dd81a38
ZW
241 goto out;
242
3fbe18d6
ZY
243 /* 965+ wants fuzzy fitting */
244 if (IS_I965G(dev))
245 pfit_control |= (intel_crtc->pipe << PFIT_PIPE_SHIFT) |
246 PFIT_FILTER_FUZZY;
247
aa0261f2
ZY
248 hsync_width = adjusted_mode->crtc_hsync_end -
249 adjusted_mode->crtc_hsync_start;
250 vsync_width = adjusted_mode->crtc_vsync_end -
251 adjusted_mode->crtc_vsync_start;
252 hblank_width = adjusted_mode->crtc_hblank_end -
253 adjusted_mode->crtc_hblank_start;
254 vblank_width = adjusted_mode->crtc_vblank_end -
255 adjusted_mode->crtc_vblank_start;
3fbe18d6
ZY
256 /*
257 * Deal with panel fitting options. Figure out how to stretch the
258 * image based on its aspect ratio & the current panel fitting mode.
259 */
260 panel_ratio = adjusted_mode->hdisplay * PANEL_RATIO_FACTOR /
261 adjusted_mode->vdisplay;
262 desired_ratio = mode->hdisplay * PANEL_RATIO_FACTOR /
263 mode->vdisplay;
264 /*
265 * Enable automatic panel scaling for non-native modes so that they fill
266 * the screen. Should be enabled before the pipe is enabled, according
267 * to register description and PRM.
268 * Change the value here to see the borders for debugging
269 */
c619eed4 270 if (!HAS_PCH_SPLIT(dev)) {
8dd81a38
ZW
271 I915_WRITE(BCLRPAT_A, 0);
272 I915_WRITE(BCLRPAT_B, 0);
273 }
3fbe18d6
ZY
274
275 switch (lvds_priv->fitting_mode) {
53bd8389 276 case DRM_MODE_SCALE_CENTER:
3fbe18d6
ZY
277 /*
278 * For centered modes, we have to calculate border widths &
279 * heights and modify the values programmed into the CRTC.
280 */
281 left_border = (adjusted_mode->hdisplay - mode->hdisplay) / 2;
282 right_border = left_border;
283 if (mode->hdisplay & 1)
284 right_border++;
285 top_border = (adjusted_mode->vdisplay - mode->vdisplay) / 2;
286 bottom_border = top_border;
287 if (mode->vdisplay & 1)
288 bottom_border++;
289 /* Set active & border values */
290 adjusted_mode->crtc_hdisplay = mode->hdisplay;
aa0261f2
ZY
291 /* Keep the boder be even */
292 if (right_border & 1)
293 right_border++;
294 /* use the border directly instead of border minuse one */
3fbe18d6 295 adjusted_mode->crtc_hblank_start = mode->hdisplay +
aa0261f2
ZY
296 right_border;
297 /* keep the blank width constant */
298 adjusted_mode->crtc_hblank_end =
299 adjusted_mode->crtc_hblank_start + hblank_width;
300 /* get the hsync pos relative to hblank start */
301 hsync_pos = (hblank_width - hsync_width) / 2;
302 /* keep the hsync pos be even */
303 if (hsync_pos & 1)
304 hsync_pos++;
3fbe18d6 305 adjusted_mode->crtc_hsync_start =
aa0261f2
ZY
306 adjusted_mode->crtc_hblank_start + hsync_pos;
307 /* keep the hsync width constant */
3fbe18d6 308 adjusted_mode->crtc_hsync_end =
aa0261f2 309 adjusted_mode->crtc_hsync_start + hsync_width;
3fbe18d6 310 adjusted_mode->crtc_vdisplay = mode->vdisplay;
aa0261f2 311 /* use the border instead of border minus one */
3fbe18d6 312 adjusted_mode->crtc_vblank_start = mode->vdisplay +
aa0261f2
ZY
313 bottom_border;
314 /* keep the vblank width constant */
315 adjusted_mode->crtc_vblank_end =
316 adjusted_mode->crtc_vblank_start + vblank_width;
317 /* get the vsync start postion relative to vblank start */
318 vsync_pos = (vblank_width - vsync_width) / 2;
3fbe18d6 319 adjusted_mode->crtc_vsync_start =
aa0261f2
ZY
320 adjusted_mode->crtc_vblank_start + vsync_pos;
321 /* keep the vsync width constant */
3fbe18d6 322 adjusted_mode->crtc_vsync_end =
a3e17eb8 323 adjusted_mode->crtc_vsync_start + vsync_width;
3fbe18d6
ZY
324 border = 1;
325 break;
326 case DRM_MODE_SCALE_ASPECT:
327 /* Scale but preserve the spect ratio */
328 pfit_control |= PFIT_ENABLE;
329 if (IS_I965G(dev)) {
330 /* 965+ is easy, it does everything in hw */
331 if (panel_ratio > desired_ratio)
332 pfit_control |= PFIT_SCALING_PILLAR;
333 else if (panel_ratio < desired_ratio)
334 pfit_control |= PFIT_SCALING_LETTER;
335 else
336 pfit_control |= PFIT_SCALING_AUTO;
337 } else {
338 /*
339 * For earlier chips we have to calculate the scaling
340 * ratio by hand and program it into the
341 * PFIT_PGM_RATIO register
342 */
343 u32 horiz_bits, vert_bits, bits = 12;
344 horiz_ratio = mode->hdisplay * PANEL_RATIO_FACTOR/
345 adjusted_mode->hdisplay;
346 vert_ratio = mode->vdisplay * PANEL_RATIO_FACTOR/
347 adjusted_mode->vdisplay;
348 horiz_scale = adjusted_mode->hdisplay *
349 PANEL_RATIO_FACTOR / mode->hdisplay;
350 vert_scale = adjusted_mode->vdisplay *
351 PANEL_RATIO_FACTOR / mode->vdisplay;
352
353 /* retain aspect ratio */
354 if (panel_ratio > desired_ratio) { /* Pillar */
355 u32 scaled_width;
356 scaled_width = mode->hdisplay * vert_scale /
357 PANEL_RATIO_FACTOR;
358 horiz_ratio = vert_ratio;
359 pfit_control |= (VERT_AUTO_SCALE |
360 VERT_INTERP_BILINEAR |
361 HORIZ_INTERP_BILINEAR);
362 /* Pillar will have left/right borders */
363 left_border = (adjusted_mode->hdisplay -
364 scaled_width) / 2;
365 right_border = left_border;
366 if (mode->hdisplay & 1) /* odd resolutions */
367 right_border++;
aa0261f2
ZY
368 /* keep the border be even */
369 if (right_border & 1)
370 right_border++;
3fbe18d6 371 adjusted_mode->crtc_hdisplay = scaled_width;
aa0261f2 372 /* use border instead of border minus one */
3fbe18d6 373 adjusted_mode->crtc_hblank_start =
aa0261f2
ZY
374 scaled_width + right_border;
375 /* keep the hblank width constant */
3fbe18d6 376 adjusted_mode->crtc_hblank_end =
aa0261f2
ZY
377 adjusted_mode->crtc_hblank_start +
378 hblank_width;
379 /*
380 * get the hsync start pos relative to
381 * hblank start
382 */
383 hsync_pos = (hblank_width - hsync_width) / 2;
384 /* keep the hsync_pos be even */
385 if (hsync_pos & 1)
386 hsync_pos++;
3fbe18d6 387 adjusted_mode->crtc_hsync_start =
aa0261f2
ZY
388 adjusted_mode->crtc_hblank_start +
389 hsync_pos;
390 /* keept hsync width constant */
3fbe18d6 391 adjusted_mode->crtc_hsync_end =
aa0261f2
ZY
392 adjusted_mode->crtc_hsync_start +
393 hsync_width;
3fbe18d6
ZY
394 border = 1;
395 } else if (panel_ratio < desired_ratio) { /* letter */
396 u32 scaled_height = mode->vdisplay *
397 horiz_scale / PANEL_RATIO_FACTOR;
398 vert_ratio = horiz_ratio;
399 pfit_control |= (HORIZ_AUTO_SCALE |
400 VERT_INTERP_BILINEAR |
401 HORIZ_INTERP_BILINEAR);
402 /* Letterbox will have top/bottom border */
403 top_border = (adjusted_mode->vdisplay -
404 scaled_height) / 2;
405 bottom_border = top_border;
406 if (mode->vdisplay & 1)
407 bottom_border++;
408 adjusted_mode->crtc_vdisplay = scaled_height;
aa0261f2 409 /* use border instead of border minus one */
3fbe18d6 410 adjusted_mode->crtc_vblank_start =
aa0261f2
ZY
411 scaled_height + bottom_border;
412 /* keep the vblank width constant */
3fbe18d6 413 adjusted_mode->crtc_vblank_end =
aa0261f2
ZY
414 adjusted_mode->crtc_vblank_start +
415 vblank_width;
416 /*
417 * get the vsync start pos relative to
418 * vblank start
419 */
420 vsync_pos = (vblank_width - vsync_width) / 2;
3fbe18d6 421 adjusted_mode->crtc_vsync_start =
aa0261f2
ZY
422 adjusted_mode->crtc_vblank_start +
423 vsync_pos;
424 /* keep the vsync width constant */
3fbe18d6 425 adjusted_mode->crtc_vsync_end =
aa0261f2
ZY
426 adjusted_mode->crtc_vsync_start +
427 vsync_width;
3fbe18d6
ZY
428 border = 1;
429 } else {
430 /* Aspects match, Let hw scale both directions */
431 pfit_control |= (VERT_AUTO_SCALE |
432 HORIZ_AUTO_SCALE |
433 VERT_INTERP_BILINEAR |
434 HORIZ_INTERP_BILINEAR);
435 }
436 horiz_bits = (1 << bits) * horiz_ratio /
437 PANEL_RATIO_FACTOR;
438 vert_bits = (1 << bits) * vert_ratio /
439 PANEL_RATIO_FACTOR;
440 pfit_pgm_ratios =
441 ((vert_bits << PFIT_VERT_SCALE_SHIFT) &
442 PFIT_VERT_SCALE_MASK) |
443 ((horiz_bits << PFIT_HORIZ_SCALE_SHIFT) &
444 PFIT_HORIZ_SCALE_MASK);
445 }
446 break;
447
448 case DRM_MODE_SCALE_FULLSCREEN:
449 /*
450 * Full scaling, even if it changes the aspect ratio.
451 * Fortunately this is all done for us in hw.
452 */
453 pfit_control |= PFIT_ENABLE;
454 if (IS_I965G(dev))
455 pfit_control |= PFIT_SCALING_AUTO;
456 else
457 pfit_control |= (VERT_AUTO_SCALE | HORIZ_AUTO_SCALE |
458 VERT_INTERP_BILINEAR |
459 HORIZ_INTERP_BILINEAR);
460 break;
461 default:
462 break;
463 }
464
465out:
466 lvds_priv->pfit_control = pfit_control;
467 lvds_priv->pfit_pgm_ratios = pfit_pgm_ratios;
a3e17eb8
ZY
468 /*
469 * When there exists the border, it means that the LVDS_BORDR
470 * should be enabled.
471 */
472 if (border)
473 dev_priv->lvds_border_bits |= LVDS_BORDER_ENABLE;
474 else
475 dev_priv->lvds_border_bits &= ~(LVDS_BORDER_ENABLE);
79e53945
JB
476 /*
477 * XXX: It would be nice to support lower refresh rates on the
478 * panels to reduce power consumption, and perhaps match the
479 * user's requested refresh rate.
480 */
481
482 return true;
483}
484
485static void intel_lvds_prepare(struct drm_encoder *encoder)
486{
487 struct drm_device *dev = encoder->dev;
488 struct drm_i915_private *dev_priv = dev->dev_private;
541998a1 489 u32 reg;
79e53945 490
c619eed4 491 if (HAS_PCH_SPLIT(dev))
541998a1
ZW
492 reg = BLC_PWM_CPU_CTL;
493 else
494 reg = BLC_PWM_CTL;
79e53945 495
541998a1 496 dev_priv->saveBLC_PWM_CTL = I915_READ(reg);
79e53945
JB
497 dev_priv->backlight_duty_cycle = (dev_priv->saveBLC_PWM_CTL &
498 BACKLIGHT_DUTY_CYCLE_MASK);
499
500 intel_lvds_set_power(dev, false);
501}
502
503static void intel_lvds_commit( struct drm_encoder *encoder)
504{
505 struct drm_device *dev = encoder->dev;
506 struct drm_i915_private *dev_priv = dev->dev_private;
507
508 if (dev_priv->backlight_duty_cycle == 0)
509 dev_priv->backlight_duty_cycle =
510 intel_lvds_get_max_backlight(dev);
511
512 intel_lvds_set_power(dev, true);
513}
514
515static void intel_lvds_mode_set(struct drm_encoder *encoder,
516 struct drm_display_mode *mode,
517 struct drm_display_mode *adjusted_mode)
518{
519 struct drm_device *dev = encoder->dev;
520 struct drm_i915_private *dev_priv = dev->dev_private;
21d40d37
EA
521 struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
522 struct intel_lvds_priv *lvds_priv = intel_encoder->dev_priv;
79e53945
JB
523
524 /*
525 * The LVDS pin pair will already have been turned on in the
526 * intel_crtc_mode_set since it has a large impact on the DPLL
527 * settings.
528 */
529
c619eed4 530 if (HAS_PCH_SPLIT(dev))
541998a1
ZW
531 return;
532
79e53945
JB
533 /*
534 * Enable automatic panel scaling so that non-native modes fill the
535 * screen. Should be enabled before the pipe is enabled, according to
536 * register description and PRM.
537 */
3fbe18d6
ZY
538 I915_WRITE(PFIT_PGM_RATIOS, lvds_priv->pfit_pgm_ratios);
539 I915_WRITE(PFIT_CONTROL, lvds_priv->pfit_control);
79e53945
JB
540}
541
542/**
543 * Detect the LVDS connection.
544 *
b42d4c5c
JB
545 * Since LVDS doesn't have hotlug, we use the lid as a proxy. Open means
546 * connected and closed means disconnected. We also send hotplug events as
547 * needed, using lid status notification from the input layer.
79e53945
JB
548 */
549static enum drm_connector_status intel_lvds_detect(struct drm_connector *connector)
550{
7b9c5abe 551 struct drm_device *dev = connector->dev;
b42d4c5c
JB
552 enum drm_connector_status status = connector_status_connected;
553
7b9c5abe
JB
554 /* ACPI lid methods were generally unreliable in this generation, so
555 * don't even bother.
556 */
6e6c8228 557 if (IS_GEN2(dev) || IS_GEN3(dev))
7b9c5abe
JB
558 return connector_status_connected;
559
b42d4c5c 560 return status;
79e53945
JB
561}
562
563/**
564 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
565 */
566static int intel_lvds_get_modes(struct drm_connector *connector)
567{
568 struct drm_device *dev = connector->dev;
bb8a3560
ZW
569 struct drm_encoder *encoder = intel_attached_encoder(connector);
570 struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
79e53945
JB
571 struct drm_i915_private *dev_priv = dev->dev_private;
572 int ret = 0;
573
bfac4d67 574 if (dev_priv->lvds_edid_good) {
335af9a2 575 ret = intel_ddc_get_modes(connector, intel_encoder->ddc_bus);
79e53945 576
bfac4d67
ZY
577 if (ret)
578 return ret;
579 }
79e53945
JB
580
581 /* Didn't get an EDID, so
582 * Set wide sync ranges so we get all modes
583 * handed to valid_mode for checking
584 */
585 connector->display_info.min_vfreq = 0;
586 connector->display_info.max_vfreq = 200;
587 connector->display_info.min_hfreq = 0;
588 connector->display_info.max_hfreq = 200;
589
590 if (dev_priv->panel_fixed_mode != NULL) {
591 struct drm_display_mode *mode;
592
79e53945
JB
593 mode = drm_mode_duplicate(dev, dev_priv->panel_fixed_mode);
594 drm_mode_probed_add(connector, mode);
79e53945
JB
595
596 return 1;
597 }
598
599 return 0;
600}
601
1073af33
TB
602static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
603{
604 DRM_DEBUG_KMS("Skipping forced modeset for %s\n", id->ident);
605 return 1;
606}
607
608/* The GPU hangs up on these systems if modeset is performed on LID open */
609static const struct dmi_system_id intel_no_modeset_on_lid[] = {
610 {
611 .callback = intel_no_modeset_on_lid_dmi_callback,
612 .ident = "Toshiba Tecra A11",
613 .matches = {
614 DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
615 DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
616 },
617 },
618
619 { } /* terminating entry */
620};
621
c9354c85
LT
622/*
623 * Lid events. Note the use of 'modeset_on_lid':
624 * - we set it on lid close, and reset it on open
625 * - we use it as a "only once" bit (ie we ignore
626 * duplicate events where it was already properly
627 * set/reset)
628 * - the suspend/resume paths will also set it to
629 * zero, since they restore the mode ("lid open").
630 */
c1c7af60
JB
631static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
632 void *unused)
633{
634 struct drm_i915_private *dev_priv =
635 container_of(nb, struct drm_i915_private, lid_notifier);
636 struct drm_device *dev = dev_priv->dev;
a2565377 637 struct drm_connector *connector = dev_priv->int_lvds_connector;
c1c7af60 638
a2565377
ZY
639 /*
640 * check and update the status of LVDS connector after receiving
641 * the LID nofication event.
642 */
643 if (connector)
644 connector->status = connector->funcs->detect(connector);
1073af33
TB
645 /* Don't force modeset on machines where it causes a GPU lockup */
646 if (dmi_check_system(intel_no_modeset_on_lid))
647 return NOTIFY_OK;
c9354c85
LT
648 if (!acpi_lid_open()) {
649 dev_priv->modeset_on_lid = 1;
650 return NOTIFY_OK;
06891e27 651 }
c1c7af60 652
c9354c85
LT
653 if (!dev_priv->modeset_on_lid)
654 return NOTIFY_OK;
655
656 dev_priv->modeset_on_lid = 0;
657
658 mutex_lock(&dev->mode_config.mutex);
659 drm_helper_resume_force_mode(dev);
660 mutex_unlock(&dev->mode_config.mutex);
06324194 661
c1c7af60
JB
662 return NOTIFY_OK;
663}
664
79e53945
JB
665/**
666 * intel_lvds_destroy - unregister and free LVDS structures
667 * @connector: connector to free
668 *
669 * Unregister the DDC bus for this connector then free the driver private
670 * structure.
671 */
672static void intel_lvds_destroy(struct drm_connector *connector)
673{
c1c7af60 674 struct drm_device *dev = connector->dev;
c1c7af60 675 struct drm_i915_private *dev_priv = dev->dev_private;
79e53945 676
c1c7af60
JB
677 if (dev_priv->lid_notifier.notifier_call)
678 acpi_lid_notifier_unregister(&dev_priv->lid_notifier);
79e53945
JB
679 drm_sysfs_connector_remove(connector);
680 drm_connector_cleanup(connector);
681 kfree(connector);
682}
683
335041ed
JB
684static int intel_lvds_set_property(struct drm_connector *connector,
685 struct drm_property *property,
686 uint64_t value)
687{
3fbe18d6 688 struct drm_device *dev = connector->dev;
3fbe18d6
ZY
689
690 if (property == dev->mode_config.scaling_mode_property &&
691 connector->encoder) {
692 struct drm_crtc *crtc = connector->encoder->crtc;
bb8a3560
ZW
693 struct drm_encoder *encoder = connector->encoder;
694 struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
21d40d37 695 struct intel_lvds_priv *lvds_priv = intel_encoder->dev_priv;
bb8a3560 696
53bd8389
JB
697 if (value == DRM_MODE_SCALE_NONE) {
698 DRM_DEBUG_KMS("no scaling not supported\n");
3fbe18d6
ZY
699 return 0;
700 }
701 if (lvds_priv->fitting_mode == value) {
702 /* the LVDS scaling property is not changed */
703 return 0;
704 }
705 lvds_priv->fitting_mode = value;
706 if (crtc && crtc->enabled) {
707 /*
708 * If the CRTC is enabled, the display will be changed
709 * according to the new panel fitting mode.
710 */
711 drm_crtc_helper_set_mode(crtc, &crtc->mode,
712 crtc->x, crtc->y, crtc->fb);
713 }
714 }
715
335041ed
JB
716 return 0;
717}
718
79e53945
JB
719static const struct drm_encoder_helper_funcs intel_lvds_helper_funcs = {
720 .dpms = intel_lvds_dpms,
721 .mode_fixup = intel_lvds_mode_fixup,
722 .prepare = intel_lvds_prepare,
723 .mode_set = intel_lvds_mode_set,
724 .commit = intel_lvds_commit,
725};
726
727static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
728 .get_modes = intel_lvds_get_modes,
729 .mode_valid = intel_lvds_mode_valid,
bb8a3560 730 .best_encoder = intel_attached_encoder,
79e53945
JB
731};
732
733static const struct drm_connector_funcs intel_lvds_connector_funcs = {
c9fb15f6 734 .dpms = drm_helper_connector_dpms,
79e53945
JB
735 .detect = intel_lvds_detect,
736 .fill_modes = drm_helper_probe_single_connector_modes,
335041ed 737 .set_property = intel_lvds_set_property,
79e53945
JB
738 .destroy = intel_lvds_destroy,
739};
740
741
742static void intel_lvds_enc_destroy(struct drm_encoder *encoder)
743{
bb8a3560
ZW
744 struct intel_encoder *intel_encoder = enc_to_intel_encoder(encoder);
745
746 if (intel_encoder->ddc_bus)
747 intel_i2c_destroy(intel_encoder->ddc_bus);
79e53945 748 drm_encoder_cleanup(encoder);
bb8a3560 749 kfree(intel_encoder);
79e53945
JB
750}
751
752static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
753 .destroy = intel_lvds_enc_destroy,
754};
755
425d244c
JW
756static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
757{
8a4c47f3 758 DRM_DEBUG_KMS("Skipping LVDS initialization for %s\n", id->ident);
425d244c
JW
759 return 1;
760}
79e53945 761
425d244c 762/* These systems claim to have LVDS, but really don't */
93c05f22 763static const struct dmi_system_id intel_no_lvds[] = {
425d244c
JW
764 {
765 .callback = intel_no_lvds_dmi_callback,
766 .ident = "Apple Mac Mini (Core series)",
767 .matches = {
98acd46f 768 DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
425d244c
JW
769 DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
770 },
771 },
772 {
773 .callback = intel_no_lvds_dmi_callback,
774 .ident = "Apple Mac Mini (Core 2 series)",
775 .matches = {
98acd46f 776 DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
425d244c
JW
777 DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
778 },
779 },
780 {
781 .callback = intel_no_lvds_dmi_callback,
782 .ident = "MSI IM-945GSE-A",
783 .matches = {
784 DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
785 DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
786 },
787 },
788 {
789 .callback = intel_no_lvds_dmi_callback,
790 .ident = "Dell Studio Hybrid",
791 .matches = {
792 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
793 DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
794 },
795 },
70aa96ca
JW
796 {
797 .callback = intel_no_lvds_dmi_callback,
798 .ident = "AOpen Mini PC",
799 .matches = {
800 DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
801 DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
802 },
803 },
ed8c754b
TV
804 {
805 .callback = intel_no_lvds_dmi_callback,
806 .ident = "AOpen Mini PC MP915",
807 .matches = {
808 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
809 DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
810 },
811 },
fa0864b2
MC
812 {
813 .callback = intel_no_lvds_dmi_callback,
814 .ident = "Aopen i945GTt-VFA",
815 .matches = {
816 DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
817 },
818 },
9875557e
SB
819 {
820 .callback = intel_no_lvds_dmi_callback,
821 .ident = "Clientron U800",
822 .matches = {
823 DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
824 DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
825 },
826 },
425d244c
JW
827
828 { } /* terminating entry */
829};
79e53945 830
18f9ed12
ZY
831/**
832 * intel_find_lvds_downclock - find the reduced downclock for LVDS in EDID
833 * @dev: drm device
834 * @connector: LVDS connector
835 *
836 * Find the reduced downclock for LVDS in EDID.
837 */
838static void intel_find_lvds_downclock(struct drm_device *dev,
839 struct drm_connector *connector)
840{
841 struct drm_i915_private *dev_priv = dev->dev_private;
842 struct drm_display_mode *scan, *panel_fixed_mode;
843 int temp_downclock;
844
845 panel_fixed_mode = dev_priv->panel_fixed_mode;
846 temp_downclock = panel_fixed_mode->clock;
847
848 mutex_lock(&dev->mode_config.mutex);
849 list_for_each_entry(scan, &connector->probed_modes, head) {
850 /*
851 * If one mode has the same resolution with the fixed_panel
852 * mode while they have the different refresh rate, it means
853 * that the reduced downclock is found for the LVDS. In such
854 * case we can set the different FPx0/1 to dynamically select
855 * between low and high frequency.
856 */
857 if (scan->hdisplay == panel_fixed_mode->hdisplay &&
858 scan->hsync_start == panel_fixed_mode->hsync_start &&
859 scan->hsync_end == panel_fixed_mode->hsync_end &&
860 scan->htotal == panel_fixed_mode->htotal &&
861 scan->vdisplay == panel_fixed_mode->vdisplay &&
862 scan->vsync_start == panel_fixed_mode->vsync_start &&
863 scan->vsync_end == panel_fixed_mode->vsync_end &&
864 scan->vtotal == panel_fixed_mode->vtotal) {
865 if (scan->clock < temp_downclock) {
866 /*
867 * The downclock is already found. But we
868 * expect to find the lower downclock.
869 */
870 temp_downclock = scan->clock;
871 }
872 }
873 }
874 mutex_unlock(&dev->mode_config.mutex);
33814341
JB
875 if (temp_downclock < panel_fixed_mode->clock &&
876 i915_lvds_downclock) {
18f9ed12
ZY
877 /* We found the downclock for LVDS. */
878 dev_priv->lvds_downclock_avail = 1;
879 dev_priv->lvds_downclock = temp_downclock;
880 DRM_DEBUG_KMS("LVDS downclock is found in EDID. "
881 "Normal clock %dKhz, downclock %dKhz\n",
882 panel_fixed_mode->clock, temp_downclock);
883 }
884 return;
885}
886
7cf4f69d
ZY
887/*
888 * Enumerate the child dev array parsed from VBT to check whether
889 * the LVDS is present.
890 * If it is present, return 1.
891 * If it is not present, return false.
892 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
893 * Note: The addin_offset should also be checked for LVDS panel.
894 * Only when it is non-zero, it is assumed that it is present.
895 */
6e36595a 896static int lvds_is_present_in_vbt(struct drm_device *dev)
7cf4f69d
ZY
897{
898 struct drm_i915_private *dev_priv = dev->dev_private;
899 struct child_device_config *p_child;
900 int i, ret;
901
902 if (!dev_priv->child_dev_num)
903 return 1;
904
905 ret = 0;
906 for (i = 0; i < dev_priv->child_dev_num; i++) {
907 p_child = dev_priv->child_dev + i;
908 /*
909 * If the device type is not LFP, continue.
910 * If the device type is 0x22, it is also regarded as LFP.
911 */
912 if (p_child->device_type != DEVICE_TYPE_INT_LFP &&
913 p_child->device_type != DEVICE_TYPE_LFP)
914 continue;
915
916 /* The addin_offset should be checked. Only when it is
917 * non-zero, it is regarded as present.
918 */
919 if (p_child->addin_offset) {
920 ret = 1;
921 break;
922 }
923 }
924 return ret;
925}
926
79e53945
JB
927/**
928 * intel_lvds_init - setup LVDS connectors on this device
929 * @dev: drm device
930 *
931 * Create the connector, register the LVDS DDC bus, and try to figure out what
932 * modes we can display on the LVDS panel (if present).
933 */
934void intel_lvds_init(struct drm_device *dev)
935{
936 struct drm_i915_private *dev_priv = dev->dev_private;
21d40d37 937 struct intel_encoder *intel_encoder;
bb8a3560 938 struct intel_connector *intel_connector;
79e53945
JB
939 struct drm_connector *connector;
940 struct drm_encoder *encoder;
941 struct drm_display_mode *scan; /* *modes, *bios_mode; */
942 struct drm_crtc *crtc;
3fbe18d6 943 struct intel_lvds_priv *lvds_priv;
79e53945 944 u32 lvds;
541998a1 945 int pipe, gpio = GPIOC;
79e53945 946
425d244c
JW
947 /* Skip init on machines we know falsely report LVDS */
948 if (dmi_check_system(intel_no_lvds))
565dcd46 949 return;
565dcd46 950
11ba1592
MG
951 if (!lvds_is_present_in_vbt(dev)) {
952 DRM_DEBUG_KMS("LVDS is not present in VBT\n");
e99da35f 953 return;
38b3037e 954 }
e99da35f 955
c619eed4 956 if (HAS_PCH_SPLIT(dev)) {
541998a1
ZW
957 if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
958 return;
32f9d658 959 if (dev_priv->edp_support) {
28c97730 960 DRM_DEBUG_KMS("disable LVDS for eDP support\n");
32f9d658
ZW
961 return;
962 }
541998a1
ZW
963 gpio = PCH_GPIOC;
964 }
965
21d40d37 966 intel_encoder = kzalloc(sizeof(struct intel_encoder) +
3fbe18d6 967 sizeof(struct intel_lvds_priv), GFP_KERNEL);
21d40d37 968 if (!intel_encoder) {
79e53945
JB
969 return;
970 }
971
bb8a3560
ZW
972 intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
973 if (!intel_connector) {
974 kfree(intel_encoder);
975 return;
976 }
977
978 connector = &intel_connector->base;
21d40d37 979 encoder = &intel_encoder->enc;
bb8a3560 980 drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
79e53945
JB
981 DRM_MODE_CONNECTOR_LVDS);
982
21d40d37 983 drm_encoder_init(dev, &intel_encoder->enc, &intel_lvds_enc_funcs,
79e53945
JB
984 DRM_MODE_ENCODER_LVDS);
985
bb8a3560 986 drm_mode_connector_attach_encoder(&intel_connector->base, &intel_encoder->enc);
21d40d37 987 intel_encoder->type = INTEL_OUTPUT_LVDS;
79e53945 988
21d40d37
EA
989 intel_encoder->clone_mask = (1 << INTEL_LVDS_CLONE_BIT);
990 intel_encoder->crtc_mask = (1 << 1);
0f3ee801
AJ
991 if (IS_I965G(dev))
992 intel_encoder->crtc_mask |= (1 << 0);
79e53945
JB
993 drm_encoder_helper_add(encoder, &intel_lvds_helper_funcs);
994 drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
995 connector->display_info.subpixel_order = SubPixelHorizontalRGB;
996 connector->interlace_allowed = false;
997 connector->doublescan_allowed = false;
998
21d40d37
EA
999 lvds_priv = (struct intel_lvds_priv *)(intel_encoder + 1);
1000 intel_encoder->dev_priv = lvds_priv;
3fbe18d6
ZY
1001 /* create the scaling mode property */
1002 drm_mode_create_scaling_mode_property(dev);
1003 /*
1004 * the initial panel fitting mode will be FULL_SCREEN.
1005 */
79e53945 1006
bb8a3560 1007 drm_connector_attach_property(&intel_connector->base,
3fbe18d6 1008 dev->mode_config.scaling_mode_property,
dd1ea37d
JB
1009 DRM_MODE_SCALE_ASPECT);
1010 lvds_priv->fitting_mode = DRM_MODE_SCALE_ASPECT;
79e53945
JB
1011 /*
1012 * LVDS discovery:
1013 * 1) check for EDID on DDC
1014 * 2) check for VBT data
1015 * 3) check to see if LVDS is already on
1016 * if none of the above, no panel
1017 * 4) make sure lid is open
1018 * if closed, act like it's not there for now
1019 */
1020
1021 /* Set up the DDC bus. */
21d40d37
EA
1022 intel_encoder->ddc_bus = intel_i2c_create(dev, gpio, "LVDSDDC_C");
1023 if (!intel_encoder->ddc_bus) {
79e53945
JB
1024 dev_printk(KERN_ERR, &dev->pdev->dev, "DDC bus registration "
1025 "failed.\n");
1026 goto failed;
1027 }
1028
1029 /*
1030 * Attempt to get the fixed panel mode from DDC. Assume that the
1031 * preferred mode is the right one.
1032 */
bfac4d67
ZY
1033 dev_priv->lvds_edid_good = true;
1034
335af9a2 1035 if (!intel_ddc_get_modes(connector, intel_encoder->ddc_bus))
bfac4d67 1036 dev_priv->lvds_edid_good = false;
79e53945
JB
1037
1038 list_for_each_entry(scan, &connector->probed_modes, head) {
1039 mutex_lock(&dev->mode_config.mutex);
1040 if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1041 dev_priv->panel_fixed_mode =
1042 drm_mode_duplicate(dev, scan);
1043 mutex_unlock(&dev->mode_config.mutex);
18f9ed12 1044 intel_find_lvds_downclock(dev, connector);
565dcd46 1045 goto out;
79e53945
JB
1046 }
1047 mutex_unlock(&dev->mode_config.mutex);
1048 }
1049
1050 /* Failed to get EDID, what about VBT? */
88631706 1051 if (dev_priv->lfp_lvds_vbt_mode) {
79e53945
JB
1052 mutex_lock(&dev->mode_config.mutex);
1053 dev_priv->panel_fixed_mode =
88631706 1054 drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode);
79e53945 1055 mutex_unlock(&dev->mode_config.mutex);
e285f3cd
JB
1056 if (dev_priv->panel_fixed_mode) {
1057 dev_priv->panel_fixed_mode->type |=
1058 DRM_MODE_TYPE_PREFERRED;
e285f3cd
JB
1059 goto out;
1060 }
79e53945
JB
1061 }
1062
1063 /*
1064 * If we didn't get EDID, try checking if the panel is already turned
1065 * on. If so, assume that whatever is currently programmed is the
1066 * correct mode.
1067 */
541998a1 1068
f2b115e6 1069 /* Ironlake: FIXME if still fail, not try pipe mode now */
c619eed4 1070 if (HAS_PCH_SPLIT(dev))
541998a1
ZW
1071 goto failed;
1072
79e53945
JB
1073 lvds = I915_READ(LVDS);
1074 pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1075 crtc = intel_get_crtc_from_pipe(dev, pipe);
1076
1077 if (crtc && (lvds & LVDS_PORT_EN)) {
1078 dev_priv->panel_fixed_mode = intel_crtc_mode_get(dev, crtc);
1079 if (dev_priv->panel_fixed_mode) {
1080 dev_priv->panel_fixed_mode->type |=
1081 DRM_MODE_TYPE_PREFERRED;
565dcd46 1082 goto out;
79e53945
JB
1083 }
1084 }
1085
1086 /* If we still don't have a mode after all that, give up. */
1087 if (!dev_priv->panel_fixed_mode)
1088 goto failed;
1089
79e53945 1090out:
c619eed4 1091 if (HAS_PCH_SPLIT(dev)) {
541998a1
ZW
1092 u32 pwm;
1093 /* make sure PWM is enabled */
1094 pwm = I915_READ(BLC_PWM_CPU_CTL2);
1095 pwm |= (PWM_ENABLE | PWM_PIPE_B);
1096 I915_WRITE(BLC_PWM_CPU_CTL2, pwm);
1097
1098 pwm = I915_READ(BLC_PWM_PCH_CTL1);
1099 pwm |= PWM_PCH_ENABLE;
1100 I915_WRITE(BLC_PWM_PCH_CTL1, pwm);
1101 }
c1c7af60
JB
1102 dev_priv->lid_notifier.notifier_call = intel_lid_notify;
1103 if (acpi_lid_notifier_register(&dev_priv->lid_notifier)) {
28c97730 1104 DRM_DEBUG_KMS("lid notifier registration failed\n");
c1c7af60
JB
1105 dev_priv->lid_notifier.notifier_call = NULL;
1106 }
a2565377
ZY
1107 /* keep the LVDS connector */
1108 dev_priv->int_lvds_connector = connector;
79e53945
JB
1109 drm_sysfs_connector_add(connector);
1110 return;
1111
1112failed:
8a4c47f3 1113 DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
21d40d37
EA
1114 if (intel_encoder->ddc_bus)
1115 intel_i2c_destroy(intel_encoder->ddc_bus);
79e53945 1116 drm_connector_cleanup(connector);
1991bdfa 1117 drm_encoder_cleanup(encoder);
21d40d37 1118 kfree(intel_encoder);
bb8a3560 1119 kfree(intel_connector);
79e53945 1120}