]> bbs.cooldavid.org Git - net-next-2.6.git/commit
ocfs2: Make ocfs2_journal_dirty() void.
authorJoel Becker <joel.becker@oracle.com>
Fri, 19 Mar 2010 21:13:52 +0000 (14:13 -0700)
committerJoel Becker <joel.becker@oracle.com>
Thu, 6 May 2010 01:17:29 +0000 (18:17 -0700)
commitec20cec7a351584ca6c70ead012e73d61f9a8e04
tree39af308ae07ab168313bb50ced1bb1ae7ef7e6a3
parentb4414eea0e7b9c134262c801a87e338bf675962c
ocfs2: Make ocfs2_journal_dirty() void.

jbd[2]_journal_dirty_metadata() only returns 0.  It's been returning 0
since before the kernel moved to git.  There is no point in checking
this error.

ocfs2_journal_dirty() has been faithfully returning the status since the
beginning.  All over ocfs2, we have blocks of code checking this can't
fail status.  In the past few years, we've tried to avoid adding these
checks, because they are pointless.  But anyone who looks at our code
assumes they are needed.

Finally, ocfs2_journal_dirty() is made a void function.  All error
checking is removed from other files.  We'll BUG_ON() the status of
jbd2_journal_dirty_metadata() just in case they change it someday.  They
won't.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
14 files changed:
fs/ocfs2/alloc.c
fs/ocfs2/dir.c
fs/ocfs2/file.c
fs/ocfs2/inode.c
fs/ocfs2/journal.c
fs/ocfs2/journal.h
fs/ocfs2/localalloc.c
fs/ocfs2/namei.c
fs/ocfs2/quota_global.c
fs/ocfs2/quota_local.c
fs/ocfs2/refcounttree.c
fs/ocfs2/resize.c
fs/ocfs2/suballoc.c
fs/ocfs2/xattr.c