]> bbs.cooldavid.org Git - net-next-2.6.git/commit
drivers/char/n_gsm.c: add missing spin_unlock_irqrestore
authorJulia Lawall <julia@diku.dk>
Wed, 11 Aug 2010 01:03:12 +0000 (18:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Aug 2010 15:59:20 +0000 (08:59 -0700)
commite73790a57abc1320b3c3a94da43ae24359687d7c
tree10aafbf75687e9e0b07f2b892f208f2ab44db2c9
parent7bb671e3d053226f870c333f701924986b39ee7f
drivers/char/n_gsm.c: add missing spin_unlock_irqrestore

Add a spin_unlock_irqrestore missing on the error path.  Converting the
return to break leads to the spin_unlock_irqrestore at the end of the
function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1;
@@

* spin_lock_irqsave(E1,...);
  <+... when != E1
  if (...) {
    ... when != E1
*   return ...;
  }
  ...+>
* spin_unlock_irqrestore(E1,...);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/n_gsm.c