]> bbs.cooldavid.org Git - net-next-2.6.git/commit
IB/ucm: Use memdup_user()
authorJulia Lawall <julia@diku.dk>
Sat, 22 May 2010 08:21:27 +0000 (10:21 +0200)
committerRoland Dreier <rolandd@cisco.com>
Wed, 26 May 2010 04:10:57 +0000 (21:10 -0700)
commite642df6a0be93316c0a886766057c4cc510c123d
tree368e4ce5b02668228c9684efd918c59fb2e6e5ee
parentec96e2fe954c23a54bfdf2673437a39e193a1822
IB/ucm: Use memdup_user()

Use memdup_user when user data is immediately copied into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
drivers/infiniband/core/ucm.c