]> bbs.cooldavid.org Git - net-next-2.6.git/commit
net/rose: Use GFP_ATOMIC
authorJulia Lawall <julia@diku.dk>
Fri, 30 Jul 2010 23:56:39 +0000 (23:56 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Aug 2010 07:32:12 +0000 (00:32 -0700)
commite2e0c7c9ddbe6b79fe647aca5eea3a405d38ada4
tree2caf75dd8e741a2df698a1491d15414e11598960
parent0fc48c37ff3969dde71a43fa7c8f176d4bd90a3e
net/rose: Use GFP_ATOMIC

The other calls to kmalloc in the same function use GFP_ATOMIC, and indeed
two locks are held within the body of the function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ identifier f; @@

*f(...,GFP_ATOMIC,...)
... when != spin_unlock(...)
    when != read_unlock(...)
    when != write_unlock(...)
    when != read_unlock_irq(...)
    when != write_unlock_irq(...)
    when != read_unlock_irqrestore(...)
    when != write_unlock_irqrestore(...)
    when != spin_unlock_irq(...)
    when != spin_unlock_irqrestore(...)
*f(...,GFP_KERNEL,...)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rose/rose_route.c