]> bbs.cooldavid.org Git - net-next-2.6.git/commit
hwmon: (k8temp) Adjust confusing if indentation
authorJulia Lawall <julia@diku.dk>
Sat, 14 Aug 2010 19:08:47 +0000 (21:08 +0200)
committerJean Delvare <khali@linux-fr.org>
Sat, 14 Aug 2010 19:08:47 +0000 (21:08 +0200)
commitdf149d02ea8ee49cd14c6609cc7ef980d62dce80
tree98d2257db87600c7a8fad5fc112db4e5b69aa6ec
parent92fa5bd9a946b6e7aab6764e7312e4e3d9bed295
hwmon: (k8temp) Adjust confusing if indentation

Move the if(err) statement after the if into the if branch indicated by its
indentation.  The preceding if(err) test implies that err cannot be nonzero
unless the if branch is taken.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces5@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
 cocci.print_main("branch",p4)
 cocci.print_secs("after",p5)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/hwmon/k8temp.c