]> bbs.cooldavid.org Git - net-next-2.6.git/commit
r8169: fix checksum broken
authorShan Wei <shanwei@cn.fujitsu.com>
Fri, 12 Nov 2010 00:15:25 +0000 (00:15 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Nov 2010 20:21:14 +0000 (12:21 -0800)
commitd5d3ebe3be5c5123f2d444e186717f45284151e2
tree54789aa8b662301a4483d27dcb86a0201aa7137b
parent218854af84038d828a32f061858b1902ed2beec6
r8169: fix checksum broken

If r8196 received packets with invalid sctp/igmp(not tcp, udp) checksum, r8196 set skb->ip_summed
wit CHECKSUM_UNNECESSARY. This cause that upper protocol don't check checksum field.

I am not family with r8196 driver. I try to guess the meaning of RxProtoIP and IPFail.
RxProtoIP stands for received IPv4 packet that upper protocol is not tcp and udp.
!(opts1 & IPFail) is true means that driver correctly to check checksum in IPv4 header.

If it's right, I think we should not set ip_summed wit CHECKSUM_UNNECESSARY for my sctp packets
with invalid checksum.

If it's not right, please tell me.

Signed-off-by: Shan Wei <shanwei@cn.fujitsu.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/r8169.c