]> bbs.cooldavid.org Git - net-next-2.6.git/commit
pkt_sched: gen_kill_estimator() rcu fixes
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 9 Jun 2010 02:09:23 +0000 (02:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 12 Jun 2010 01:37:08 +0000 (18:37 -0700)
commitc7de2cf053420d63bac85133469c965d4b1083e1
treeb56f7c96d01e25f79fe1f9b7e5305265e92214d9
parentcbd6890c5987cd7115147e1dd2c10d729afabb08
pkt_sched: gen_kill_estimator() rcu fixes

gen_kill_estimator() API is incomplete or not well documented, since
caller should make sure an RCU grace period is respected before
freeing stats_lock.

This was partially addressed in commit 5d944c640b4
(gen_estimator: deadlock fix), but same problem exist for all
gen_kill_estimator() users, if lock they use is not already RCU
protected.

A code review shows xt_RATEEST.c, act_api.c, act_police.c have this
problem. Other are ok because they use qdisc lock, already RCU
protected.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/act_api.h
include/net/netfilter/xt_rateest.h
net/core/gen_estimator.c
net/netfilter/xt_RATEEST.c
net/sched/act_api.c
net/sched/act_police.c