]> bbs.cooldavid.org Git - net-next-2.6.git/commit
V4L/DVB: ivtv: Fix race condition for queued udma transfers
authorIan Armstrong <ian@iarmst.demon.co.uk>
Tue, 22 Dec 2009 01:59:26 +0000 (22:59 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Fri, 26 Feb 2010 18:10:41 +0000 (15:10 -0300)
commitb6e436b263b35476da4be06e0719cb1d5c8f8eed
treeb6055dce972162efde4d3d2748ca7096ee1d68d4
parent0726681a7080cef6a9fd414894690fac16418772
V4L/DVB: ivtv: Fix race condition for queued udma transfers

There are several DMA related interrupts which wake up the dma_waitq. The udma
routines use this queue while they wait for their transfer to complete. When
woken, the udma routine will check the IVTV_F_I_UDMA_PENDING & IVTV_F_I_UDMA
flags to see if the transfer is still queued or has finished. However, a small
window exists between the IVTV_F_I_UDMA_PENDING flag being cleared and the
IVTV_F_I_UDMA flag being set. Given that the completion of an unrelated DMA
transfer may wake up the udma routine, it's possible for this check to fail
and the udma routine will start unmapping pages when the transfer has only
just started. The result of this is unpredictable.

This fix simply delays the clearing of the IVTV_F_I_UDMA_PENDING flag until
after IVTV_F_I_UDMA has been set.

Signed-off-by: Ian Armstrong <ian@iarmst.demon.co.uk>
Signed-off-by: Andy Walls <awalls@radix.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/ivtv/ivtv-irq.c
drivers/media/video/ivtv/ivtv-udma.c