]> bbs.cooldavid.org Git - net-next-2.6.git/commit
firewire: nosy: misc cleanups
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 27 Jul 2010 08:28:30 +0000 (10:28 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 27 Jul 2010 09:04:10 +0000 (11:04 +0200)
commitb5e47729043c9224b21ab3dc7c63e8a38dbb4923
tree2acf6aa0f441c3a6b8812c8c5eb3b97a74f98056
parent286468210d83ce0ca1e37e346ed9f4457a161650
firewire: nosy: misc cleanups

Extend copyright note to 2007, c.f. Kristian's git log.

Includes:
  - replace some <asm/*.h> by <linux/*.h>
  - add required indirectly included <linux/spinlock.h>
  - order alphabetically

Coding style related changes:
  - change to utf8
  - normalize whitespace
  - normalize comment style
  - remove usages of __FUNCTION__
  - remove an unnecessary cast from void *

Const and static declarations:
  - driver_name is not const in pci_driver.name, drop const qualifier
  - driver_name can be taken from KBUILD_MODNAME
  - the global variable minors[] can and should be static
  - constify struct file_operations instance

Data types:
  - Remove unused struct member struct packet.code.  struct packet is
    only used for driver-internal bookkeeping; it does not appear on the
    wire or in DMA programs or the userspace ABI.  Hence the unused
    member .code can be removed without worries.

Preprocessor macros:
  - unroll a preprocessor macro that containd a return
  - use list_for_each_entry

Printk:
  - add missing terminating \n in some format strings

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/nosy-user.h
drivers/firewire/nosy.c
drivers/firewire/nosy.h