]> bbs.cooldavid.org Git - net-next-2.6.git/commit
mtd/m25p80: retlen is never NULL
authorDan Carpenter <error27@gmail.com>
Thu, 12 Aug 2010 07:53:52 +0000 (09:53 +0200)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 12 Aug 2010 11:26:22 +0000 (12:26 +0100)
commitb06cd21e2f0f75686f95afa5b71219b1408f5458
treee1a316a5e671b0ba4e483b615b866b5468e93f45
parentd2b5bbef2198f82280441ab1ea7f634d615d913b
mtd/m25p80: retlen is never NULL

This is just a cleanup, it doesn't fix any bugs.

These functions all check retlen inconsistently and it generates a
warning in Smatch (http://smatch.sf.net).  If retlen were ever NULL it
would cause an oops and the code has been this way since 2006 so someone
would have complained.  Also I looked at other places that implemented
the mtd read and write functions and they dereference retlen without
checking.

I removed the checks.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/devices/m25p80.c