]> bbs.cooldavid.org Git - net-next-2.6.git/commit
git://bbs.cooldavid.org / net-next-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 27f7ad5) | patch
ALSA: rawmidi: fix the get next midi device ioctl
authorDan Carpenter <error27@gmail.com>
Wed, 8 Sep 2010 22:11:41 +0000 (00:11 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 9 Sep 2010 07:05:21 +0000 (09:05 +0200)
commita7a13d0676335a7dc9dd72264cca02606e43aaba
tree5c9a4c47f735174d13d3ab6d64c8c191d70d0968tree | snapshot (tar.bz2 tar.gz zip)
parent27f7ad53829f79e799a253285318bff79ece15bdcommit | diff
ALSA: rawmidi: fix the get next midi device ioctl

If we pass in a device which is higher than SNDRV_RAWMIDI_DEVICES then
the "next device" should be -1.  This function just returns device + 1.

But the main thing is that "device + 1" can lead to a (harmless) integer
overflow and that annoys static analysis tools.

[fix the case for device == SNDRV_RAWMIDI_DEVICE by tiwai]

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/rawmidi.c diff | blob | blame | history
Clone of davem's net-next-2.6 tree