]> bbs.cooldavid.org Git - net-next-2.6.git/commit
ath5k: avoid and warn on potential infinite loop
authorBob Copeland <me@bobcopeland.com>
Wed, 20 May 2009 03:37:31 +0000 (23:37 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 20 May 2009 18:46:32 +0000 (14:46 -0400)
commit9c8b3eddc0666255851942df8ec72cd91d22f280
treebeef68ff428b4414073142b34910010411b6aaac
parent61405e97788b1bc4e7c5be5b4ec04a73fc11bac2
ath5k: avoid and warn on potential infinite loop

If we are trying to interpolate a curve with slope == 0, the return
value will always be the y-coordinate.  In this code we are looping
until we reach a minimum y-coordinate on a line, which in the 0-slope
case can never happen, thus the loop never terminates.

The PCDAC steps come from the EEPROM and should never be equal, but
we should gracefully handle that case, so warn and bail out.

Reported-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath5k/phy.c