]> bbs.cooldavid.org Git - net-next-2.6.git/commit
drm: fix fallouts from slow-work -> wq conversion
authorTejun Heo <tj@kernel.org>
Mon, 9 Aug 2010 10:01:27 +0000 (12:01 +0200)
committerTejun Heo <tj@kernel.org>
Mon, 9 Aug 2010 10:18:44 +0000 (12:18 +0200)
commit9a919c46dfa48a9c1f465174609b90253eb8ffc1
tree99fce0fb5b98d59ee1843a8d949cf8261e5efbff
parentf6500947a9cbb81cfa07ff344f16955d9c6ebe61
drm: fix fallouts from slow-work -> wq conversion

Commit 991ea75c (drm: use workqueue instead of slow-work), which made
drm to use wq instead of slow-work, didn't account for the return
value difference between delayed_slow_work_enqueue() and
queue_delayed_work().  The former returns 0 on success and -errno on
failures while the latter never fails and only uses the return value
to indicate whether the work was already pending or not.

This misconversion triggered spurious error messages.  Remove the now
unnecessary return value check and error message.

Markus: caught another incorrect conversion in drm_kms_helper_poll_enable()

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
drivers/gpu/drm/drm_crtc_helper.c