]> bbs.cooldavid.org Git - net-next-2.6.git/commit
RDS: Rewrite rds_send_drop_to() for clarity
authorAndy Grover <andy.grover@oracle.com>
Sat, 20 Feb 2010 02:01:41 +0000 (18:01 -0800)
committerAndy Grover <andy.grover@oracle.com>
Thu, 9 Sep 2010 01:07:32 +0000 (18:07 -0700)
commit7c82eaf00ec7d460932be9314b29997006b799b6
treedd1e46ceb37ab4d5b6688d04805240eb9fcb7fbe
parent35b52c70534cb7193b218ec12efe6bc595312097
RDS: Rewrite rds_send_drop_to() for clarity

This function has been the source of numerous bugs; it's just
too complicated. Simplified to nest spinlocks cleanly within
the second loop body, and kick out early if there are no
rms to drop.

This will be a little slower because conn lock is grabbed for
each entry instead of "caching" the lock across rms, but this
should be entirely irrelevant to fastpath performance.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
net/rds/send.c