]> bbs.cooldavid.org Git - net-next-2.6.git/commit
regulator: max1586 - fix a memory leak in max1586_pmic_remove()
authorAxel Lin <axel.lin@gmail.com>
Fri, 6 Aug 2010 05:33:15 +0000 (13:33 +0800)
committerLiam Girdwood <lrg@slimlogic.co.uk>
Wed, 11 Aug 2010 10:38:02 +0000 (11:38 +0100)
commit7c4c25e4bc37672e68d1c480a81fcb0efe6d2006
tree210ce0ab1d7f6753d05bb4d36b2a8270ad6c95ad
parentc4604e49c1a5832a58789a22eba7ca982933e1be
regulator: max1586 - fix a memory leak in max1586_pmic_remove()

In max1586_pmic_probe(), we allocate memory for max1586.
In max1586_pmic_remove(), current implementation only free rdev
which is a member of struct max1586_data.
Thus, there is a small memory leak when we unload the module.

This patch fixes the memory leak by passing max1586 to i2c clientdata,
and properly kfree(max1586) in max1586_pmic_remove().

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/max1586.c