]> bbs.cooldavid.org Git - net-next-2.6.git/commit
Btrfs: prohibit a operation of changing acl's mask when noacl mount option used
authorShi Weihua <shiwh@cn.fujitsu.com>
Tue, 18 May 2010 00:51:54 +0000 (00:51 +0000)
committerChris Mason <chris.mason@oracle.com>
Fri, 11 Jun 2010 19:57:38 +0000 (15:57 -0400)
commit731e3d1b4348a96d53de6c084774424dedc64a3b
tree1f0a95894fa9a8e226ee2d74c64805c373b1b927
parent2f26afba46f0ebf155cf9be746496a0304a5b7cf
Btrfs: prohibit a operation of changing acl's mask when noacl mount option used

when used Posix File System Test Suite(pjd-fstest) to test btrfs,
some cases about setfacl failed when noacl mount option used.
I simplified used commands in pjd-fstest, and the following steps
can reproduce it.
------------------------
# cd btrfs-part/
# mkdir aaa
# setfacl -m m::rw aaa    <- successed, but not expected by pjd-fstest.
------------------------
I checked ext3, a warning message occured, like as:
  setfacl: aaa/: Operation not supported
Certainly, it's expected by pjd-fstest.

So, i compared acl.c of btrfs and ext3. Based on that, a patch created.
Fortunately, it works.

Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
fs/btrfs/acl.c