]> bbs.cooldavid.org Git - net-next-2.6.git/commit
i2c-pca: Fix waitforcompletion() return value
authorYegor Yefremov <yegor_sub1@visionsystems.de>
Thu, 30 Sep 2010 12:14:22 +0000 (14:14 +0200)
committerJean Delvare <khali@endymion.delvare>
Thu, 30 Sep 2010 12:14:22 +0000 (14:14 +0200)
commit6abb930af064fb1cf4177d32e2c7bfb89eee0fe5
treee9e44b8926d94f31a78fdb3dd3c5e789427feb67
parent753419f59e10d7181e43f0b9cc5beff43ef3f7a4
i2c-pca: Fix waitforcompletion() return value

ret is still -1, if during the polling read_byte() returns at once
with I2C_PCA_CON_SI set. So ret > 0 would lead *_waitforcompletion()
to return 0, in spite of the proper behavior.

The routine was rewritten, so that ret has always a proper value,
before returning.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: stable@kernel.org
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/busses/i2c-pca-isa.c
drivers/i2c/busses/i2c-pca-platform.c