]> bbs.cooldavid.org Git - net-next-2.6.git/commit
fs: remove incorrect I_NEW warnings
authorNick Piggin <npiggin@suse.de>
Tue, 2 Jun 2009 10:07:47 +0000 (12:07 +0200)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 12 Jun 2009 01:36:10 +0000 (21:36 -0400)
commit545b9fd3d737afc0bb5203b1e79194a471605acd
tree9b9a39b55c3145a225c5256ff2be3b07a1ee43bb
parent8688b8635266cf98f00c6b0350ea2dbe7c42c321
fs: remove incorrect I_NEW warnings

Some filesystems can call in to sync an inode that is still in the
I_NEW state (eg. ext family, when mounted with -osync). This is OK
because the filesystem has sole access to the new inode, so it can
modify i_state without races (because no other thread should be
modifying it, by definition of I_NEW). Ie. a false positive, so
remove the warnings.

The races are described here 7ef0d7377cb287e08f3ae94cebc919448e1f5dff,
which is also where the warnings were introduced.

Reported-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/fs-writeback.c