]> bbs.cooldavid.org Git - net-next-2.6.git/commit
Un-inline the core-dump helper functions
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 14 Oct 2010 21:32:06 +0000 (14:32 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 14 Oct 2010 21:32:06 +0000 (14:32 -0700)
commit3aa0ce825ade0cf5506e32ccf51d01fc8d22a9cf
tree77ca43d663b62922a743de3729a8b8b47eafb887
parentae42d8d44195a614c78a636683fe65ed31744cbd
Un-inline the core-dump helper functions

Tony Luck reports that the addition of the access_ok() check in commit
0eead9ab41da ("Don't dump task struct in a.out core-dumps") broke the
ia64 compile due to missing the necessary header file includes.

Rather than add yet another include (<asm/unistd.h>) to make everything
happy, just uninline the silly core dump helper functions and move the
bodies to fs/exec.c where they make a lot more sense.

dump_seek() in particular was too big to be an inline function anyway,
and none of them are in any way performance-critical.  And we really
don't need to mess up our include file headers more than they already
are.

Reported-and-tested-by: Tony Luck <tony.luck@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/exec.c
include/linux/coredump.h