]> bbs.cooldavid.org Git - net-next-2.6.git/commit
V4L/DVB: VIDEO: ivtvfb, remove unneeded NULL test
authorJiri Slaby <jslaby@suse.cz>
Mon, 19 Jul 2010 17:39:34 +0000 (14:39 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 2 Aug 2010 19:42:57 +0000 (16:42 -0300)
commit37b58bfe4bb3df303aa9d7f1ccdbfc477b42c5e2
treef82417c863f6e4268bc56a12bffd46ab4739adba
parent6efb870a115ac223ab578bc76699ba8591250568
V4L/DVB: VIDEO: ivtvfb, remove unneeded NULL test

Stanse found that in ivtvfb_callback_cleanup and ivtvfb_callback_init
there are unneeded tests for itv being NULL. But itv is initialized
as container_of with non-zero offset in those functions, so it is
never NULL (even if v4l2_dev is). This was found because itv is
dereferenced earlier than the test.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reviewed-by: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/ivtv/ivtvfb.c