]> bbs.cooldavid.org Git - net-next-2.6.git/commit
Staging: dream: camera: Use memdup_user
authorJulia Lawall <julia@diku.dk>
Sat, 22 May 2010 08:27:02 +0000 (10:27 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 18 Jun 2010 22:16:21 +0000 (15:16 -0700)
commit37a18632b00f0d1627556c532f719ad5a08b369f
tree04854902e3719d5e38dcb535bc1cd3eb2e02c2f0
parent7c0ace54887872ebd99fefdfe85d273295a09426
Staging: dream: camera: Use memdup_user

Use memdup_user when user data is immediately copied into the
allocated region.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@

-  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+  to = memdup_user(from,size);
   if (
-      to==NULL
+      IS_ERR(to)
                 || ...) {
   <+... when != goto l1;
-  -ENOMEM
+  PTR_ERR(to)
   ...+>
   }
-  if (copy_from_user(to, from, size) != 0) {
-    <+... when != goto l2;
-    -EFAULT
-    ...+>
-  }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/dream/camera/msm_vfe8x.c