]> bbs.cooldavid.org Git - net-next-2.6.git/commit
git://bbs.cooldavid.org / net-next-2.6.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 339db11) | patch
ppp: potential NULL dereference in ppp_mp_explode()
authorDan Carpenter <error27@gmail.com>
Fri, 10 Sep 2010 01:58:10 +0000 (01:58 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Sep 2010 19:44:11 +0000 (12:44 -0700)
commit3429769bc67c7a48b3c01b2452b32171b3450202
tree9664314000e1e0ae06ecb29423ca30cfd42f0c8etree | snapshot (tar.bz2 tar.gz zip)
parent339db11b219f36cf7da61b390992d95bb6b7ba2ecommit | diff
ppp: potential NULL dereference in ppp_mp_explode()

Smatch complains because we check whether "pch->chan" is NULL and then
dereference it unconditionally on the next line.  Partly the reason this
bug was introduced is because code was too complicated.  I've simplified
it a little.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ppp_generic.c diff | blob | blame | history
Clone of davem's net-next-2.6 tree