]> bbs.cooldavid.org Git - net-next-2.6.git/commit
Don't dump task struct in a.out core-dumps
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 14 Oct 2010 17:57:40 +0000 (10:57 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 14 Oct 2010 17:57:40 +0000 (10:57 -0700)
commit0eead9ab41da33644ae2c97c57ad03da636a0422
tree757516bc7caa70a10101264edc3eac7d44c11ce8
parent53eeb64e808971207350386121f4bab12fa2f45f
Don't dump task struct in a.out core-dumps

akiphie points out that a.out core-dumps have that odd task struct
dumping that was never used and was never really a good idea (it goes
back into the mists of history, probably the original core-dumping
code).  Just remove it.

Also do the access_ok() check on dump_write().  It probably doesn't
matter (since normal filesystems all seem to do it anyway), but he
points out that it's normally done by the VFS layer, so ...

[ I suspect that we should possibly do "vfs_write()" instead of
  calling ->write directly.  That also does the whole fsnotify and write
  statistics thing, which may or may not be a good idea. ]

And just to be anal, do this all for the x86-64 32-bit a.out emulation
code too, even though it's not enabled (and won't currently even
compile)

Reported-by: akiphie <akiphie@lavabit.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/ia32/ia32_aout.c
fs/binfmt_aout.c
include/linux/coredump.h