]> bbs.cooldavid.org Git - net-next-2.6.git/commit
Fix VMI relocation processing logic error
authorZachary Amsden <zach@vmware.com>
Fri, 13 Apr 2007 02:28:46 +0000 (19:28 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Sun, 15 Apr 2007 04:48:36 +0000 (21:48 -0700)
commit0492c371372ef5eac3a952509391dea231b0de89
treed4fb6c32d113b97451d4631057fd29cb9d3d5c60
parent5a6d41b32a17ca902ef50fdfa170d7f23264bad5
Fix VMI relocation processing logic error

Fix logic error in VMI relocation processing.  NOPs would always cause
a BUG_ON to fire because the != RELOCATION_NONE in the first if clause
precluding the == VMI_RELOCATION_NOP in the second clause.  Make these
direct equality tests and just warn for unsupported relocation types
(which should never happen), falling back to native in that case.

Thanks to Anthony Liguori for noting this!

Signed-off-by: Zachary Amsden <zach@vmware.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/i386/kernel/vmi.c