X-Git-Url: http://bbs.cooldavid.org/git/?p=jme.git;a=blobdiff_plain;f=jme.c;h=f34bcb96e883a9488c490e3ba45a79bf2dd49d7b;hp=100a662208229db9a636e87f9bfd0d7918f4c00a;hb=79ce639c9d90abc4d30d749af2d135c20a8c419e;hpb=4330c2f2eeef6b8d690560d2666425fa0362109c

diff --git a/jme.c b/jme.c
index 100a662..f34bcb9 100644
--- a/jme.c
+++ b/jme.c
@@ -4,6 +4,8 @@
  * Copyright 2008 JMicron Technology Corporation
  * http://www.jmicron.com/
  *
+ * Author: Guo-Fu Tseng <cooldavid@cooldavid.org>
+ *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License.
@@ -19,48 +21,44 @@
  *
  */
 
+/*
+ * Note:
+ * 	Backdoor for changing "FIFO Threshold for processing next packet"
+ * 	   Using:
+ *		ethtool -C eth1 adaptive-rx on adaptive-tx on \
+ *		rx-usecs 250 rx-frames-low N
+ *	   N := 16 | 32 | 64 | 128
+ */
+
 /*
  * Timeline before release:
- * 	Stage 1: Basic Performance / Capbility fine tune.
- * 	-  Implement PCC -- Dynamic adjustment.
- * 	-  Use NAPI instead of rx_tasklet?
- * 		PCC Support Both Packet Counter and Timeout Interrupt for
- * 		receive and transmit complete, does NAPI really needed?
- * 		I'll add NAPI support anyway..
- * 		For CPU busy and heavy network loading system..
- * 	-  Try setting 64bit DMA with pci_set[_consistent]_dma_mask
- * 	   and set netdev feature flag.
- * 	   (Need to modity transmit descriptor filling policy as well)
- *      -  Use pci_map_page instead of pci_map_single for HIGHMEM support
- *
- * 	Stage 2: Error handling.
- * 	-  Wathch dog
- * 	-  Transmit timeout
- *
- * 	Stage 3: Basic offloading support.
- *      -  Implement scatter-gather offloading.
- *         A system page per RX (buffer|descriptor)?
- *	   Handle fraged sk_buff to TX descriptors.
- * 	-  Implement tx/rx ipv6/ip/tcp/udp checksum offloading
- *
  * 	Stage 4: Basic feature support.
+ * 	0.7:
  * 	-  Implement Power Managemt related functions.
- * 	-  Implement Jumboframe.
- * 	-  Implement MSI.
  *
  * 	Stage 5: Advanced offloading support.
+ * 	0.8:
  * 	-  Implement VLAN offloading.
+ * 	0.9:
+ *	-  Implement scatter-gather offloading.
+ *	   Use pci_map_page on scattered sk_buff for HIGHMEM support
  * 	-  Implement TCP Segement offloading.
+ * 		Due to TX FIFO size, we should turn off tso when mtu > 1500.
  *
  * 	Stage 6: CPU Load balancing.
+ * 	1.0:
  * 	-  Implement MSI-X.
  * 	   Along with multiple RX queue, for CPU load balancing.
- * 	-  Use Multiple TX Queue for Multiple CPU Transmit
- * 	   Simultaneously Without Lock.
  *
  * 	Stage 7:
  * 	-  Cleanup/re-orginize code, performence tuneing(alignment etc...).
  * 	-  Test and Release 1.0
+ *
+ * 	Non-Critical:
+ *  	-  Use NAPI instead of rx_tasklet?
+ * 		PCC Support Both Packet Counter and Timeout Interrupt for
+ * 		receive and transmit complete, does NAPI really needed?
+ *	-  Decode register dump for ethtool.
  */
 
 #include <linux/version.h>
@@ -73,73 +71,104 @@
 #include <linux/mii.h>
 #include <linux/crc32.h>
 #include <linux/delay.h>
+#include <linux/in.h>
+#include <linux/ip.h>
+#include <linux/ipv6.h>
+#include <linux/tcp.h>
+#include <linux/udp.h>
 #include "jme.h"
 
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,21)
-static struct net_device_stats *jme_get_stats(struct net_device *netdev)
+static struct net_device_stats *
+jme_get_stats(struct net_device *netdev)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
 	return &jme->stats;
 }
 #endif
 
-static int jme_mdio_read(struct net_device *netdev, int phy, int reg)
+static int
+jme_mdio_read(struct net_device *netdev, int phy, int reg)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
 	int i, val;
 
         jwrite32(jme, JME_SMI, SMI_OP_REQ |
-				 smi_phy_addr(phy) |
-				 smi_reg_addr(reg));
+				smi_phy_addr(phy) |
+				smi_reg_addr(reg));
 
 	wmb();
-        for (i = JME_PHY_TIMEOUT; i > 0; --i) {
-                udelay(1);
-                if (((val = jread32(jme, JME_SMI)) & SMI_OP_REQ) == 0)
-                        break;
+        for (i = JME_PHY_TIMEOUT ; i > 0 ; --i) {
+		udelay(1);
+		if (((val = jread32(jme, JME_SMI)) & SMI_OP_REQ) == 0)
+			break;
         }
 
         if (i == 0) {
-                jeprintk(netdev->name, "phy read timeout : %d\n", reg);
-                return (0);
+		jeprintk(netdev->name, "phy read timeout : %d\n", reg);
+		return 0;
         }
 
-        return ((val & SMI_DATA_MASK) >> SMI_DATA_SHIFT);
+	return ((val & SMI_DATA_MASK) >> SMI_DATA_SHIFT);
 }
 
-static void jme_mdio_write(struct net_device *netdev, int phy, int reg, int val)
+static void
+jme_mdio_write(struct net_device *netdev,
+				int phy, int reg, int val)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
 	int i;
 
-        jwrite32(jme, JME_SMI, SMI_OP_WRITE | SMI_OP_REQ |
-            ((val << SMI_DATA_SHIFT) & SMI_DATA_MASK) |
-            smi_phy_addr(phy) | smi_reg_addr(reg));
+	jwrite32(jme, JME_SMI, SMI_OP_WRITE | SMI_OP_REQ |
+		((val << SMI_DATA_SHIFT) & SMI_DATA_MASK) |
+		smi_phy_addr(phy) | smi_reg_addr(reg));
 
 	wmb();
-        for (i = JME_PHY_TIMEOUT; i > 0; --i)
-	{
-                udelay(1);
-                if (((val = jread32(jme, JME_SMI)) & SMI_OP_REQ) == 0)
-                        break;
-        }
+	for (i = JME_PHY_TIMEOUT ; i > 0 ; --i) {
+		udelay(1);
+		if (((val = jread32(jme, JME_SMI)) & SMI_OP_REQ) == 0)
+			break;
+	}
 
-        if (i == 0)
-                jeprintk(netdev->name, "phy write timeout : %d\n", reg);
+	if (i == 0)
+		jeprintk(netdev->name, "phy write timeout : %d\n", reg);
 
-        return;
+	return;
 }
 
-static void jme_reset_mac_processor(struct jme_adapter *jme)
+__always_inline static void
+jme_reset_phy_processor(struct jme_adapter *jme)
 {
 	__u32 val;
 
-	val = jread32(jme, JME_GHC);
-	val |= GHC_SWRST;
-	jwrite32(jme, JME_GHC, val);
+	jme_mdio_write(jme->dev,
+			jme->mii_if.phy_id,
+			MII_ADVERTISE, ADVERTISE_ALL |
+			ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);
+
+	jme_mdio_write(jme->dev,
+			jme->mii_if.phy_id,
+			MII_CTRL1000,
+			ADVERTISE_1000FULL | ADVERTISE_1000HALF);
+
+	val = jme_mdio_read(jme->dev,
+				jme->mii_if.phy_id,
+				MII_BMCR);
+
+	jme_mdio_write(jme->dev,
+			jme->mii_if.phy_id,
+			MII_BMCR, val | BMCR_RESET);
+
+	return;
+}
+
+
+__always_inline static void
+jme_reset_mac_processor(struct jme_adapter *jme)
+{
+	jwrite32(jme, JME_GHC, jme->reg_ghc | GHC_SWRST);
 	udelay(2);
-	val &= ~GHC_SWRST;
-	jwrite32(jme, JME_GHC, val);
+	jwrite32(jme, JME_GHC, jme->reg_ghc);
 	jwrite32(jme, JME_RXMCHT_LO, 0x00000000);
 	jwrite32(jme, JME_RXMCHT_HI, 0x00000000);
 	jwrite32(jme, JME_WFODP, 0);
@@ -148,13 +177,15 @@ static void jme_reset_mac_processor(struct jme_adapter *jme)
 	jwrite32(jme, JME_GPREG1, 0);
 }
 
-__always_inline static void jme_clear_pm(struct jme_adapter *jme)
+__always_inline static void
+jme_clear_pm(struct jme_adapter *jme)
 {
 	jwrite32(jme, JME_PMCS, 0xFFFF0000);
 	pci_set_power_state(jme->pdev, PCI_D0);
 }
 
-static int jme_reload_eeprom(struct jme_adapter *jme)
+static int
+jme_reload_eeprom(struct jme_adapter *jme)
 {
 	__u32 val;
 	int i;
@@ -183,16 +214,18 @@ static int jme_reload_eeprom(struct jme_adapter *jme)
 	}
 	else
 		return -EIO;
-	
+
 	return 0;
 }
 
-__always_inline static void jme_load_macaddr(struct net_device *netdev)
+static void
+jme_load_macaddr(struct net_device *netdev)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
 	unsigned char macaddr[6];
 	__u32 val;
 
+	spin_lock(&jme->macaddr_lock);
 	val = jread32(jme, JME_RXUMA_LO);
 	macaddr[0] = (val >>  0) & 0xFF;
 	macaddr[1] = (val >>  8) & 0xFF;
@@ -202,17 +235,59 @@ __always_inline static void jme_load_macaddr(struct net_device *netdev)
 	macaddr[4] = (val >>  0) & 0xFF;
 	macaddr[5] = (val >>  8) & 0xFF;
         memcpy(netdev->dev_addr, macaddr, 6);
+	spin_unlock(&jme->macaddr_lock);
+}
+
+__always_inline static void
+jme_set_rx_pcc(struct jme_adapter *jme, int p)
+{
+	switch(p) {
+	case PCC_P1:
+		jwrite32(jme, JME_PCCRX0,
+			((PCC_P1_TO << PCCRXTO_SHIFT) & PCCRXTO_MASK) |
+			((PCC_P1_CNT << PCCRX_SHIFT) & PCCRX_MASK));
+		break;
+	case PCC_P2:
+		jwrite32(jme, JME_PCCRX0,
+			((PCC_P2_TO << PCCRXTO_SHIFT) & PCCRXTO_MASK) |
+			((PCC_P2_CNT << PCCRX_SHIFT) & PCCRX_MASK));
+		break;
+	case PCC_P3:
+		jwrite32(jme, JME_PCCRX0,
+			((PCC_P3_TO << PCCRXTO_SHIFT) & PCCRXTO_MASK) |
+			((PCC_P3_CNT << PCCRX_SHIFT) & PCCRX_MASK));
+		break;
+	default:
+		break;
+	}
+
+	dprintk(jme->dev->name, "Switched to PCC_P%d\n", p);
 }
 
-__always_inline static void jme_start_irq(struct jme_adapter *jme)
+static void
+jme_start_irq(struct jme_adapter *jme)
 {
+	register struct dynpcc_info *dpi = &(jme->dpi);
+
+	jme_set_rx_pcc(jme, PCC_P1);
+	dpi->cur		= PCC_P1;
+	dpi->attempt		= PCC_P1;
+	dpi->cnt		= 0;
+
+	jwrite32(jme, JME_PCCTX,
+			((PCC_TX_TO << PCCTXTO_SHIFT) & PCCTXTO_MASK) |
+			((PCC_TX_CNT << PCCTX_SHIFT) & PCCTX_MASK) |
+			PCCTXQ0_EN
+		);
+
 	/*
 	 * Enable Interrupts
 	 */
 	jwrite32(jme, JME_IENS, INTR_ENABLE);
 }
 
-__always_inline static void jme_stop_irq(struct jme_adapter *jme)
+__always_inline static void
+jme_stop_irq(struct jme_adapter *jme)
 {
 	/*
 	 * Disable Interrupts
@@ -221,37 +296,82 @@ __always_inline static void jme_stop_irq(struct jme_adapter *jme)
 }
 
 
-__always_inline static void jme_enable_shadow(struct jme_adapter *jme)
+__always_inline static void
+jme_enable_shadow(struct jme_adapter *jme)
 {
 	jwrite32(jme,
 		 JME_SHBA_LO,
 		 ((__u32)jme->shadow_dma & ~((__u32)0x1F)) | SHBA_POSTEN);
 }
 
-__always_inline static void jme_disable_shadow(struct jme_adapter *jme)
+__always_inline static void
+jme_disable_shadow(struct jme_adapter *jme)
 {
 	jwrite32(jme, JME_SHBA_LO, 0x0);
 }
 
-static void jme_check_link(struct net_device *netdev)
+static int
+jme_check_link(struct net_device *netdev, int testonly)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
-	__u32 phylink, ghc, cnt = JME_AUTONEG_TIMEOUT;
-	char linkmsg[32];
+	__u32 phylink, ghc, cnt = JME_SPDRSV_TIMEOUT, bmcr;
+	char linkmsg[64];
+	int rc = 0;
 
 	phylink = jread32(jme, JME_PHY_LINK);
 
         if (phylink & PHY_LINK_UP) {
-		/*
-		 * Keep polling for autoneg complete
-		 */
-		while(!(phylink & PHY_LINK_AUTONEG_COMPLETE) && --cnt > 0) {
-			mdelay(1);
-			phylink = jread32(jme, JME_PHY_LINK);
+		if(!(phylink & PHY_LINK_AUTONEG_COMPLETE)) {
+			/*
+			 * If we did not enable AN
+			 * Speed/Duplex Info should be obtained from SMI
+			 */
+			phylink = PHY_LINK_UP;
+
+			bmcr = jme_mdio_read(jme->dev,
+						jme->mii_if.phy_id,
+						MII_BMCR);
+
+
+			phylink |= ((bmcr & BMCR_SPEED1000) &&
+					(bmcr & BMCR_SPEED100) == 0) ?
+					PHY_LINK_SPEED_1000M :
+					(bmcr & BMCR_SPEED100) ?
+					PHY_LINK_SPEED_100M :
+					PHY_LINK_SPEED_10M;
+
+			phylink |= (bmcr & BMCR_FULLDPLX) ?
+					 PHY_LINK_DUPLEX : 0;
+
+			strcpy(linkmsg, "Forced: ");
+		}
+		else {
+			/*
+			 * Keep polling for speed/duplex resolve complete
+			 */
+			while(!(phylink & PHY_LINK_SPEEDDPU_RESOLVED) &&
+				--cnt) {
+
+				udelay(1);
+				phylink = jread32(jme, JME_PHY_LINK);
+
+			}
+
+			if(!cnt)
+				jeprintk(netdev->name,
+					"Waiting speed resolve timeout.\n");
+
+			strcpy(linkmsg, "ANed: ");
+		}
+
+		if(jme->phylink == phylink) {
+			rc = 1;
+			goto out;
 		}
+		if(testonly)
+			goto out;
 
-		if(!cnt)
-			jeprintk(netdev->name, "Waiting autoneg timeout.\n");
+		jme->phylink = phylink;
 
 		switch(phylink & PHY_LINK_SPEED_MASK) {
 			case PHY_LINK_SPEED_10M:
@@ -271,96 +391,190 @@ static void jme_check_link(struct net_device *netdev)
 				break;
 		}
                 ghc |= (phylink & PHY_LINK_DUPLEX) ? GHC_DPX : 0;
-		jwrite32(jme, JME_GHC, ghc);
+
 		strcat(linkmsg, (phylink &PHY_LINK_DUPLEX) ?
-					"Full-Duplex" :
-					"Half-Duplex");
+					"Full-Duplex, " :
+					"Half-Duplex, ");
+
+		if(phylink & PHY_LINK_MDI_STAT)
+			strcat(linkmsg, "MDI-X");
+		else
+			strcat(linkmsg, "MDI");
 
 		if(phylink & PHY_LINK_DUPLEX)
 			jwrite32(jme, JME_TXMCS, TXMCS_DEFAULT);
-		else
+		else {
 			jwrite32(jme, JME_TXMCS, TXMCS_DEFAULT |
-						   TXMCS_BACKOFF |
-						   TXMCS_CARRIERSENSE |
-						   TXMCS_COLLISION);
+						TXMCS_BACKOFF |
+						TXMCS_CARRIERSENSE |
+						TXMCS_COLLISION);
+			jwrite32(jme, JME_TXTRHD, TXTRHD_TXPEN |
+				((0x2000 << TXTRHD_TXP_SHIFT) & TXTRHD_TXP) |
+				TXTRHD_TXREN |
+				((8 << TXTRHD_TXRL_SHIFT) & TXTRHD_TXRL));
+		}
+
+		jme->reg_ghc = ghc;
+		jwrite32(jme, JME_GHC, ghc);
 
 		jprintk(netdev->name, "Link is up at %s.\n", linkmsg);
                 netif_carrier_on(netdev);
 	}
         else {
+		if(testonly)
+			goto out;
+
 		jprintk(netdev->name, "Link is down.\n");
+		jme->phylink = 0;
                 netif_carrier_off(netdev);
 	}
+
+out:
+	return rc;
 }
 
-static void jme_link_change_tasklet(unsigned long arg)
+
+static int
+jme_alloc_txdesc(struct jme_adapter *jme,
+			int nr_alloc)
 {
-	struct jme_adapter *jme = (struct jme_adapter*)arg;
-	jme_check_link(jme->dev);
+	struct jme_ring *txring = jme->txring;
+	int idx;
+
+	idx = txring->next_to_use;
+
+	if(unlikely(atomic_read(&txring->nr_free) < nr_alloc))
+		return -1;
+
+	atomic_sub(nr_alloc, &txring->nr_free);
+
+	if((txring->next_to_use += nr_alloc) >= RING_DESC_NR)
+		txring->next_to_use -= RING_DESC_NR;
+
+	return idx;
+}
+
+static void
+jme_tx_csum(struct sk_buff *skb, unsigned mtu, __u8 *flags)
+{
+	if(skb->ip_summed == CHECKSUM_PARTIAL) {
+		__u8 ip_proto;
+
+		switch (skb->protocol) {
+		case __constant_htons(ETH_P_IP):
+			ip_proto = ip_hdr(skb)->protocol;
+			break;
+		case __constant_htons(ETH_P_IPV6):
+			ip_proto = ipv6_hdr(skb)->nexthdr;
+			break;
+		default:
+			ip_proto = 0;
+			break;
+		}
+
+
+		switch(ip_proto) {
+		case IPPROTO_TCP:
+			*flags |= TXFLAG_TCPCS;
+			break;
+		case IPPROTO_UDP:
+			*flags |= TXFLAG_UDPCS;
+			break;
+		default:
+			jeprintk("jme", "Error upper layer protocol.\n");
+			break;
+		}
+	}
 }
 
-static void jme_set_new_txdesc(struct jme_adapter *jme,
-			       int i, struct sk_buff *skb)
+static int
+jme_set_new_txdesc(struct jme_adapter *jme,
+			struct sk_buff *skb)
 {
 	struct jme_ring *txring = jme->txring;
-	register struct TxDesc* txdesc = txring->desc;
-	struct jme_buffer_info *txbi = txring->bufinf;
+	volatile struct txdesc *txdesc = txring->desc, *ctxdesc;
+	struct jme_buffer_info *txbi = txring->bufinf, *ctxbi;
 	dma_addr_t dmaaddr;
+	int i, idx, nr_desc;
+	__u8 flags;
+
+	nr_desc = 2;
+	idx = jme_alloc_txdesc(jme, nr_desc);
 
-	txdesc += i;
-	txbi += i;
+	if(unlikely(idx<0))
+		return NETDEV_TX_BUSY;
 
-	dmaaddr = pci_map_single(jme->pdev,
-				 skb->data,
-				 skb->len,
-				 PCI_DMA_TODEVICE);
+	for(i = 1 ; i < nr_desc  ; ++i) {
+		ctxdesc = txdesc + ((idx + i) & (RING_DESC_NR-1));
+		ctxbi = txbi + ((idx + i) & (RING_DESC_NR-1));
 
-	pci_dma_sync_single_for_device(jme->pdev,
-				       dmaaddr,
-				       skb->len,
-				       PCI_DMA_TODEVICE);
-	
-	txdesc->dw[0] = 0;
-	txdesc->dw[1] = 0;
-	txdesc->dw[2] = 0;
-	txdesc->desc1.bufaddr = cpu_to_le32(dmaaddr);
-	txdesc->desc1.datalen = cpu_to_le16(skb->len);
-	txdesc->desc1.pktsize = cpu_to_le16(skb->len);
+		dmaaddr = pci_map_single(jme->pdev,
+					 skb->data,
+					 skb->len,
+					 PCI_DMA_TODEVICE);
+
+		pci_dma_sync_single_for_device(jme->pdev,
+					       dmaaddr,
+					       skb->len,
+					       PCI_DMA_TODEVICE);
+
+		ctxdesc->dw[0] = 0;
+		ctxdesc->dw[1] = 0;
+		ctxdesc->desc2.flags	= TXFLAG_OWN;
+		if(jme->dev->features & NETIF_F_HIGHDMA)
+			ctxdesc->desc2.flags |= TXFLAG_64BIT;
+		ctxdesc->desc2.datalen	= cpu_to_le16(skb->len);
+		ctxdesc->desc2.bufaddrh	= cpu_to_le32((__u64)dmaaddr >> 32);
+		ctxdesc->desc2.bufaddrl	= cpu_to_le32(
+						(__u64)dmaaddr & 0xFFFFFFFFUL);
+
+		ctxbi->mapping = dmaaddr;
+		ctxbi->len = skb->len;
+	}
+
+	ctxdesc = txdesc + idx;
+	ctxbi = txbi + idx;
+
+	ctxdesc->dw[0] = 0;
+	ctxdesc->dw[1] = 0;
+	ctxdesc->dw[2] = 0;
+	ctxdesc->dw[3] = 0;
+	ctxdesc->desc1.pktsize = cpu_to_le16(skb->len);
 	/*
 	 * Set OWN bit at final.
-	 * When kernel transmit faster than NIC last packet sent,
-	 * and NIC trying to send this descriptor before we tell
+	 * When kernel transmit faster than NIC.
+	 * And NIC trying to send this descriptor before we tell
 	 * it to start sending this TX queue.
 	 * Other fields are already filled correctly.
 	 */
 	wmb();
-	txdesc->desc1.flags = TXFLAG_OWN | TXFLAG_INT;
-	txbi->skb = skb;
-	txbi->mapping = dmaaddr;
-	txbi->len = skb->len;
-
-#ifdef TX_QUEUE_DEBUG
-	dprintk(jme->dev->name, "TX Ring Buf Address(%08x,%08x,%d).\n",
-		dmaaddr,
-		(txdesc->all[12] <<  0) |
-		(txdesc->all[13] <<  8) |
-		(txdesc->all[14] << 16) |
-		(txdesc->all[15] << 24),
-		(txdesc->all[4]  <<  0) |
-		(txdesc->all[5]  <<  8));
-#endif
+	flags = TXFLAG_OWN | TXFLAG_INT; 
+	jme_tx_csum(skb, jme->dev->mtu, &flags);
+	ctxdesc->desc1.flags = flags;
+	/*
+	 * Set tx buffer info after telling NIC to send
+	 * For better tx_clean timing
+	 */
+	wmb();
+	ctxbi->nr_desc = nr_desc;
+	ctxbi->skb = skb;
 
+	tx_dbg(jme->dev->name, "Xmit: %d+%d\n", idx, nr_desc);
+
+	return 0;
 }
 
 
-static int jme_setup_tx_resources(struct jme_adapter *jme)
+static int
+jme_setup_tx_resources(struct jme_adapter *jme)
 {
 	struct jme_ring *txring = &(jme->txring[0]);
 
 	txring->alloc = dma_alloc_coherent(&(jme->pdev->dev),
 					   TX_RING_ALLOC_SIZE,
-					   &(txring->dmaalloc), 
-					   GFP_KERNEL);
+					   &(txring->dmaalloc),
+					   GFP_ATOMIC);
+
 	if(!txring->alloc) {
 		txring->desc = NULL;
 		txring->dmaalloc = 0;
@@ -371,61 +585,61 @@ static int jme_setup_tx_resources(struct jme_adapter *jme)
 	/*
 	 * 16 Bytes align
 	 */
-	txring->desc		= (void*)ALIGN((unsigned long)(txring->alloc), RING_DESC_ALIGN);
+	txring->desc		= (void*)ALIGN((unsigned long)(txring->alloc),
+						RING_DESC_ALIGN);
 	txring->dma		= ALIGN(txring->dmaalloc, RING_DESC_ALIGN);
 	txring->next_to_use	= 0;
 	txring->next_to_clean	= 0;
-
-#ifdef TX_QUEUE_DEBUG
-	dprintk(jme->dev->name, "TX Ring Base Address(%08x,%08x).\n",
-		(__u32)txring->desc,
-		txring->dma);
-#endif
+	atomic_set(&txring->nr_free, RING_DESC_NR);
 
 	/*
 	 * Initiallize Transmit Descriptors
 	 */
 	memset(txring->alloc, 0, TX_RING_ALLOC_SIZE);
-	memset(txring->bufinf, 0, sizeof(struct jme_buffer_info) * RING_DESC_NR);
+	memset(txring->bufinf, 0,
+		sizeof(struct jme_buffer_info) * RING_DESC_NR);
 
 	return 0;
 }
 
-static void jme_free_tx_resources(struct jme_adapter *jme)
+static void
+jme_free_tx_resources(struct jme_adapter *jme)
 {
 	int i;
 	struct jme_ring *txring = &(jme->txring[0]);
 	struct jme_buffer_info *txbi = txring->bufinf;
 
 	if(txring->alloc) {
-		for(i=0;i<RING_DESC_NR;++i) {
+		for(i = 0 ; i < RING_DESC_NR ; ++i) {
 			txbi = txring->bufinf + i;
 			if(txbi->skb) {
 				dev_kfree_skb(txbi->skb);
 				txbi->skb = NULL;
-				txbi->mapping = 0;
-				txbi->len = 0;
 			}
+			txbi->mapping	= 0;
+			txbi->len	= 0;
+			txbi->nr_desc	= 0;
 		}
 
 		dma_free_coherent(&(jme->pdev->dev),
 				  TX_RING_ALLOC_SIZE,
 				  txring->alloc,
 				  txring->dmaalloc);
-		txring->alloc    = NULL;
-		txring->desc     = NULL;
-		txring->dmaalloc = 0;
-		txring->dma      = 0;
+
+		txring->alloc		= NULL;
+		txring->desc		= NULL;
+		txring->dmaalloc	= 0;
+		txring->dma		= 0;
 	}
-	txring->next_to_use   = 0;
-	txring->next_to_clean = 0;
+	txring->next_to_use	= 0;
+	txring->next_to_clean	= 0;
+	atomic_set(&txring->nr_free, 0);
 
 }
 
-__always_inline static void jme_enable_tx_engine(struct jme_adapter *jme)
+__always_inline static void
+jme_enable_tx_engine(struct jme_adapter *jme)
 {
-	__u8 mrrs;
-
 	/*
 	 * Select Queue 0
 	 */
@@ -434,30 +648,15 @@ __always_inline static void jme_enable_tx_engine(struct jme_adapter *jme)
 	/*
 	 * Setup TX Queue 0 DMA Bass Address
 	 */
-	jwrite32(jme, JME_TXDBA, jme->txring[0].dma);
-	jwrite32(jme, JME_TXNDA, jme->txring[0].dma);
+	jwrite32(jme, JME_TXDBA_LO, (__u64)jme->txring[0].dma & 0xFFFFFFFFUL);
+	jwrite32(jme, JME_TXDBA_HI, (__u64)(jme->txring[0].dma) >> 32);
+	jwrite32(jme, JME_TXNDA, (__u64)jme->txring[0].dma & 0xFFFFFFFFUL);
 
 	/*
 	 * Setup TX Descptor Count
 	 */
 	jwrite32(jme, JME_TXQDC, RING_DESC_NR);
 
-	/*
-	 * Get Max Read Req Size from PCI Config Space
-	 */
-	pci_read_config_byte(jme->pdev, PCI_CONF_DCSR_MRRS, &mrrs);
-	switch(mrrs) {
-		case MRRS_128B:
-			jme->reg_txcs = TXCS_DEFAULT | TXCS_DMASIZE_128B;
-			break;
-		case MRRS_256B:
-			jme->reg_txcs = TXCS_DEFAULT | TXCS_DMASIZE_256B;
-			break;
-		default:
-			jme->reg_txcs = TXCS_DEFAULT | TXCS_DMASIZE_512B;
-			break;
-	};
-
 	/*
 	 * Enable TX Engine
 	 */
@@ -468,7 +667,8 @@ __always_inline static void jme_enable_tx_engine(struct jme_adapter *jme)
 
 }
 
-__always_inline static void jme_disable_tx_engine(struct jme_adapter *jme)
+__always_inline static void
+jme_disable_tx_engine(struct jme_adapter *jme)
 {
 	int i;
 	__u32 val;
@@ -476,85 +676,83 @@ __always_inline static void jme_disable_tx_engine(struct jme_adapter *jme)
 	/*
 	 * Disable TX Engine
 	 */
-	jwrite32(jme, JME_TXCS, jme->reg_txcs);
+	jwrite32(jme, JME_TXCS, jme->reg_txcs | TXCS_SELECT_QUEUE0);
 
 	val = jread32(jme, JME_TXCS);
 	for(i = JME_TX_DISABLE_TIMEOUT ; (val & TXCS_ENABLE) && i > 0 ; --i)
 	{
-		udelay(1);
+		mdelay(1);
 		val = jread32(jme, JME_TXCS);
 	}
 
-	if(!i)
+	if(!i) {
 		jeprintk(jme->dev->name, "Disable TX engine timeout.\n");
+		jme_reset_mac_processor(jme);
+	}
 
 
 }
 
-static void jme_set_clean_rxdesc(struct jme_adapter *jme, int i)
+static void
+jme_set_clean_rxdesc(struct jme_adapter *jme, int i)
 {
 	struct jme_ring *rxring = jme->rxring;
-	register struct RxDesc* rxdesc = rxring->desc;
+	register volatile struct rxdesc* rxdesc = rxring->desc;
 	struct jme_buffer_info *rxbi = rxring->bufinf;
 	rxdesc += i;
 	rxbi += i;
 
 	rxdesc->dw[0] = 0;
 	rxdesc->dw[1] = 0;
-	rxdesc->desc1.bufaddrh = cpu_to_le32(((__u64)rxbi->mapping) >> 32);
-	rxdesc->desc1.bufaddrl = cpu_to_le32(rxbi->mapping);
-	rxdesc->desc1.datalen = cpu_to_le16(RX_BUF_SIZE);
+	rxdesc->desc1.bufaddrh	= cpu_to_le32((__u64)rxbi->mapping >> 32);
+	rxdesc->desc1.bufaddrl	= cpu_to_le32(
+					(__u64)rxbi->mapping & 0xFFFFFFFFUL);
+	rxdesc->desc1.datalen	= cpu_to_le16(rxbi->len);
+	if(jme->dev->features & NETIF_F_HIGHDMA)
+		rxdesc->desc1.flags = RXFLAG_64BIT;
 	wmb();
-	rxdesc->desc1.flags = RXFLAG_OWN | RXFLAG_INT;
-
-#ifdef RX_QUEUE_DEBUG
-	dprintk(jme->dev->name, "RX Ring Buf Address(%08x,%08x,%d).\n",
-		rxbi->mapping,
-		(rxdesc->all[12] <<  0) |
-		(rxdesc->all[13] <<  8) |
-		(rxdesc->all[14] << 16) |
-		(rxdesc->all[15] << 24),
-		(rxdesc->all[4]  <<  0) |
-		(rxdesc->all[5]  <<  8));
-#endif
-
+	rxdesc->desc1.flags	|= RXFLAG_OWN | RXFLAG_INT;
 }
 
-static int jme_make_new_rx_buf(struct jme_adapter *jme, int i)
+static int
+jme_make_new_rx_buf(struct jme_adapter *jme, int i)
 {
 	struct jme_ring *rxring = &(jme->rxring[0]);
 	struct jme_buffer_info *rxbi = rxring->bufinf;
 	unsigned long offset;
 	struct sk_buff* skb;
 
-	skb = netdev_alloc_skb(jme->dev, RX_BUF_ALLOC_SIZE);
+	skb = netdev_alloc_skb(jme->dev,
+		jme->dev->mtu + RX_EXTRA_LEN);
 	if(unlikely(!skb))
 		return -ENOMEM;
-	if(unlikely(skb_shinfo(skb)->nr_frags)) {
-		dprintk(jme->dev->name, "Allocated skb fragged(%d).\n", skb_shinfo(skb)->nr_frags);
+
+	if(unlikely(skb_is_nonlinear(skb))) {
+		dprintk(jme->dev->name,
+			"Allocated skb fragged(%d).\n",
+			skb_shinfo(skb)->nr_frags);
 		dev_kfree_skb(skb);
 		return -ENOMEM;
 	}
 
-
-	if(unlikely(
-		offset = 
-		(unsigned long)(skb->data)
-		& (unsigned long)(RX_BUF_DMA_ALIGN - 1))) {
+	if(unlikely(offset =
+			(unsigned long)(skb->data)
+			& ((unsigned long)RX_BUF_DMA_ALIGN - 1)))
 		skb_reserve(skb, RX_BUF_DMA_ALIGN - offset);
-	}
 
 	rxbi += i;
 	rxbi->skb = skb;
+	rxbi->len = skb_tailroom(skb);
 	rxbi->mapping = pci_map_single(jme->pdev,
 				       skb->data,
-				       RX_BUF_SIZE,
+				       rxbi->len,
 				       PCI_DMA_FROMDEVICE);
 
 	return 0;
 }
 
-static void jme_free_rx_buf(struct jme_adapter *jme, int i)
+static void
+jme_free_rx_buf(struct jme_adapter *jme, int i)
 {
 	struct jme_ring *rxring = &(jme->rxring[0]);
 	struct jme_buffer_info *rxbi = rxring->bufinf;
@@ -563,23 +761,48 @@ static void jme_free_rx_buf(struct jme_adapter *jme, int i)
 	if(rxbi->skb) {
 		pci_unmap_single(jme->pdev,
 				 rxbi->mapping,
-				 RX_BUF_SIZE,
+				 rxbi->len,
 				 PCI_DMA_FROMDEVICE);
 		dev_kfree_skb(rxbi->skb);
 		rxbi->skb = NULL;
 		rxbi->mapping = 0;
+		rxbi->len = 0;
+	}
+}
+
+static void
+jme_free_rx_resources(struct jme_adapter *jme)
+{
+	int i;
+	struct jme_ring *rxring = &(jme->rxring[0]);
+
+	if(rxring->alloc) {
+		for(i = 0 ; i < RING_DESC_NR ; ++i)
+			jme_free_rx_buf(jme, i);
+
+		dma_free_coherent(&(jme->pdev->dev),
+				  RX_RING_ALLOC_SIZE,
+				  rxring->alloc,
+				  rxring->dmaalloc);
+		rxring->alloc    = NULL;
+		rxring->desc     = NULL;
+		rxring->dmaalloc = 0;
+		rxring->dma      = 0;
 	}
+	rxring->next_to_use   = 0;
+	rxring->next_to_clean = 0;
 }
 
-static int jme_setup_rx_resources(struct jme_adapter *jme)
+static int
+jme_setup_rx_resources(struct jme_adapter *jme)
 {
 	int i;
 	struct jme_ring *rxring = &(jme->rxring[0]);
 
 	rxring->alloc = dma_alloc_coherent(&(jme->pdev->dev),
 					   RX_RING_ALLOC_SIZE,
-					   &(rxring->dmaalloc), 
-					   GFP_KERNEL);
+					   &(rxring->dmaalloc),
+					   GFP_ATOMIC);
 	if(!rxring->alloc) {
 		rxring->desc = NULL;
 		rxring->dmaalloc = 0;
@@ -590,84 +813,43 @@ static int jme_setup_rx_resources(struct jme_adapter *jme)
 	/*
 	 * 16 Bytes align
 	 */
-	rxring->desc		= (void*)ALIGN((unsigned long)(rxring->alloc), RING_DESC_ALIGN);
+	rxring->desc		= (void*)ALIGN((unsigned long)(rxring->alloc),
+						RING_DESC_ALIGN);
 	rxring->dma		= ALIGN(rxring->dmaalloc, RING_DESC_ALIGN);
 	rxring->next_to_use	= 0;
 	rxring->next_to_clean	= 0;
 
-#ifdef RX_QUEUE_DEBUG
-	dprintk(jme->dev->name, "RX Ring Base Address(%08x,%08x).\n",
-		(__u32)rxring->desc,
-		rxring->dma);
-#endif
-
 	/*
 	 * Initiallize Receive Descriptors
 	 */
 	for(i = 0 ; i < RING_DESC_NR ; ++i) {
-		if(unlikely(jme_make_new_rx_buf(jme, i)))
-			break;
+		if(unlikely(jme_make_new_rx_buf(jme, i))) {
+			jme_free_rx_resources(jme);
+			return -ENOMEM;
+		}
 
 		jme_set_clean_rxdesc(jme, i);
 	}
 
-	/*
-	 * Cleanup allocated memories when error
-	 */
-	if(i != RING_DESC_NR) {
-		for(--i ; i >= 0 ; --i)
-			jme_free_rx_buf(jme, i);
-
-		dma_free_coherent(&(jme->pdev->dev),
-				  RX_RING_ALLOC_SIZE,
-				  rxring->alloc,
-				  rxring->dmaalloc);
-		rxring->alloc    = NULL;
-		rxring->desc     = NULL;
-		rxring->dmaalloc = 0;
-		rxring->dma      = 0;
-		return -ENOMEM;
-	}
-
 	return 0;
 }
 
-static void jme_free_rx_resources(struct jme_adapter *jme)
-{
-	int i;
-	struct jme_ring *rxring = &(jme->rxring[0]);
-
-	if(rxring->alloc) {
-		for(i = 0 ; i < RING_DESC_NR ; ++i)
-			jme_free_rx_buf(jme, i);
-
-		dma_free_coherent(&(jme->pdev->dev),
-				  RX_RING_ALLOC_SIZE,
-				  rxring->alloc,
-				  rxring->dmaalloc);
-		rxring->alloc    = NULL;
-		rxring->desc     = NULL;
-		rxring->dmaalloc = 0;
-		rxring->dma      = 0;
-	}
-	rxring->next_to_use   = 0;
-	rxring->next_to_clean = 0;
-}
-
-__always_inline static void jme_enable_rx_engine(struct jme_adapter *jme)
+__always_inline static void
+jme_enable_rx_engine(struct jme_adapter *jme)
 {
 	/*
 	 * Setup RX DMA Bass Address
 	 */
-	jwrite32(jme, JME_RXDBA, jme->rxring[0].dma);
-	jwrite32(jme, JME_RXNDA, jme->rxring[0].dma);
+	jwrite32(jme, JME_RXDBA_LO, (__u64)jme->rxring[0].dma & 0xFFFFFFFFUL);
+	jwrite32(jme, JME_RXDBA_HI, (__u64)(jme->rxring[0].dma) >> 32);
+	jwrite32(jme, JME_RXNDA, (__u64)jme->rxring[0].dma & 0xFFFFFFFFUL);
 
 	/*
 	 * Setup RX Descptor Count
 	 */
 	jwrite32(jme, JME_RXQDC, RING_DESC_NR);
 
-	/* 
+	/*
 	 * Setup Unicast Filter
 	 */
 	jme_set_multi(jme->dev);
@@ -675,27 +857,28 @@ __always_inline static void jme_enable_rx_engine(struct jme_adapter *jme)
 	/*
 	 * Enable RX Engine
 	 */
-
 	wmb();
-	jwrite32(jme, JME_RXCS, RXCS_DEFAULT |
+	jwrite32(jme, JME_RXCS, jme->reg_rxcs |
 				RXCS_QUEUESEL_Q0 |
 				RXCS_ENABLE |
 				RXCS_QST);
 }
 
-__always_inline static void jme_restart_rx_engine(struct jme_adapter *jme)
+__always_inline static void
+jme_restart_rx_engine(struct jme_adapter *jme)
 {
 	/*
-	 * Enable RX Engine
+	 * Start RX Engine
 	 */
-	jwrite32(jme, JME_RXCS, RXCS_DEFAULT |
+	jwrite32(jme, JME_RXCS, jme->reg_rxcs |
 				RXCS_QUEUESEL_Q0 |
 				RXCS_ENABLE |
 				RXCS_QST);
 }
 
 
-__always_inline static void jme_disable_rx_engine(struct jme_adapter *jme)
+__always_inline static void
+jme_disable_rx_engine(struct jme_adapter *jme)
 {
 	int i;
 	__u32 val;
@@ -710,7 +893,7 @@ __always_inline static void jme_disable_rx_engine(struct jme_adapter *jme)
 	val = jread32(jme, JME_RXCS);
 	for(i = JME_RX_DISABLE_TIMEOUT ; (val & RXCS_ENABLE) && i > 0 ; --i)
 	{
-		udelay(1);
+		mdelay(100);
 		val = jread32(jme, JME_RXCS);
 	}
 
@@ -719,341 +902,620 @@ __always_inline static void jme_disable_rx_engine(struct jme_adapter *jme)
 
 }
 
-static void jme_tx_clean_tasklet(unsigned long arg)
+static void
+jme_alloc_and_feed_skb(struct jme_adapter *jme, int idx, int summed)
 {
-	struct jme_adapter *jme = (struct jme_adapter*)arg;
-	struct jme_ring *txring = &(jme->txring[0]);
-	struct TxDesc *txdesc = txring->desc;
-	struct jme_buffer_info *txbi = txring->bufinf, *ctxbi;
+	struct jme_ring *rxring = &(jme->rxring[0]);
+	volatile struct rxdesc *rxdesc = rxring->desc;
+	struct jme_buffer_info *rxbi = rxring->bufinf;
 	struct sk_buff *skb;
-	int i, end;
+	int framesize;
 
-#ifdef TX_TASKLET_DEBUG
-	dprintk(jme->dev->name, "into tasklet\n");
-#endif
+	rxdesc += idx;
+	rxbi += idx;
 
-	end = txring->next_to_use;
-	for(i = txring->next_to_clean ; i != end ; ) {
-		ctxbi = txbi + i;
-		skb = ctxbi->skb;
-		if(skb && !(txdesc[i].desc1.flags & TXFLAG_OWN)) {
+	skb = rxbi->skb;
+	pci_dma_sync_single_for_cpu(jme->pdev,
+					rxbi->mapping,
+					rxbi->len,
+					PCI_DMA_FROMDEVICE);
 
-#ifdef TX_TASKLET_DEBUG
-			dprintk(jme->dev->name, "cleaning %d\n", i);
-#endif
+	if(unlikely(jme_make_new_rx_buf(jme, idx))) {
+		pci_dma_sync_single_for_device(jme->pdev,
+						rxbi->mapping,
+						rxbi->len,
+						PCI_DMA_FROMDEVICE);
 
-			pci_unmap_single(jme->pdev,
-					 ctxbi->mapping,
-					 skb->len,
-					 PCI_DMA_TODEVICE);
+		++(NET_STAT(jme).rx_dropped);
+	}
+	else {
+		framesize = le16_to_cpu(rxdesc->descwb.framesize)
+				- RX_PREPAD_SIZE;
 
-			dev_kfree_skb(skb);
-			prefetch(txbi + i + 1);
-			prefetch(txdesc + i + 1);
-			ctxbi->skb = NULL;
-			ctxbi->mapping = 0;
-			ctxbi->len = skb->len;
-		}
-		else {
-			break;
-		}
+		skb_reserve(skb, RX_PREPAD_SIZE);
+		skb_put(skb, framesize);
+		skb->protocol = eth_type_trans(skb, jme->dev);
+
+		if(summed)
+			skb->ip_summed = CHECKSUM_UNNECESSARY;
+
+		netif_rx(skb);
 
-		if(unlikely(++i == RING_DESC_NR))
-			i = 0;
+		if(le16_to_cpu(rxdesc->descwb.flags) & RXWBFLAG_DEST_MUL)
+			++(NET_STAT(jme).multicast);
+
+		jme->dev->last_rx = jiffies;
+		NET_STAT(jme).rx_bytes += framesize;
+		++(NET_STAT(jme).rx_packets);
 	}
-	txring->next_to_clean = i;
+
+	jme_set_clean_rxdesc(jme, idx);
 
 }
 
-static void jme_process_receive(struct jme_adapter *jme)
+static int
+jme_rxsum_bad(struct jme_adapter *jme, __u16 flags)
 {
-	struct net_device *netdev = jme->dev;
-	struct jme_ring *rxring = &(jme->rxring[0]);
-	struct RxDesc *rxdesc = rxring->desc;
-	struct jme_buffer_info *rxbi;
-	struct sk_buff *skb;
-	dma_addr_t buf_dma;
-	int i, j, start, cnt, ccnt;
-	unsigned int framesize, desccnt;
+	if(unlikely((flags & RXWBFLAG_TCPON) &&
+	!(flags & RXWBFLAG_TCPCS))) {
+		csum_dbg(jme->dev->name, "TCP Checksum error.\n");
+		return 1;
+	}
+	else if(unlikely((flags & RXWBFLAG_UDPON) &&
+	!(flags & RXWBFLAG_UDPCS))) {
+		csum_dbg(jme->dev->name, "UDP Checksum error.\n");
+		return 1;
+	}
+	else if(unlikely((flags & RXWBFLAG_IPV4) &&
+	!(flags & RXWBFLAG_IPCS))) {
+		csum_dbg(jme->dev->name, "IPV4 Checksum error.\n");
+		return 1;
+	}
+	else {
+		return 0;
+	}
+}
 
-	/*
-	 * Assume that one descriptor per frame,
-	 * Should be fixed in the future
-	 * (or not? If buffer already large enough to store entire packet.)
-	 */
+static int
+jme_process_receive(struct jme_adapter *jme, int limit)
+{
+	struct jme_ring *rxring = &(jme->rxring[0]);
+	volatile struct rxdesc *rxdesc = rxring->desc;
+	int i, j, ccnt, desccnt;
 
-	spin_lock(&jme->recv_lock);
-	i = start = rxring->next_to_clean;
-	/*
-	 * Decide how many descriptors need to be processed
-	 * In the worst cast we'll have to process entire queue
-	 */
-	for(cnt = 0 ; cnt < RING_DESC_NR ; )
+	i = rxring->next_to_clean;
+	while( limit-- > 0 )
 	{
-		rxdesc = (struct RxDesc*)(rxring->desc) + i;
+		rxdesc = rxring->desc;
+		rxdesc += i;
+
 		if((rxdesc->descwb.flags & RXWBFLAG_OWN) ||
-		   !(rxdesc->descwb.desccnt & RXWBDCNT_WBCPL)
-		) {
-			rxring->next_to_clean = i;
-			break;
-		}
+		!(rxdesc->descwb.desccnt & RXWBDCNT_WBCPL))
+			goto out;
 
 		desccnt = rxdesc->descwb.desccnt & RXWBDCNT_DCNT;
 
-		if(unlikely((cnt += desccnt) >= RING_DESC_NR)) {
-			cnt -= desccnt;
-			break;
-		}
+		rx_dbg(jme->dev->name, "RX: Cleaning %d\n", i);
+
+		if(unlikely(desccnt > 1 ||
+		rxdesc->descwb.errstat & RXWBERR_ALLERR ||
+		jme_rxsum_bad(jme, rxdesc->descwb.flags))) {
+
+			if(rxdesc->descwb.errstat & RXWBERR_CRCERR)
+				++(NET_STAT(jme).rx_crc_errors);
+			else if(rxdesc->descwb.errstat & RXWBERR_OVERUN)
+				++(NET_STAT(jme).rx_fifo_errors);
+			else
+				++(NET_STAT(jme).rx_errors);
+
+			if(desccnt > 1) {
+				rx_dbg(jme->dev->name,
+					"RX: More than one(%d) descriptor, "
+					"framelen=%d\n",
+					desccnt, le16_to_cpu(rxdesc->descwb.framesize));
+				limit -= desccnt - 1;
+			}
 
-		if(unlikely((i += desccnt) >= RING_DESC_NR))
-			i -= RING_DESC_NR;
-	}
-	spin_unlock(&jme->recv_lock);
-
-	/*
-	 * Process descriptors independently accross cpu
-	 * 	--- save for multiple cpu handling
-	 */
-	for( i = start ; cnt-- ; ) {
-		rxdesc = (struct RxDesc*)(rxring->desc) + i;
-		desccnt = rxdesc->descwb.desccnt & RXWBDCNT_DCNT;
-		rxbi = rxring->bufinf + i;
-		if(unlikely(
-			/*
-			 * Drop and record error packet
-			 */
-			rxdesc->descwb.errstat & RXWBERR_ALLERR ||
-			desccnt > 1)) {
-			if(rxdesc->descwb.errstat & RXWBERR_OVERUN)
-				++(NET_STAT.rx_fifo_errors);
-			else if(rxdesc->descwb.errstat & RXWBERR_CRCERR)
-				++(NET_STAT.rx_frame_errors);
-			else {
-				++(NET_STAT.rx_errors);
-#ifdef RX_ERR_DEBUG
-				dprintk(netdev->name, "err: %02x\n", rxdesc->descwb.errstat);
-#endif
-			}
-
-			if(desccnt > 1)
-				cnt -= desccnt-1;
-
-			for(j=i,ccnt=desccnt;ccnt--;) {
+			for(j = i, ccnt = desccnt ; ccnt-- ; ) {
 				jme_set_clean_rxdesc(jme, j);
 
 				if(unlikely(++j == RING_DESC_NR))
 					j = 0;
 			}
+
 		}
 		else {
-			/*
-			* Pass received packet to kernel
-			*/
-			skb = rxbi->skb;
-			buf_dma = rxbi->mapping;
-			pci_dma_sync_single_for_cpu(jme->pdev,
-						    buf_dma,
-						    RX_BUF_SIZE,
-						    PCI_DMA_FROMDEVICE);
-
-			if(unlikely(jme_make_new_rx_buf(jme, i))) {
-				pci_dma_sync_single_for_device(jme->pdev,
-							       buf_dma,
-							       RX_BUF_SIZE,
-							       PCI_DMA_FROMDEVICE);
-				++(NET_STAT.rx_dropped);
-			}
-			else {
-				framesize = le16_to_cpu(rxdesc->descwb.framesize);
+			jme_alloc_and_feed_skb(jme, i,
+				(rxdesc->descwb.flags &
+					(RXWBFLAG_TCPON |
+					RXWBFLAG_UDPON |
+					RXWBFLAG_IPV4)));
+		}
 
-				skb_put(skb, framesize);
-				skb->protocol = eth_type_trans(skb, netdev);
+		if((i += desccnt) >= RING_DESC_NR)
+			i -= RING_DESC_NR;
+	}
 
-				netif_rx(skb);
+out:
+	rx_dbg(jme->dev->name, "RX: Stop at %d\n", i);
+	rx_dbg(jme->dev->name, "RX: RXNDA offset %d\n",
+		(jread32(jme, JME_RXNDA) - jread32(jme, JME_RXDBA_LO))
+			>> 4);
 
-				if(le16_to_cpu(rxdesc->descwb.flags) & RXWBFLAG_DEST_MUL)
-					++(NET_STAT.multicast);
+	rxring->next_to_clean = i;
 
-				netdev->last_rx = jiffies;
-				NET_STAT.rx_bytes += framesize;
-				++(NET_STAT.rx_packets);
-			}
+	return limit > 0 ? limit : 0;
 
-			jme_set_clean_rxdesc(jme, i);
-
-#ifdef RX_PKT_DEBUG
-			dprintk(netdev->name, "DESCCNT: %u, FSIZE: %u, ADDRH: %08x, "
-				"ADDRL: %08x, FLAGS: %04x, STAT: %02x, "
-				"DST:%02x:%02x:%02x:%02x:%02x:%02x\n",
-				desccnt,
-				framesize,
-				le32_to_cpu(rxdesc->dw[2]),
-				le32_to_cpu(rxdesc->dw[3]),
-				le16_to_cpu(rxdesc->descwb.flags),
-				rxdesc->descwb.errstat,
-				rxbuf[0], rxbuf[1], rxbuf[2],
-				rxbuf[3], rxbuf[4], rxbuf[5]);
-#endif
+}
+
+static void
+jme_attempt_pcc(struct dynpcc_info *dpi, int atmp)
+{
+	if(likely(atmp == dpi->cur))
+		return;
+
+	if(dpi->attempt == atmp) {
+		++(dpi->cnt);
+	}
+	else {
+		dpi->attempt = atmp;
+		dpi->cnt = 0;
+	}
+
+}
+
+static void
+jme_dynamic_pcc(struct jme_adapter *jme)
+{
+	register struct dynpcc_info *dpi = &(jme->dpi);
+
+	if((NET_STAT(jme).rx_bytes - dpi->last_bytes) > PCC_P3_THRESHOLD)
+		jme_attempt_pcc(dpi, PCC_P3);
+	else if((NET_STAT(jme).rx_bytes - dpi->last_bytes) > PCC_P2_THRESHOLD
+	|| dpi->intr_cnt > PCC_INTR_THRESHOLD)
+		jme_attempt_pcc(dpi, PCC_P2);
+	else
+		jme_attempt_pcc(dpi, PCC_P1);
+
+	if(unlikely(dpi->attempt != dpi->cur && dpi->cnt > 20)) {
+		jme_set_rx_pcc(jme, dpi->attempt);
+		dpi->cur = dpi->attempt;
+		dpi->cnt = 0;
+	}
+}
+
+static void
+jme_start_pcc_timer(struct jme_adapter *jme)
+{
+	struct dynpcc_info *dpi = &(jme->dpi);
+	dpi->last_bytes		= NET_STAT(jme).rx_bytes;
+	dpi->last_pkts		= NET_STAT(jme).rx_packets;
+	dpi->intr_cnt		= 0;
+	jwrite32(jme, JME_TMCSR,
+		TMCSR_EN | ((0xFFFFFF - PCC_INTERVAL_US) & TMCSR_CNT));
+}
+
+static void
+jme_pcc_tasklet(unsigned long arg)
+{
+	struct jme_adapter *jme = (struct jme_adapter*)arg;
+	struct net_device *netdev = jme->dev;
+
+	if(netif_queue_stopped(netdev)) {
+		jwrite32(jme, JME_TMCSR, 0);
+		return;
+	}
+	jme_dynamic_pcc(jme);
+	jme_start_pcc_timer(jme);
+}
+
+static void
+jme_link_change_tasklet(unsigned long arg)
+{
+	struct jme_adapter *jme = (struct jme_adapter*)arg;
+	struct net_device *netdev = jme->dev;
+	int timeout = WAIT_TASKLET_TIMEOUT;
+	int rc;
+
+	if(!atomic_dec_and_test(&jme->link_changing))
+		goto out;
+
+	if(jme_check_link(netdev, 1) && jme->oldmtu == netdev->mtu)
+		goto out;
+
+	jme->oldmtu = netdev->mtu;
+	netif_stop_queue(netdev);
+
+	while(--timeout > 0 &&
+		(
+		atomic_read(&jme->rx_cleaning) != 1 ||
+		atomic_read(&jme->tx_cleaning) != 1
+		)) {
 
+		mdelay(1);
+	}
+
+	if(netif_carrier_ok(netdev)) {
+		jme_reset_mac_processor(jme);
+		jme_free_rx_resources(jme);
+		jme_free_tx_resources(jme);
+	}
 
+	jme_check_link(netdev, 0);
+	if(netif_carrier_ok(netdev)) {
+		rc = jme_setup_rx_resources(jme);
+		if(rc) {
+			jeprintk(netdev->name,
+				"Allocating resources for RX error"
+				", Device STOPPED!\n");
+			goto out;
 		}
 
 
-		if(unlikely((i+=desccnt) >= RING_DESC_NR))
-			i -= RING_DESC_NR;
+		rc = jme_setup_tx_resources(jme);
+		if(rc) {
+			jeprintk(netdev->name,
+				"Allocating resources for TX error"
+				", Device STOPPED!\n");
+			goto err_out_free_rx_resources;
+		}
 
+		jme_enable_rx_engine(jme);
+		jme_enable_tx_engine(jme);
+
+		netif_start_queue(netdev);
+		jme_start_pcc_timer(jme);
 	}
 
+	goto out;
+
+err_out_free_rx_resources:
+	jme_free_rx_resources(jme);
+out:
+	atomic_inc(&jme->link_changing);
 }
 
-static void jme_rx_clean_tasklet(unsigned long arg)
+static void
+jme_rx_clean_tasklet(unsigned long arg)
 {
 	struct jme_adapter *jme = (struct jme_adapter*)arg;
+	struct dynpcc_info *dpi = &(jme->dpi);
+
+	if(unlikely(!atomic_dec_and_test(&jme->rx_cleaning)))
+		goto out;
 	
-	jme_process_receive(jme);
-	if(jme->flags & JME_FLAG_RXQ0_EMPTY) {
-		jme_restart_rx_engine(jme);
-		jme->flags &= ~JME_FLAG_RXQ0_EMPTY;
-	}
+	if(unlikely(atomic_read(&jme->link_changing) != 1))
+		goto out;
+
+	if(unlikely(netif_queue_stopped(jme->dev)))
+		goto out;
 
+	jme_process_receive(jme, RING_DESC_NR);
+	++(dpi->intr_cnt);
+
+out:
+	atomic_inc(&jme->rx_cleaning);
 }
 
-static irqreturn_t jme_intr(int irq, void *dev_id)
+static void
+jme_rx_empty_tasklet(unsigned long arg)
 {
-        struct net_device *netdev = dev_id;
-        struct jme_adapter *jme = netdev_priv(netdev);
-	irqreturn_t rc = IRQ_HANDLED;
-	__u32 intrstat;
+	struct jme_adapter *jme = (struct jme_adapter*)arg;
 
-#if USE_IEVE_SHADOW
-	pci_dma_sync_single_for_cpu(jme->pdev,
-				    jme->shadow_dma,
-				    sizeof(__u32) * SHADOW_REG_NR,
-				    PCI_DMA_FROMDEVICE);
-	intrstat = jme->shadow_regs[SHADOW_IEVE];
-	jme->shadow_regs[SHADOW_IEVE] = 0;
-#else
-	intrstat = jread32(jme, JME_IEVE);
-#endif
+	if(unlikely(atomic_read(&jme->link_changing) != 1))
+		return;
 
+	if(unlikely(netif_queue_stopped(jme->dev)))
+		return;
 
-#ifdef INTERRUPT_DEBUG
-	dprintk(netdev->name, "Interrupt received(%08x) @ %lu.\n", intrstat, jiffies);
-#endif
+	jme_rx_clean_tasklet(arg);
+	jme_restart_rx_engine(jme);
+}
 
-	/*
-	 * Check if it's really an interrupt for us
-	 * and if the device still exist
-	 */
-        if((intrstat & INTR_ENABLE) == 0) {
-		rc = IRQ_NONE;
+static void
+jme_tx_clean_tasklet(unsigned long arg)
+{
+	struct jme_adapter *jme = (struct jme_adapter*)arg;
+	struct jme_ring *txring = &(jme->txring[0]);
+	volatile struct txdesc *txdesc = txring->desc;
+	struct jme_buffer_info *txbi = txring->bufinf, *ctxbi, *ttxbi;
+	int i, j, cnt = 0, max, err;
+
+	if(unlikely(!atomic_dec_and_test(&jme->tx_cleaning)))
 		goto out;
-	}
-	if(unlikely(intrstat == ~((typeof(intrstat))0))) {
-                rc = IRQ_NONE;
+
+	if(unlikely(atomic_read(&jme->link_changing) != 1))
 		goto out;
+
+	if(unlikely(netif_queue_stopped(jme->dev)))
+		goto out;
+
+	max = RING_DESC_NR - atomic_read(&txring->nr_free);
+
+	tx_dbg(jme->dev->name, "Tx Tasklet: In\n");
+
+	for(i = txring->next_to_clean ; cnt < max ; ) {
+
+		ctxbi = txbi + i;
+
+		if(ctxbi->skb && !(txdesc[i].descwb.flags & TXWBFLAG_OWN)) {
+
+			err = txdesc[i].descwb.flags & TXWBFLAG_ALLERR;
+
+			tx_dbg(jme->dev->name,
+				"Tx Tasklet: Clean %d+%d\n",
+				i, ctxbi->nr_desc);
+
+			for(j = 1 ; j < ctxbi->nr_desc ; ++j) {
+				ttxbi = txbi + ((i + j) & (RING_DESC_NR - 1));
+				txdesc[(i+j)&(RING_DESC_NR-1)].dw[0] = 0;
+
+				pci_unmap_single(jme->pdev,
+						 ttxbi->mapping,
+						 ttxbi->len,
+						 PCI_DMA_TODEVICE);
+
+				if(likely(!err))
+					NET_STAT(jme).tx_bytes += ttxbi->len;
+
+				ttxbi->mapping = 0;
+				ttxbi->len = 0;
+			}
+
+			dev_kfree_skb(ctxbi->skb);
+			ctxbi->skb = NULL;
+
+			cnt += ctxbi->nr_desc;
+
+			if(unlikely(err))
+				++(NET_STAT(jme).tx_carrier_errors);
+			else
+				++(NET_STAT(jme).tx_packets);
+		}
+		else {
+			if(!ctxbi->skb)
+				tx_dbg(jme->dev->name,
+					"Tx Tasklet:"
+					" Stoped due to no skb.\n");
+			else
+				tx_dbg(jme->dev->name,
+					"Tx Tasklet:"
+					"Stoped due to not done.\n");
+			break;
+		}
+
+		if(unlikely((i += ctxbi->nr_desc) >= RING_DESC_NR))
+			i -= RING_DESC_NR;
+
+		ctxbi->nr_desc = 0;
 	}
 
+	tx_dbg(jme->dev->name,
+		"Tx Tasklet: Stop %d Jiffies %lu\n",
+		i, jiffies);
+	txring->next_to_clean = i;
+
+	atomic_add(cnt, &txring->nr_free);
 
-	if(intrstat & INTR_LINKCH) {
-		/*
-		 * Process Link status change event
-		 */
+out:
+	atomic_inc(&jme->tx_cleaning);
+}
+
+static void
+jme_intr_msi(struct jme_adapter *jme, __u32 intrstat)
+{
+	/*
+	 * Disable interrupt
+	 */
+	jwrite32f(jme, JME_IENC, INTR_ENABLE);
+
+	if(intrstat & (INTR_LINKCH | INTR_SWINTR)) {
 		tasklet_schedule(&jme->linkch_task);
+		goto out_deassert;
 	}
 
-	if(intrstat & INTR_RX0EMP) {
-		/*
-		 * Process event
-		 */
-		jme->flags |= JME_FLAG_RXQ0_EMPTY;
+	if(intrstat & INTR_TMINTR)
+		tasklet_schedule(&jme->pcc_task);
 
-                jeprintk(netdev->name, "Ranout of Receive Queue 0.\n");
-	}
+	if(intrstat & INTR_RX0EMP)
+		tasklet_schedule(&jme->rxempty_task);
 
-	if(intrstat & INTR_RX0) {
-		/*
-		 * Process event
-		 */
+	if(intrstat & (INTR_PCCRX0TO | INTR_PCCRX0))
 		tasklet_schedule(&jme->rxclean_task);
 
-#ifdef RX_PKT_DEBUG
-                dprintk(netdev->name, "Received From Queue 0.\n");
-#endif
-	}
+	if(intrstat & (INTR_PCCTXTO | INTR_PCCTX))
+		tasklet_schedule(&jme->txclean_task);
 
-	if(intrstat & INTR_TX0) {
+        if((intrstat & ~INTR_ENABLE) != 0) {
 		/*
-		 * Process event
+		 * Some interrupt not handled
+		 * but not enabled also (for debug)
 		 */
-		tasklet_schedule(&jme->txclean_task);
+	}
 
-#ifdef TX_PKT_DEBUG
-                dprintk(netdev->name, "Queue 0 transmit complete.\n");
-#endif
+out_deassert:
+	/*
+	 * Deassert interrupts
+	 */
+	jwrite32f(jme, JME_IEVE, intrstat);
+
+	/*
+	 * Re-enable interrupt
+	 */
+	jwrite32f(jme, JME_IENS, INTR_ENABLE);
+
+
+}
+
+static irqreturn_t
+jme_intr(int irq, void *dev_id)
+{
+        struct net_device *netdev = dev_id;
+        struct jme_adapter *jme = netdev_priv(netdev);
+	irqreturn_t rc = IRQ_HANDLED;
+	__u32 intrstat;
+
+	intrstat = jread32(jme, JME_IEVE);
+
+	/*
+	 * Check if it's really an interrupt for us
+	 */
+        if(unlikely(intrstat == 0)) {
+		rc = IRQ_NONE;
+		goto out;
 	}
 
-        if((intrstat & ~INTR_ENABLE) != 0) {
-#ifdef INTERRUPT_DEBUG
-		dprintk(netdev->name, "Some interrupt event not handled: %08x\n", intrstat & ~INTR_ENABLE);
-#endif
+	/*
+	 * Check if the device still exist
+	 */
+	if(unlikely(intrstat == ~((typeof(intrstat))0))) {
+                rc = IRQ_NONE;
+		goto out;
 	}
 
 	/*
-	 * Deassert interrupts
+	 * Allow one interrupt handling at a time
 	 */
-	jwrite32(jme, JME_IEVE, intrstat & INTR_ENABLE);
+        if(unlikely(!atomic_dec_and_test(&jme->intr_sem)))
+		goto out_inc;
+
+	jme_intr_msi(jme, intrstat);
+
+out_inc:
+	/*
+	 * Enable next interrupt handling
+	 */
+	atomic_inc(&jme->intr_sem);
 
 out:
         return rc;
 }
 
-static int jme_open(struct net_device *netdev)
+static irqreturn_t
+jme_msi(int irq, void *dev_id)
+{
+        struct net_device *netdev = dev_id;
+        struct jme_adapter *jme = netdev_priv(netdev);
+	__u32 intrstat;
+
+	pci_dma_sync_single_for_cpu(jme->pdev,
+				    jme->shadow_dma,
+				    sizeof(__u32) * SHADOW_REG_NR,
+				    PCI_DMA_FROMDEVICE);
+	intrstat = jme->shadow_regs[SHADOW_IEVE];
+	jme->shadow_regs[SHADOW_IEVE] = 0;
+
+	jme_intr_msi(jme, intrstat);
+
+        return IRQ_HANDLED;
+}
+
+
+static void
+jme_reset_link(struct jme_adapter *jme)
+{
+	jwrite32(jme, JME_TMCSR, TMCSR_SWIT);
+}
+
+static void
+jme_restart_an(struct jme_adapter *jme)
+{
+	__u32 bmcr;
+	unsigned long flags;
+
+	spin_lock_irqsave(&jme->phy_lock, flags);
+	bmcr = jme_mdio_read(jme->dev, jme->mii_if.phy_id, MII_BMCR);
+	bmcr |= (BMCR_ANENABLE | BMCR_ANRESTART);
+	jme_mdio_write(jme->dev, jme->mii_if.phy_id, MII_BMCR, bmcr);
+	spin_unlock_irqrestore(&jme->phy_lock, flags);
+}
+
+static int
+jme_request_irq(struct jme_adapter *jme)
 {
-	struct jme_adapter *jme = netdev_priv(netdev);
 	int rc;
+        struct net_device *netdev = jme->dev;
+        irq_handler_t handler = jme_intr;
+        int irq_flags = IRQF_SHARED;
+
+        if (!pci_enable_msi(jme->pdev)) {
+                jme->flags |= JME_FLAG_MSI;
+                handler = jme_msi;
+                irq_flags = 0;
+        }
 
-	rc = request_irq(jme->pdev->irq, jme_intr,
-			 IRQF_SHARED, netdev->name, netdev);
-	if(rc) {
-		printk(KERN_ERR PFX "Requesting IRQ error.\n");
-		goto err_out;
+        rc = request_irq(jme->pdev->irq, handler, irq_flags, netdev->name,
+                          netdev);
+        if(rc) {
+                jeprintk(netdev->name,
+			"Unable to allocate %s interrupt (return: %d)\n",
+                        jme->flags & JME_FLAG_MSI ? "MSI":"INTx",
+                        rc);
+
+                if(jme->flags & JME_FLAG_MSI) {
+                        pci_disable_msi(jme->pdev);
+			jme->flags &= ~JME_FLAG_MSI;
+		}
+        }
+	else {
+		netdev->irq = jme->pdev->irq;
 	}
 
-	rc = jme_setup_rx_resources(jme);
-	if(rc) {
-		printk(KERN_ERR PFX "Allocating resources for RX error.\n");
-		goto err_out_free_irq;
-	}
+        return rc;
+}
 
+static void
+jme_free_irq(struct jme_adapter *jme)
+{
+        free_irq(jme->pdev->irq, jme->dev);
+        if (jme->flags & JME_FLAG_MSI) {
+                pci_disable_msi(jme->pdev);
+		jme->flags &= ~JME_FLAG_MSI;
+		jme->dev->irq = jme->pdev->irq;
+        }
+}
 
-	rc = jme_setup_tx_resources(jme);
-	if(rc) {
-		printk(KERN_ERR PFX "Allocating resources for TX error.\n");
-		goto err_out_free_rx_resources;
+static int
+jme_open(struct net_device *netdev)
+{
+	struct jme_adapter *jme = netdev_priv(netdev);
+	int rc, timeout = 100;
+
+	while(
+		--timeout > 0 &&
+		(
+		atomic_read(&jme->link_changing) != 1 ||
+		atomic_read(&jme->rx_cleaning) != 1 ||
+		atomic_read(&jme->tx_cleaning) != 1
+		)
+	)
+		msleep(10);
+
+	if(!timeout) {
+		rc = -EBUSY;
+		goto err_out;
 	}
 
 	jme_reset_mac_processor(jme);
-	jme_check_link(netdev);
+
+	rc = jme_request_irq(jme);
+	if(rc)
+		goto err_out;
+
 	jme_enable_shadow(jme);
 	jme_start_irq(jme);
-	jme_enable_rx_engine(jme);
-	jme_enable_tx_engine(jme);
-	netif_start_queue(netdev);
+	jme_restart_an(jme);
 
 	return 0;
 
-err_out_free_rx_resources:
-	jme_free_rx_resources(jme);
-err_out_free_irq:
-	free_irq(jme->pdev->irq, jme->dev);
 err_out:
 	netif_stop_queue(netdev);
 	netif_carrier_off(netdev);
 	return rc;
 }
 
-static int jme_close(struct net_device *netdev)
+static int
+jme_close(struct net_device *netdev)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
 
@@ -1062,68 +1524,58 @@ static int jme_close(struct net_device *netdev)
 
 	jme_stop_irq(jme);
 	jme_disable_shadow(jme);
-	free_irq(jme->pdev->irq, jme->dev);
+	jme_free_irq(jme);
 
 	tasklet_kill(&jme->linkch_task);
 	tasklet_kill(&jme->txclean_task);
 	tasklet_kill(&jme->rxclean_task);
-	jme_disable_rx_engine(jme);
-	jme_disable_tx_engine(jme);
+	tasklet_kill(&jme->rxempty_task);
+
+	jme_reset_mac_processor(jme);
 	jme_free_rx_resources(jme);
 	jme_free_tx_resources(jme);
 
 	return 0;
 }
 
-static int jme_start_xmit(struct sk_buff *skb, struct net_device *netdev)
+/*
+ * This function is already protected by netif_tx_lock()
+ */
+static int
+jme_start_xmit(struct sk_buff *skb, struct net_device *netdev)
 {
         struct jme_adapter *jme = netdev_priv(netdev);
-	struct jme_ring *txring = &(jme->txring[0]);
-	struct TxDesc *txdesc = txring->desc;
-	int idx;
+	int rc;
 
-	/*
-	 * Check if transmit queue is already full
-	 * and take one descriptor to use
-	 */
-	spin_lock(&jme->xmit_lock);
-	idx = txring->next_to_use;
-	if(unlikely(txdesc[idx].desc1.flags & TXFLAG_OWN)) {
-		spin_unlock(&jme->xmit_lock);
-#ifdef TX_BUSY_DEBUG
-		dprintk(netdev->name, "TX Device busy.\n");
-#endif
+	if(unlikely(netif_queue_stopped(jme->dev)))
 		return NETDEV_TX_BUSY;
-	}
-	if(unlikely(++(txring->next_to_use) == RING_DESC_NR))
-		txring->next_to_use = 0;
-	spin_unlock(&jme->xmit_lock);
 
-	/*
-	 * Fill up TX descriptors
-	 */
-	jme_set_new_txdesc(jme, idx, skb);
+#if 0
+/*Testing*/
+	("jme", "Frags: %d Headlen: %d Len: %d Sum:%d\n", 
+		skb_shinfo(skb)->nr_frags,
+		skb_headlen(skb),
+		skb->len,
+		skb->ip_summed);
+/*********/
+#endif
+
+	rc = jme_set_new_txdesc(jme, skb);
+
+	if(unlikely(rc != NETDEV_TX_OK))
+		return rc;
 
-	/*
-	 * Tell MAC HW to send
-	 */
 	jwrite32(jme, JME_TXCS, jme->reg_txcs |
 				TXCS_SELECT_QUEUE0 |
 				TXCS_QUEUE0S |
 				TXCS_ENABLE);
-
-#ifdef TX_PKT_DEBUG
-	dprintk(netdev->name, "Asked to transmit.\n");
-#endif
-
-	NET_STAT.tx_bytes += skb->len;
-	++(NET_STAT.tx_packets);
 	netdev->trans_start = jiffies;
 
         return NETDEV_TX_OK;
 }
 
-static int jme_set_macaddr(struct net_device *netdev, void *p)
+static int
+jme_set_macaddr(struct net_device *netdev, void *p)
 {
         struct jme_adapter *jme = netdev_priv(netdev);
 	struct sockaddr *addr = p;
@@ -1148,68 +1600,95 @@ static int jme_set_macaddr(struct net_device *netdev, void *p)
 	return 0;
 }
 
-static void jme_set_multi(struct net_device *netdev)
+static void
+jme_set_multi(struct net_device *netdev)
 {
-        struct jme_adapter *jme = netdev_priv(netdev);
+	struct jme_adapter *jme = netdev_priv(netdev);
 	u32 mc_hash[2] = {};
-	__u32 val;
 	int i;
+	unsigned long flags;
 
+	spin_lock_irqsave(&jme->rxmcs_lock, flags);
 
-	spin_lock(&jme->macaddr_lock);
-	val = RXMCS_BRDFRAME | RXMCS_UNIFRAME;
+	jme->reg_rxmcs |= RXMCS_BRDFRAME | RXMCS_UNIFRAME;
 
-        if (netdev->flags & IFF_PROMISC)
-		val |= RXMCS_ALLFRAME;
-        else if (netdev->flags & IFF_ALLMULTI)
-		val |= RXMCS_ALLMULFRAME;
+        if (netdev->flags & IFF_PROMISC) {
+		jme->reg_rxmcs |= RXMCS_ALLFRAME;
+	}
+        else if (netdev->flags & IFF_ALLMULTI) {
+		jme->reg_rxmcs |= RXMCS_ALLMULFRAME;
+	}
 	else if(netdev->flags & IFF_MULTICAST) {
-                struct dev_mc_list *mclist;
-                int bit_nr;
+		struct dev_mc_list *mclist;
+		int bit_nr;
+
+		jme->reg_rxmcs |= RXMCS_MULFRAME | RXMCS_MULFILTERED;
+		for (i = 0, mclist = netdev->mc_list;
+			mclist && i < netdev->mc_count;
+			++i, mclist = mclist->next) {
 
-		val |= RXMCS_MULFRAME | RXMCS_MULFILTERED;
-                for (i = 0, mclist = netdev->mc_list;
-                     mclist && i < netdev->mc_count;
-                     ++i, mclist = mclist->next) {
                         bit_nr = ether_crc(ETH_ALEN, mclist->dmi_addr) & 0x3F;
                         mc_hash[bit_nr >> 5] |= 1 << (bit_nr & 0x1F);
-#ifdef SET_MULTI_DEBUG
-			dprintk(netdev->name, "Adding MCAddr: "
-				"%02x:%02x:%02x:%02x:%02x:%02x (%d)\n",
-				mclist->dmi_addr[0],
-				mclist->dmi_addr[1],
-				mclist->dmi_addr[2],
-				mclist->dmi_addr[3],
-				mclist->dmi_addr[4],
-				mclist->dmi_addr[5],
-				bit_nr);
-#endif
                 }
 
 		jwrite32(jme, JME_RXMCHT_LO, mc_hash[0]);
 		jwrite32(jme, JME_RXMCHT_HI, mc_hash[1]);
 	}
 
-
 	wmb();
-	jwrite32(jme, JME_RXMCS, val);
-	spin_unlock(&jme->macaddr_lock);
+	jwrite32(jme, JME_RXMCS, jme->reg_rxmcs);
 
-#ifdef SET_MULTI_DEBUG
-	dprintk(netdev->name, "RX Mode changed: %08x\n", val);
-#endif
+	spin_unlock_irqrestore(&jme->rxmcs_lock, flags);
 }
 
-static int jme_change_mtu(struct net_device *dev, int new_mtu)
+static int
+jme_change_mtu(struct net_device *netdev, int new_mtu)
 {
+        struct jme_adapter *jme = netdev_priv(netdev);
+
+        if (((new_mtu + ETH_HLEN) > MAX_ETHERNET_JUMBO_PACKET_SIZE) ||
+                ((new_mtu + ETH_HLEN) < MIN_ETHERNET_PACKET_SIZE))
+                return -EINVAL;
+
+	if(new_mtu > 4000) {
+		jme->reg_rxcs &= ~RXCS_FIFOTHNP;
+		jme->reg_rxcs |= RXCS_FIFOTHNP_64QW;
+		jme_restart_rx_engine(jme);
+	}
+	else {
+		jme->reg_rxcs &= ~RXCS_FIFOTHNP;
+		jme->reg_rxcs |= RXCS_FIFOTHNP_128QW;
+		jme_restart_rx_engine(jme);
+	}
+
+	if(new_mtu > 1900) {
+		netdev->features &= ~NETIF_F_HW_CSUM;
+	}
+	else {
+		netdev->features |= NETIF_F_HW_CSUM;
+	}
+
+        netdev->mtu = new_mtu;
+        jme_reset_link(jme);
+
+	return 0;
+}
+
+static void
+jme_tx_timeout(struct net_device *netdev)
+{
+        struct jme_adapter *jme = netdev_priv(netdev);
+
 	/*
-	 * Do not support MTU change for now.
+	 * Reset the link
+	 * And the link change will reinitiallize all RX/TX resources
 	 */
-	return -EINVAL;
+	jme_restart_an(jme);
 }
 
-static void jme_get_drvinfo(struct net_device *netdev,
-                             struct ethtool_drvinfo *info)
+static void
+jme_get_drvinfo(struct net_device *netdev,
+		     struct ethtool_drvinfo *info)
 {
         struct jme_adapter *jme = netdev_priv(netdev);
 
@@ -1218,44 +1697,310 @@ static void jme_get_drvinfo(struct net_device *netdev,
         strcpy(info->bus_info, pci_name(jme->pdev));
 }
 
-static int jme_get_settings(struct net_device *netdev,
-			     struct ethtool_cmd *ecmd)
+static int
+jme_get_regs_len(struct net_device *netdev)
+{
+	return 0x400;
+}
+
+static void
+mmapio_memcpy(struct jme_adapter *jme, __u32 *p, __u32 reg, int len)
+{
+	int i;
+
+	for(i = 0 ; i < len ; i += 4)
+		p[i >> 2] = jread32(jme, reg + i);
+
+}
+
+static void
+jme_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *p)
+{
+        struct jme_adapter *jme = netdev_priv(netdev);
+	__u32 *p32 = (__u32*)p;
+
+	memset(p, 0, 0x400);
+
+	regs->version = 1;
+	mmapio_memcpy(jme, p32, JME_MAC, JME_MAC_LEN);
+
+	p32 += 0x100 >> 2;
+	mmapio_memcpy(jme, p32, JME_PHY, JME_PHY_LEN);
+
+	p32 += 0x100 >> 2;
+	mmapio_memcpy(jme, p32, JME_MISC, JME_MISC_LEN);
+
+	p32 += 0x100 >> 2;
+	mmapio_memcpy(jme, p32, JME_RSS, JME_RSS_LEN);
+
+}
+
+static int
+jme_get_coalesce(struct net_device *netdev, struct ethtool_coalesce *ecmd)
+{
+	struct jme_adapter *jme = netdev_priv(netdev);
+
+	ecmd->use_adaptive_rx_coalesce = true;
+	ecmd->tx_coalesce_usecs = PCC_TX_TO;
+	ecmd->tx_max_coalesced_frames = PCC_TX_CNT;
+
+	switch(jme->dpi.cur) {
+	case PCC_P1:
+		ecmd->rx_coalesce_usecs = PCC_P1_TO;
+		ecmd->rx_max_coalesced_frames = PCC_P1_CNT;
+		break;
+	case PCC_P2:
+		ecmd->rx_coalesce_usecs = PCC_P2_TO;
+		ecmd->rx_max_coalesced_frames = PCC_P2_CNT;
+		break;
+	case PCC_P3:
+		ecmd->rx_coalesce_usecs = PCC_P3_TO;
+		ecmd->rx_max_coalesced_frames = PCC_P3_CNT;
+		break;
+	default:
+		break;
+	}
+
+	return 0;
+}
+
+/*
+ * It's not actually for coalesce.
+ * It changes internell FIFO related setting for testing.
+ */
+static int
+jme_set_coalesce(struct net_device *netdev, struct ethtool_coalesce *ecmd)
+{
+	struct jme_adapter *jme = netdev_priv(netdev);
+
+	if(ecmd->use_adaptive_rx_coalesce &&
+	ecmd->use_adaptive_tx_coalesce &&
+	ecmd->rx_coalesce_usecs == 250 &&
+	(ecmd->rx_max_coalesced_frames_low == 16 ||
+	ecmd->rx_max_coalesced_frames_low == 32 ||
+	ecmd->rx_max_coalesced_frames_low == 64 ||
+	ecmd->rx_max_coalesced_frames_low == 128)) {
+		jme->reg_rxcs &= ~RXCS_FIFOTHNP;
+		switch(ecmd->rx_max_coalesced_frames_low) {
+		case 16:
+			jme->reg_rxcs |= RXCS_FIFOTHNP_16QW;
+			break;
+		case 32:
+			jme->reg_rxcs |= RXCS_FIFOTHNP_32QW;
+			break;
+		case 64:
+			jme->reg_rxcs |= RXCS_FIFOTHNP_64QW;
+			break;
+		case 128:
+		default:
+			jme->reg_rxcs |= RXCS_FIFOTHNP_128QW;
+		}
+		jme_restart_rx_engine(jme);
+	}
+	else {
+		return -EINVAL;
+	}
+
+	return 0;
+}
+
+static void
+jme_get_pauseparam(struct net_device *netdev,
+			struct ethtool_pauseparam *ecmd)
+{
+	struct jme_adapter *jme = netdev_priv(netdev);
+	unsigned long flags;
+	__u32 val;
+
+	ecmd->tx_pause = (jme->reg_txpfc & TXPFC_PF_EN) != 0;
+	ecmd->rx_pause = (jme->reg_rxmcs & RXMCS_FLOWCTRL) != 0;
+
+	spin_lock_irqsave(&jme->phy_lock, flags);
+        val = jme_mdio_read(jme->dev, jme->mii_if.phy_id, MII_ADVERTISE);
+	spin_unlock_irqrestore(&jme->phy_lock, flags);
+	ecmd->autoneg = (val & (ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM)) != 0;
+}
+
+static int
+jme_set_pauseparam(struct net_device *netdev,
+			struct ethtool_pauseparam *ecmd)
+{
+	struct jme_adapter *jme = netdev_priv(netdev);
+	unsigned long flags;
+	__u32 val;
+
+	if( ((jme->reg_txpfc & TXPFC_PF_EN) != 0) !=
+		(ecmd->tx_pause != 0)) {
+
+		if(ecmd->tx_pause)
+			jme->reg_txpfc |= TXPFC_PF_EN;
+		else
+			jme->reg_txpfc &= ~TXPFC_PF_EN;
+
+		jwrite32(jme, JME_TXPFC, jme->reg_txpfc);
+	}
+
+	spin_lock_irqsave(&jme->rxmcs_lock, flags);
+	if( ((jme->reg_rxmcs & RXMCS_FLOWCTRL) != 0) !=
+		(ecmd->rx_pause != 0)) {
+
+		if(ecmd->rx_pause)
+			jme->reg_rxmcs |= RXMCS_FLOWCTRL;
+		else
+			jme->reg_rxmcs &= ~RXMCS_FLOWCTRL;
+
+		jwrite32(jme, JME_RXMCS, jme->reg_rxmcs);
+	}
+	spin_unlock_irqrestore(&jme->rxmcs_lock, flags);
+
+	spin_lock_irqsave(&jme->phy_lock, flags);
+        val = jme_mdio_read(jme->dev, jme->mii_if.phy_id, MII_ADVERTISE);
+	if( ((val & (ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM)) != 0) != 
+		(ecmd->autoneg != 0)) {
+
+		if(ecmd->autoneg)
+			val |= (ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);
+		else
+			val &= ~(ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);
+
+		jme_mdio_write(jme->dev, jme->mii_if.phy_id, MII_ADVERTISE, val);
+	}
+	spin_unlock_irqrestore(&jme->phy_lock, flags);
+
+	return 0;
+}
+
+static int
+jme_get_settings(struct net_device *netdev,
+		     struct ethtool_cmd *ecmd)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
 	int rc;
-	spin_lock(&jme->phy_lock);
+	unsigned long flags;
+
+	spin_lock_irqsave(&jme->phy_lock, flags);
 	rc = mii_ethtool_gset(&(jme->mii_if), ecmd);
-	spin_unlock(&jme->phy_lock);
+	spin_unlock_irqrestore(&jme->phy_lock, flags);
 	return rc;
 }
 
-static int jme_set_settings(struct net_device *netdev,
-			     struct ethtool_cmd *ecmd)
+static int
+jme_set_settings(struct net_device *netdev,
+		     struct ethtool_cmd *ecmd)
 {
 	struct jme_adapter *jme = netdev_priv(netdev);
-	int rc;
-	spin_lock(&jme->phy_lock);
+	int rc, fdc=0;
+	unsigned long flags;
+
+	if(ecmd->speed == SPEED_1000 && ecmd->autoneg != AUTONEG_ENABLE)
+		return -EINVAL;
+
+	if(jme->mii_if.force_media &&
+	ecmd->autoneg != AUTONEG_ENABLE &&
+	(jme->mii_if.full_duplex != ecmd->duplex))
+		fdc = 1;
+
+	spin_lock_irqsave(&jme->phy_lock, flags);
 	rc = mii_ethtool_sset(&(jme->mii_if), ecmd);
-	spin_unlock(&jme->phy_lock);
+	spin_unlock_irqrestore(&jme->phy_lock, flags);
+
+	if(!rc && fdc)
+		jme_reset_link(jme);
+
 	return rc;
 }
 
-static u32 jme_get_link(struct net_device *netdev) {
+static __u32
+jme_get_link(struct net_device *netdev)
+{
 	struct jme_adapter *jme = netdev_priv(netdev);
 	return jread32(jme, JME_PHY_LINK) & PHY_LINK_UP;
 }
 
+static u32
+jme_get_rx_csum(struct net_device *netdev)
+{
+        struct jme_adapter *jme = netdev_priv(netdev);
+
+	return jme->reg_rxmcs & RXMCS_CHECKSUM;
+}
+
+static int
+jme_set_rx_csum(struct net_device *netdev, u32 on)
+{
+        struct jme_adapter *jme = netdev_priv(netdev);
+	unsigned long flags;
+	
+	spin_lock_irqsave(&jme->rxmcs_lock, flags);
+	if(on)
+		jme->reg_rxmcs |= RXMCS_CHECKSUM;
+	else
+		jme->reg_rxmcs &= ~RXMCS_CHECKSUM;
+	jwrite32(jme, JME_RXMCS, jme->reg_rxmcs);
+	spin_unlock_irqrestore(&jme->rxmcs_lock, flags);
+
+	return 0;
+}
+
+static int
+jme_set_tx_csum(struct net_device *netdev, u32 on)
+{
+	if(on)
+		netdev->features |= NETIF_F_HW_CSUM;
+	else
+		netdev->features &= ~NETIF_F_HW_CSUM;
+
+	return 0;
+}
+
+static int
+jme_nway_reset(struct net_device *netdev)
+{
+        struct jme_adapter *jme = netdev_priv(netdev);
+	jme_restart_an(jme);
+	return 0;
+}
+
 static const struct ethtool_ops jme_ethtool_ops = {
         .get_drvinfo            = jme_get_drvinfo,
+	.get_regs_len		= jme_get_regs_len,
+	.get_regs		= jme_get_regs,
+	.get_coalesce		= jme_get_coalesce,
+	.set_coalesce		= jme_set_coalesce,
+        .get_pauseparam		= jme_get_pauseparam,
+        .set_pauseparam		= jme_set_pauseparam,
 	.get_settings		= jme_get_settings,
 	.set_settings		= jme_set_settings,
 	.get_link		= jme_get_link,
+	.get_rx_csum		= jme_get_rx_csum,
+	.set_rx_csum		= jme_set_rx_csum,
+	.set_tx_csum		= jme_set_tx_csum,
+	.nway_reset             = jme_nway_reset,
 };
 
-static int __devinit jme_init_one(struct pci_dev *pdev,
-                                     const struct pci_device_id *ent)
+static int
+jme_pci_dma64(struct pci_dev *pdev)
 {
-	int rc = 0;
+        if (!pci_set_dma_mask(pdev, DMA_64BIT_MASK))
+                if(!pci_set_consistent_dma_mask(pdev, DMA_64BIT_MASK))
+			return 1;
+
+        if (!pci_set_dma_mask(pdev, DMA_40BIT_MASK))
+                if(!pci_set_consistent_dma_mask(pdev, DMA_40BIT_MASK))
+			return 1;
+
+        if (!pci_set_dma_mask(pdev, DMA_32BIT_MASK))
+                if(!pci_set_consistent_dma_mask(pdev, DMA_32BIT_MASK))
+			return 0;
+
+	return -1;
+}
+
+static int __devinit
+jme_init_one(struct pci_dev *pdev,
+	     const struct pci_device_id *ent)
+{
+	int rc = 0, using_dac;
 	struct net_device *netdev;
 	struct jme_adapter *jme;
 
@@ -1268,6 +2013,13 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 		goto err_out;
 	}
 
+	using_dac = jme_pci_dma64(pdev);
+	if(using_dac < 0) {
+		printk(KERN_ERR PFX "Cannot set PCI DMA Mask.\n");
+		rc = -EIO;
+		goto err_out_disable_pdev;
+	}
+
 	if(!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM)) {
 		printk(KERN_ERR PFX "No PCI resource region found.\n");
 		rc = -ENOMEM;
@@ -1285,7 +2037,7 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 	/*
 	 * alloc and init net device
 	 */
-	netdev = alloc_etherdev(sizeof(struct jme_adapter));
+	netdev = alloc_etherdev(sizeof(*jme));
 	if(!netdev) {
 		rc = -ENOMEM;
 		goto err_out_release_regions;
@@ -1293,11 +2045,16 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 	netdev->open			= jme_open;
 	netdev->stop			= jme_close;
 	netdev->hard_start_xmit		= jme_start_xmit;
-	netdev->irq			= pdev->irq;
 	netdev->set_mac_address		= jme_set_macaddr;
 	netdev->set_multicast_list	= jme_set_multi;
 	netdev->change_mtu		= jme_change_mtu;
 	netdev->ethtool_ops		= &jme_ethtool_ops;
+	netdev->tx_timeout		= jme_tx_timeout;
+	netdev->watchdog_timeo		= TX_TIMEOUT;
+	NETDEV_GET_STATS(netdev, &jme_get_stats);
+	netdev->features		=	NETIF_F_HW_CSUM;
+	if(using_dac)
+		netdev->features	|=	NETIF_F_HIGHDMA;
 
 	SET_NETDEV_DEV(netdev, &pdev->dev);
 	pci_set_drvdata(pdev, netdev);
@@ -1308,6 +2065,8 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 	jme = netdev_priv(netdev);
 	jme->pdev = pdev;
 	jme->dev = netdev;
+	jme->oldmtu = netdev->mtu = 1500;
+	jme->phylink = 0;
 	jme->regs = ioremap(pci_resource_start(pdev, 0),
 			     pci_resource_len(pdev, 0));
 	if (!(jme->regs)) {
@@ -1322,10 +2081,18 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 		goto err_out_unmap;
 	}
 
-	spin_lock_init(&jme->xmit_lock);
-	spin_lock_init(&jme->recv_lock);
-	spin_lock_init(&jme->macaddr_lock);
 	spin_lock_init(&jme->phy_lock);
+	spin_lock_init(&jme->macaddr_lock);
+	spin_lock_init(&jme->rxmcs_lock);
+
+	atomic_set(&jme->intr_sem, 1);
+	atomic_set(&jme->link_changing, 1);
+	atomic_set(&jme->rx_cleaning, 1);
+	atomic_set(&jme->tx_cleaning, 1);
+
+	tasklet_init(&jme->pcc_task,
+		     &jme_pcc_tasklet,
+		     (unsigned long) jme);
 	tasklet_init(&jme->linkch_task,
 		     &jme_link_change_tasklet,
 		     (unsigned long) jme);
@@ -1335,23 +2102,48 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 	tasklet_init(&jme->rxclean_task,
 		     &jme_rx_clean_tasklet,
 		     (unsigned long) jme);
+	tasklet_init(&jme->rxempty_task,
+		     &jme_rx_empty_tasklet,
+		     (unsigned long) jme);
 	jme->mii_if.dev = netdev;
 	jme->mii_if.phy_id = 1;
 	jme->mii_if.supports_gmii = 1;
 	jme->mii_if.mdio_read = jme_mdio_read;
 	jme->mii_if.mdio_write = jme_mdio_write;
-#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,21)
-	netdev->get_stats = &(jme_get_stats);
-#endif
+
+	jme->dpi.cur = PCC_P1;
+
+	jme->reg_ghc = GHC_DPX | GHC_SPEED_1000M;
+	jme->reg_rxcs = RXCS_DEFAULT;
+	jme->reg_rxmcs = RXMCS_DEFAULT;
+	jme->reg_txpfc = 0;
+	/*
+	 * Get Max Read Req Size from PCI Config Space
+	 */
+	pci_read_config_byte(pdev, PCI_CONF_DCSR_MRRS, &jme->mrrs);
+	switch(jme->mrrs) {
+		case MRRS_128B:
+			jme->reg_txcs = TXCS_DEFAULT | TXCS_DMASIZE_128B;
+			break;
+		case MRRS_256B:
+			jme->reg_txcs = TXCS_DEFAULT | TXCS_DMASIZE_256B;
+			break;
+		default:
+			jme->reg_txcs = TXCS_DEFAULT | TXCS_DMASIZE_512B;
+			break;
+	};
+
 
 	/*
 	 * Reset MAC processor and reload EEPROM for MAC Address
 	 */
 	jme_clear_pm(jme);
+	jme_reset_phy_processor(jme);
 	jme_reset_mac_processor(jme);
 	rc = jme_reload_eeprom(jme);
 	if(rc) {
-		printk(KERN_ERR PFX "Rload eeprom for reading MAC Address error.\n");
+		printk(KERN_ERR PFX
+			"Rload eeprom for reading MAC Address error.\n");
 		goto err_out_free_shadow;
 	}
 	jme_load_macaddr(netdev);
@@ -1373,15 +2165,13 @@ static int __devinit jme_init_one(struct pci_dev *pdev,
 	}
 
 	jprintk(netdev->name,
-		"JMC250 gigabit eth at %llx, %02x:%02x:%02x:%02x:%02x:%02x, IRQ %d\n",
-	        (unsigned long long) pci_resource_start(pdev, 0),
+		"JMC250 gigabit eth %02x:%02x:%02x:%02x:%02x:%02x\n",
 	        netdev->dev_addr[0],
 	        netdev->dev_addr[1],
 	        netdev->dev_addr[2],
 	        netdev->dev_addr[3],
 	        netdev->dev_addr[4],
-	        netdev->dev_addr[5],
-	        pdev->irq);
+	        netdev->dev_addr[5]);
 
 	return 0;
 
@@ -1403,8 +2193,9 @@ err_out:
 	return rc;
 }
 
-static void __devexit jme_remove_one(struct pci_dev *pdev)
-{ 
+static void __devexit
+jme_remove_one(struct pci_dev *pdev)
+{
 	struct net_device *netdev = pci_get_drvdata(pdev);
 	struct jme_adapter *jme = netdev_priv(netdev);
 
@@ -1439,14 +2230,16 @@ static struct pci_driver jme_driver = {
 #endif
 };
 
-static int __init jme_init_module(void)
+static int __init
+jme_init_module(void)
 {
 	printk(KERN_INFO PFX "JMicron JMC250 gigabit ethernet "
 	       "driver version %s\n", DRV_VERSION);
 	return pci_register_driver(&jme_driver);
 }
 
-static void __exit jme_cleanup_module(void)
+static void __exit
+jme_cleanup_module(void)
 {
 	pci_unregister_driver(&jme_driver);
 }
@@ -1454,10 +2247,9 @@ static void __exit jme_cleanup_module(void)
 module_init(jme_init_module);
 module_exit(jme_cleanup_module);
 
-MODULE_AUTHOR("David Tseng <cooldavid@cooldavid.org>");
+MODULE_AUTHOR("Guo-Fu Tseng <cooldavid@cooldavid.org>");
 MODULE_DESCRIPTION("JMicron JMC2x0 PCI Express Ethernet driver");
 MODULE_LICENSE("GPL");
 MODULE_VERSION(DRV_VERSION);
 MODULE_DEVICE_TABLE(pci, jme_pci_tbl);
 
-