From: Dan Carpenter Date: Mon, 9 Aug 2010 17:06:47 +0000 (-0700) Subject: Input: cy8ctmg100_ts - signedness bug X-Git-Tag: v2.6.36-rc1~292^2^2~1 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=f1b50760a7e3d69ef5d62f294e51300dd206ea05;p=net-next-2.6.git Input: cy8ctmg100_ts - signedness bug "ret" should be signed here or the error handling doesn't work. Signed-off-by: Dan Carpenter Acked-by: Alan Cox Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/touchscreen/cy8ctmg110_ts.c b/drivers/input/touchscreen/cy8ctmg110_ts.c index 4eb7df0b7f8..5ec0946938f 100644 --- a/drivers/input/touchscreen/cy8ctmg110_ts.c +++ b/drivers/input/touchscreen/cy8ctmg110_ts.c @@ -75,7 +75,7 @@ static int cy8ctmg110_write_regs(struct cy8ctmg110 *tsc, unsigned char reg, unsigned char len, unsigned char *value) { struct i2c_client *client = tsc->client; - unsigned int ret; + int ret; unsigned char i2c_data[6]; BUG_ON(len > 5); @@ -86,7 +86,7 @@ static int cy8ctmg110_write_regs(struct cy8ctmg110 *tsc, unsigned char reg, ret = i2c_master_send(client, i2c_data, len + 1); if (ret != 1) { dev_err(&client->dev, "i2c write data cmd failed\n"); - return ret; + return ret ? ret : -EIO; } return 0; @@ -96,7 +96,7 @@ static int cy8ctmg110_read_regs(struct cy8ctmg110 *tsc, unsigned char *data, unsigned char len, unsigned char cmd) { struct i2c_client *client = tsc->client; - unsigned int ret; + int ret; struct i2c_msg msg[2] = { /* first write slave position to i2c devices */ { client->addr, 0, 1, &cmd },