From: Dan Carpenter Date: Tue, 4 May 2010 11:37:33 +0000 (-0300) Subject: V4L/DVB: media/IR/imon: precendence issue: ! vs == X-Git-Tag: v2.6.35-rc1~480^2~24 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=f03900d696079fa1e93c91af0e49c55b9b7dd105;p=net-next-2.6.git V4L/DVB: media/IR/imon: precendence issue: ! vs == The original condition is always false because ! has higher precedence than == and neither 0 nor 1 is equal to IMON_DISPLAY_TYPE_VGA. Signed-off-by: Dan Carpenter Acked-by: Jarod Wilson Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c index 27743eb0916..9ca5e864d16 100644 --- a/drivers/media/IR/imon.c +++ b/drivers/media/IR/imon.c @@ -974,7 +974,7 @@ static void imon_touch_display_timeout(unsigned long data) { struct imon_context *ictx = (struct imon_context *)data; - if (!ictx->display_type == IMON_DISPLAY_TYPE_VGA) + if (ictx->display_type != IMON_DISPLAY_TYPE_VGA) return; input_report_abs(ictx->touch, ABS_X, ictx->touch_x);