From: Dan Carpenter Date: Fri, 7 May 2010 08:53:45 +0000 (+0200) Subject: [SCSI] be2iscsi: correct return value in mgmt_invalidate_icds() X-Git-Tag: v2.6.35-rc1~38^2~10 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=e6b50c30fa8d46c9401c2d48eee2351bdbb4c51c;p=net-next-2.6.git [SCSI] be2iscsi: correct return value in mgmt_invalidate_icds() This function should return 0 on error. Returning -1 would cause a crash. Also there is an extra space before the newline character and a missing space between the "for" and the "mgmt_invalidate_icds". I put the string on one line. The current version of checkpatch.pl complains that the line is too long, but it makes grepping easier. Signed-off-by: Dan Carpenter Reviewed-by: Mike Christie Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c index e641922f20b..350cbeaae16 100644 --- a/drivers/scsi/be2iscsi/be_mgmt.c +++ b/drivers/scsi/be2iscsi/be_mgmt.c @@ -167,10 +167,9 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba, &nonemb_cmd.dma); if (nonemb_cmd.va == NULL) { SE_DEBUG(DBG_LVL_1, - "Failed to allocate memory for" - "mgmt_invalidate_icds \n"); + "Failed to allocate memory for mgmt_invalidate_icds\n"); spin_unlock(&ctrl->mbox_lock); - return -1; + return 0; } nonemb_cmd.size = sizeof(struct invalidate_commands_params_in); req = nonemb_cmd.va;