From: Dan Carpenter <error27@gmail.com>
Date: Fri, 28 May 2010 10:33:15 +0000 (+0200)
Subject: SFI: do not return freed pointer
X-Git-Tag: v2.6.35-rc2~40^2
X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=e29df91e67428c1a651d18df6ec047fcb30282d3;p=net-next-2.6.git

SFI: do not return freed pointer

We never actually use the return value of sfi_sysfs_install_table() but
it still seems wrong to return a freed pointer.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---

diff --git a/drivers/sfi/sfi_core.c b/drivers/sfi/sfi_core.c
index 00519595864..ceba593dc84 100644
--- a/drivers/sfi/sfi_core.c
+++ b/drivers/sfi/sfi_core.c
@@ -441,8 +441,10 @@ struct sfi_table_attr __init *sfi_sysfs_install_table(u64 pa)
 
 	ret = sysfs_create_bin_file(tables_kobj,
 				  &tbl_attr->attr);
-	if (ret)
+	if (ret) {
 		kfree(tbl_attr);
+		tbl_attr = NULL;
+	}
 
 	sfi_unmap_table(th);
 	return tbl_attr;