From: Axel Lin Date: Tue, 9 Mar 2010 08:53:59 +0000 (+0800) Subject: lp3971: Fix setting val for LDO2 and LDO4 X-Git-Tag: v2.6.34-rc3~40^2~2 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=cdb868f58103825856e27aa4e1f26943fc119e41;p=net-next-2.6.git lp3971: Fix setting val for LDO2 and LDO4 In lp3971_ldo_set_voltage function, it requires val to left shift 4 bits for LDO2 and LDO4. This patch fix this issue. Signed-off-by: Axel Lin Acked-by: Marek Szyprowski Acked-by: Mark Brown Signed-off-by: Liam Girdwood --- diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c index 55fab4a3064..8bdcf41ab68 100644 --- a/drivers/regulator/lp3971.c +++ b/drivers/regulator/lp3971.c @@ -187,7 +187,8 @@ static int lp3971_ldo_set_voltage(struct regulator_dev *dev, return -EINVAL; return lp3971_set_bits(lp3971, LP3971_LDO_VOL_CONTR_REG(ldo), - LDO_VOL_CONTR_MASK << LDO_VOL_CONTR_SHIFT(ldo), val); + LDO_VOL_CONTR_MASK << LDO_VOL_CONTR_SHIFT(ldo), + val << LDO_VOL_CONTR_SHIFT(ldo)); } static struct regulator_ops lp3971_ldo_ops = {