From: Vasiliy Kulikov <segooon@gmail.com>
Date: Sun, 5 Sep 2010 18:32:45 +0000 (+0400)
Subject: staging: tidspbridge: check return code of get_user
X-Git-Tag: v2.6.37-rc1~60^2~3^2~671
X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=b04462a143afde542ad9e5a1df4fcfbff6d30249;p=net-next-2.6.git

staging: tidspbridge: check return code of get_user

Function get_user may fail. Check for it.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/tidspbridge/pmgr/dspapi.c b/drivers/staging/tidspbridge/pmgr/dspapi.c
index b23591b0f41..faf8304f55e 100644
--- a/drivers/staging/tidspbridge/pmgr/dspapi.c
+++ b/drivers/staging/tidspbridge/pmgr/dspapi.c
@@ -872,7 +872,11 @@ u32 procwrap_load(union trapped_args *args, void *pr_ctxt)
 		/* number of elements in the envp array including NULL */
 		count = 0;
 		do {
-			get_user(temp, args->args_proc_load.user_envp + count);
+			if (get_user(temp,
+				     args->args_proc_load.user_envp + count)) {
+				status = -EFAULT;
+				goto func_cont;
+			}
 			count++;
 		} while (temp);
 		envp = kmalloc(count * sizeof(u8 *), GFP_KERNEL);