From: Barry Song Date: Wed, 16 Sep 2009 04:36:29 +0000 (+0000) Subject: Blackfin: add some bounds checking to peripheral_request X-Git-Tag: v2.6.33-rc1~53^2~82 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=89e84eeace5924f29a4f8f25cce9fcb083969974;p=net-next-2.6.git Blackfin: add some bounds checking to peripheral_request The requested peripheral is turned into an index into some state arrays, so make sure the calculated index doesn't exceed the index. This occurs when using bogus pin values or the define headers are screwed up. Now we'll notice right away that something needs fixing instead of trying to track down random memory corruption. Signed-off-by: Barry Song Signed-off-by: Mike Frysinger --- diff --git a/arch/blackfin/kernel/bfin_gpio.c b/arch/blackfin/kernel/bfin_gpio.c index 22705eeff34..c4161e03df7 100644 --- a/arch/blackfin/kernel/bfin_gpio.c +++ b/arch/blackfin/kernel/bfin_gpio.c @@ -762,6 +762,8 @@ int peripheral_request(unsigned short per, const char *label) if (!(per & P_DEFINED)) return -ENODEV; + BUG_ON(ident >= MAX_RESOURCES); + local_irq_save_hw(flags); /* If a pin can be muxed as either GPIO or peripheral, make