From: Aristeu Rozanski Date: Thu, 16 Oct 2008 05:04:32 +0000 (-0700) Subject: edac i5000: fix thermal issues X-Git-Tag: v2.6.28-rc1~339 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=8360e81b5dd23c153301f08937a68fd67d9b46c0;p=net-next-2.6.git edac i5000: fix thermal issues Make the Thermal messages (temperature got past Tmid) be displayed only once because: 1) it's the BIOS job to configure and handle the memory throttling 2) if the BIOS is broken or is aware about the condition, flooding the system logs won't help anything. 3) According to the specification update for Intel 5000 MCHs, all the revisions of this MCH have problems on the thermal sensors, making not automatic (a.k.a. intelligent thermal throttling) impossible. Signed-off-by: Aristeu Rozanski Signed-off-by: Doug Thompson Cc: Alan Cox Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c index 7d045ad0a1f..f0d9b415db5 100644 --- a/drivers/edac/i5000_edac.c +++ b/drivers/edac/i5000_edac.c @@ -511,8 +511,23 @@ static void i5000_process_fatal_error_info(struct mem_ctl_info *mci, "retry"; break; case FERR_FAT_M3ERR: + { + static int done; + + /* + * This error is generated to inform that the intelligent + * throttling is disabled and the temperature passed the + * specified middle point. Since this is something the BIOS + * should take care of, we'll warn only once to avoid + * worthlessly flooding the log. + */ + if (done) + return; + done++; + specific = ">Tmid Thermal event with intelligent " - "throttling disabled"; + "throttling disabled"; + } break; }