From: Sekhar Nori Date: Thu, 1 Oct 2009 07:11:06 +0000 (+0530) Subject: davinci: make it easier to identify SoC init failures X-Git-Tag: v2.6.33-rc1~348^2~28 X-Git-Url: http://bbs.cooldavid.org/git/?a=commitdiff_plain;h=69872e93d971e72cd43fdf90befaaffd8e32437a;p=net-next-2.6.git davinci: make it easier to identify SoC init failures This patch makes it easier to identify SoC init failures by panicing when SoC init fails. Without successful SoC init, the kernel eventually fails when attempt is made to access the clocks. Also, an error is printed when JTAG ID match fails to make it easier to identify failures due to SoC rev changes. Signed-off-by: Sekhar Nori Signed-off-by: Kevin Hilman --- diff --git a/arch/arm/mach-davinci/common.c b/arch/arm/mach-davinci/common.c index 61ede19c6b5..c2de94cde56 100644 --- a/arch/arm/mach-davinci/common.c +++ b/arch/arm/mach-davinci/common.c @@ -86,6 +86,8 @@ void __init davinci_common_init(struct davinci_soc_info *soc_info) dip = davinci_get_id(davinci_soc_info.jtag_id); if (!dip) { ret = -EINVAL; + pr_err("Unknown DaVinci JTAG ID 0x%x\n", + davinci_soc_info.jtag_id); goto err; } @@ -104,5 +106,5 @@ void __init davinci_common_init(struct davinci_soc_info *soc_info) return; err: - pr_err("davinci_common_init: SoC Initialization failed\n"); + panic("davinci_common_init: SoC Initialization failed\n"); }