]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
EDAC, MCE: Warn about LS MCEs on F14h
authorBorislav Petkov <borislav.petkov@amd.com>
Fri, 27 Aug 2010 15:03:34 +0000 (17:03 +0200)
committerBorislav Petkov <bp@amd64.org>
Thu, 21 Oct 2010 12:48:02 +0000 (14:48 +0200)
F14h CPUs do not generate LS MCEs so exit early and warn the user in
case this path is ever hit that something else might be going haywire.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
drivers/edac/mce_amd.c

index 60d5d9f4dfee3fa8f5eb2b9fcf331e3d7b04efb8..3c161672a84ba176da66def64eeacb7ea548dc22 100644 (file)
@@ -339,19 +339,27 @@ wrong_bu_mce:
 
 static void amd_decode_ls_mce(struct mce *m)
 {
-       u32 ec  = m->status & 0xffff;
-       u32 xec = (m->status >> 16) & 0xf;
+       u16 ec = m->status & 0xffff;
+       u8 xec = (m->status >> 16) & 0xf;
+
+       if (boot_cpu_data.x86 == 0x14) {
+               pr_emerg("You shouldn't be seeing an LS MCE on this cpu family,"
+                        " please report on LKML.\n");
+               return;
+       }
 
        pr_emerg(HW_ERR "Load Store Error");
 
        if (xec == 0x0) {
-               u8 rrrr = (ec >> 4) & 0xf;
+               u8 r4 = (ec >> 4) & 0xf;
 
-               if (!BUS_ERROR(ec) || (rrrr != 0x3 && rrrr != 0x4))
+               if (!BUS_ERROR(ec) || (r4 != R4_DRD && r4 != R4_DWR))
                        goto wrong_ls_mce;
 
                pr_cont(" during %s.\n", RRRR_MSG(ec));
-       }
+       } else
+               goto wrong_ls_mce;
+
        return;
 
 wrong_ls_mce: