]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
perf tools: Fix missing symtabs printouts
authorIngo Molnar <mingo@elte.hu>
Mon, 2 Nov 2009 18:25:25 +0000 (19:25 +0100)
committerIngo Molnar <mingo@elte.hu>
Mon, 2 Nov 2009 18:34:27 +0000 (19:34 +0100)
Fix:

  util/map.c: In function ‘map__find_symbol’:
  util/map.c:97: error: field precision should have type ‘int’, but argument 3 has type ‘size_t’

Also clean up some line wrap damage - we dont line-wrap printk
messages.

Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1256927305-4628-3-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
tools/perf/util/map.c

index f1e2169554202843487521aa23a194026b1b4933..33f868420d733fc8d827764159386ac2e5b051ac 100644 (file)
@@ -93,13 +93,12 @@ map__find_symbol(struct map *self, u64 ip, symbol_filter_t filter)
                        const size_t real_len = len - sizeof(DSO__DELETED);
 
                        if (len > sizeof(DSO__DELETED) &&
-                           strcmp(name + real_len + 1, DSO__DELETED) == 0)
-                               pr_warning("%.*s was updated, restart the "
-                                          "long running apps that use it!\n",
-                                          real_len, name);
-                       else
-                               pr_warning("no symbols found in %s, maybe "
-                                          "install a debug package?\n", name);
+                           strcmp(name + real_len + 1, DSO__DELETED) == 0) {
+                               pr_warning("%.*s was updated, restart the long running apps that use it!\n",
+                                          (int)real_len, name);
+                       } else {
+                               pr_warning("no symbols found in %s, maybe install a debug package?\n", name);
+                       }
                        return NULL;
                }
        }