]> bbs.cooldavid.org Git - net-next-2.6.git/commitdiff
IB/ehca: Do not turn off irqs in tasklet context
authorAlexander Schmidt <alexs@linux.vnet.ibm.com>
Wed, 27 Jan 2010 17:01:56 +0000 (17:01 +0000)
committerRoland Dreier <rolandd@cisco.com>
Fri, 12 Feb 2010 23:22:37 +0000 (15:22 -0800)
The irq_spinlock is only taken in tasklet context, so it is safe not to
disable hardware interrupts.

Signed-off-by: Alexander Schmidt <alexs@linux.vnet.ibm.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/ehca/ehca_irq.c

index 42be0b15084bb2445e6024eea21033d765bf7438..b2b6fea2b141f3b7c933d2fb551374623689a09d 100644 (file)
@@ -548,11 +548,10 @@ void ehca_process_eq(struct ehca_shca *shca, int is_irq)
        struct ehca_eq *eq = &shca->eq;
        struct ehca_eqe_cache_entry *eqe_cache = eq->eqe_cache;
        u64 eqe_value, ret;
-       unsigned long flags;
        int eqe_cnt, i;
        int eq_empty = 0;
 
-       spin_lock_irqsave(&eq->irq_spinlock, flags);
+       spin_lock(&eq->irq_spinlock);
        if (is_irq) {
                const int max_query_cnt = 100;
                int query_cnt = 0;
@@ -643,7 +642,7 @@ void ehca_process_eq(struct ehca_shca *shca, int is_irq)
        } while (1);
 
 unlock_irq_spinlock:
-       spin_unlock_irqrestore(&eq->irq_spinlock, flags);
+       spin_unlock(&eq->irq_spinlock);
 }
 
 void ehca_tasklet_eq(unsigned long data)